unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Federico Tedin <federicotedin@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 34001-done@debbugs.gnu.org, tinakellyrussell@gmail.com
Subject: bug#34001: 26.1.90; :distant-foreground face property fails to work in most cases
Date: Fri, 1 Mar 2019 09:44:30 -0300	[thread overview]
Message-ID: <CAA8GjPnp1+zP=pYxU+6jqYmuH1wtFE1=+u8SBKTg7i493w6Vhw@mail.gmail.com> (raw)
In-Reply-To: <83o96vhtsl.fsf@gnu.org>

[-- Attachment #1: Type: text/plain, Size: 1185 bytes --]

Thanks Eli!

I have a question regarding commit messages and documentation: should I
include them in the first iteration of the patch I created, or should I
wait until there’s been some conversation first?  Until now I’ve chosen the
first option since I’m not always sure the patch I created is
correct/applicable/etc.

On Fri, 1 Mar 2019 at 05:40 Eli Zaretskii <eliz@gnu.org> wrote:

> > From: Federico Tedin <federicotedin@gmail.com>
> > Date: Tue, 15 Jan 2019 22:08:15 -0300
> >
> > I've created a patch that introduces a new variable
> > `face-near-same-color-threshold', with a default value of 30000 (as was
> > defined in NEAR_SAME_COLOR_THRESHOLD in xfaces.c). Changing this
> > variable's value will make certain color combinations be considered as
> > 'same', which will lead to :distant-foreground being used. For example:
>
> Sorry for the long delay, I've now pushed your change to the master
> branch.
>
> Please in the future provide a ChangeLog-style commit log message for
> your changes, and also accompany them with the pertinent updates for
> the documentation.  I did that for this change.
>
> Thanks again for working on this.
>

[-- Attachment #2: Type: text/html, Size: 1649 bytes --]

  reply	other threads:[~2019-03-01 12:44 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-06 22:31 bug#34001: 26.1.90; :distant-foreground face property fails to work in most cases Tina Russell
2019-01-16  1:08 ` Federico Tedin
2019-01-20  3:20   ` Tina Russell
2019-01-20 17:15     ` Federico Tedin
2019-03-01  8:40   ` Eli Zaretskii
2019-03-01 12:44     ` Federico Tedin [this message]
2019-03-01 13:48       ` Eli Zaretskii
2019-01-21 22:58 ` Basil L. Contovounesios
2019-01-21 23:09   ` Daniel Colascione

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAA8GjPnp1+zP=pYxU+6jqYmuH1wtFE1=+u8SBKTg7i493w6Vhw@mail.gmail.com' \
    --to=federicotedin@gmail.com \
    --cc=34001-done@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    --cc=tinakellyrussell@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).