From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Federico Tedin Newsgroups: gmane.emacs.bugs Subject: bug#49723: 28.0.50; Test in coding.c for NUL bytes in filenames is not reliable Date: Sat, 18 Sep 2021 19:57:56 +0200 Message-ID: References: <83o8ary5kl.fsf@gnu.org> <87pmtbj81v.fsf@gmail.com> <8335q7c655.fsf@gnu.org> <87pmta6buq.fsf@gmail.com> <837dfgaerv.fsf@gnu.org> <8735q4zcdh.fsf@gmail.com> <83fsu38wuw.fsf@gnu.org> <87czp7xc1z.fsf@gmail.com> <83a6ka74wa.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="000000000000480a0705cc48ca81" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="13140"; mail-complaints-to="usenet@ciao.gmane.io" Cc: phst@google.com, 49723-done@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Sep 18 19:59:18 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mRecP-0003DB-57 for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 18 Sep 2021 19:59:17 +0200 Original-Received: from localhost ([::1]:48584 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mRecN-0000dX-8X for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 18 Sep 2021 13:59:15 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:49018) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mRecA-0000dO-5g for bug-gnu-emacs@gnu.org; Sat, 18 Sep 2021 13:59:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:53511) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mRec9-0001fx-Ug for bug-gnu-emacs@gnu.org; Sat, 18 Sep 2021 13:59:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mRec9-0000yg-UJ for bug-gnu-emacs@gnu.org; Sat, 18 Sep 2021 13:59:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Federico Tedin Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 18 Sep 2021 17:59:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 49723 X-GNU-PR-Package: emacs Original-Received: via spool by 49723-done@debbugs.gnu.org id=D49723.16319878963704 (code D ref 49723); Sat, 18 Sep 2021 17:59:01 +0000 Original-Received: (at 49723-done) by debbugs.gnu.org; 18 Sep 2021 17:58:16 +0000 Original-Received: from localhost ([127.0.0.1]:36824 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mRebP-0000xg-Or for submit@debbugs.gnu.org; Sat, 18 Sep 2021 13:58:16 -0400 Original-Received: from mail-io1-f49.google.com ([209.85.166.49]:42850) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mRebM-0000xS-PR for 49723-done@debbugs.gnu.org; Sat, 18 Sep 2021 13:58:14 -0400 Original-Received: by mail-io1-f49.google.com with SMTP id b10so16452302ioq.9 for <49723-done@debbugs.gnu.org>; Sat, 18 Sep 2021 10:58:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=GLP0kJC4Wsq20IM5BXoDuZKsfGnSaG8NkqmK8fu6rZg=; b=Tib+P34spQziqBflLWUL652v5lbS+f7NxgPMoCwMflLLL5ewzIR3Q1EMZc1Amt72aE fqFUOAIYtkxT5ZpVNV46SGOVD6MPr91fe1sJMuC28EVaVgQDL3exKtX+ysvZbESdN90v tNF7PRFcfbnwVDjAgfamSGyrcYMpRDM1QcECUfrO0nx69VMNiwOgkM6zOdT5NL5f+APg D68BU/aEOG7hu0OvWFtH+5QOu6LHUf6PgzFxnF7N3d1LADF2rHqCYpcDhlVibeuGbe7E 0PBB3XpI8cp/Lejo8Ua4bDNCEuAvJEMKVL4GKcZSP3RBJZVw4zfmUc5OdGaMY0BRGbzd tfQQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=GLP0kJC4Wsq20IM5BXoDuZKsfGnSaG8NkqmK8fu6rZg=; b=SP1jkHjn90/JG/Fvkq7CETmfIqCINisCcnsWsp3FpZsLK+TyxJ4BCbMSe2itO6sClc jbCOnUJ6oZnt0LZNxD01ew0vPw7xz8Zqrn0oPkP5uRIFmV1x43+e9bv5zvyDAGEsuX5f KAcFWmac74mBWOc9U8fHNeq/fA6RyNGoZ2Kjcr7k3CyseDSSumudtJIiMdk1jTGmDeyc xkYWuzu05zXA3Ow0FNQW8TTsDmDn3b5SwIy2QsO0fVagAl+dkrictfTjI/558Ao3MGHd wvJyTkkVheKK3d5//kTfFQp/BNBt4WazziKpv0V7ldK7969JzThmDgALPwC8vN3GpjIf RyNw== X-Gm-Message-State: AOAM533DmjsiiqPTrF221hnSX0mc01cvDX2ziF5fPf5jB9UihqVtdZtw VVVZ8pOdAgieAs/ckQQVoMt8Qpcp0t5O9VAbr+M= X-Google-Smtp-Source: ABdhPJx4i6DqGI54XaxOoOuKqqQF/627w1jFu0pOL4rPBI1cuiY+airtLs5RBX622JnUOcTX11QRNal4RkgkPsJDth4= X-Received: by 2002:a05:6638:34a6:: with SMTP id t38mr13777583jal.19.1631987886982; Sat, 18 Sep 2021 10:58:06 -0700 (PDT) In-Reply-To: <83a6ka74wa.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:214649 Archived-At: --000000000000480a0705cc48ca81 Content-Type: text/plain; charset="UTF-8" Noted! Thank you. Eli Zaretskii schrieb am Sa. 18. Sept. 2021 um 08:51: > > From: Federico Tedin > > Cc: phst@google.com, 49723@debbugs.gnu.org > > Date: Fri, 17 Sep 2021 21:00:08 +0200 > > > > > Thanks. Did you run the test suite after applying the changes, and > > > did you see no regressions? If you didn't yet run the test suite, > > > please be sure to run all of it, as the use of expand-file-name is > > > universal. > > > > I hadn't, so I checked out master aa59d38c59 and applied my patch on top > > of it. I then ran "make check" and waited for a bit. There appears to be > > only two tests failing in test/lisp/time-stamp-tests.el > > ('time-stamp-format-day-of-week' and > > 'time-stamp-format-string-width'). Both seem to be unrelated to my > > change; maybe it's my system's strange combination of > > Spanish/English/German locale-related configurations (I'm attaching the > > log just in case). All other test files were run without problems. > > Thanks. I installed your changes, and I'm therefore closing this bug. > > A few minor stylistic comments, for the future > > . the lines in the commit log message are too wide, they should be at > most 66 characters, because we produce ChangeLog files from Girt > logs, and ChangeLog files have the fill-column set to 74, which > includes 9-column TAB (perhaps this means the fill-column setting > in .dire-locals.el should be amended?) > . please quote symbols in commit log messages rather than leaving > them unquoted (this doesn't apply to symbols in parentheses that > state the functions which were changed) > . please try to establish whether the changes need to be described in > the manual(s), and mark the NEWS entries accordingly (if you decide > there's a need to describe in the manual, please also include a > suitable change for that) > > Thanks again for working on this. > --000000000000480a0705cc48ca81 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Noted! Thank you.

Eli Zaretskii <eliz@gnu.org> schrieb am Sa. 18. Sept. 2021 um 08:51:=
> From: Federico Tedin <federicotedin@gmail.com><= br> > Cc: phst@google.c= om,=C2=A0 49= 723@debbugs.gnu.org
> Date: Fri, 17 Sep 2021 21:00:08 +0200
>
> > Thanks.=C2=A0 Did you run the test suite after applying the chang= es, and
> > did you see no regressions?=C2=A0 If you didn't yet run the t= est suite,
> > please be sure to run all of it, as the use of expand-file-name i= s
> > universal.
>
> I hadn't, so I checked out master aa59d38c59 and applied my patch = on top
> of it. I then ran "make check" and waited for a bit. There a= ppears to be
> only two tests failing in test/lisp/time-stamp-tests.el
> ('time-stamp-format-day-of-week' and
> 'time-stamp-format-string-width'). Both seem to be unrelated t= o my
> change; maybe it's my system's strange combination of
> Spanish/English/German locale-related configurations (I'm attachin= g the
> log just in case). All other test files were run without problems.

Thanks.=C2=A0 I installed your changes, and I'm therefore closing this = bug.

A few minor stylistic comments, for the future

=C2=A0. the lines in the commit log message are too wide, they should be at=
=C2=A0 =C2=A0most 66 characters, because we produce ChangeLog files from Gi= rt
=C2=A0 =C2=A0logs, and ChangeLog files have the fill-column set to 74, whic= h
=C2=A0 =C2=A0includes 9-column TAB (perhaps this means the fill-column sett= ing
=C2=A0 =C2=A0in .dire-locals.el should be amended?)
=C2=A0. please quote symbols in commit log messages rather than leaving
=C2=A0 =C2=A0them unquoted (this doesn't apply to symbols in parenthese= s that
=C2=A0 =C2=A0state the functions which were changed)
=C2=A0. please try to establish whether the changes need to be described in=
=C2=A0 =C2=A0the manual(s), and mark the NEWS entries accordingly (if you d= ecide
=C2=A0 =C2=A0there's a need to describe in the manual, please also incl= ude a
=C2=A0 =C2=A0suitable change for that)

Thanks again for working on this.
--000000000000480a0705cc48ca81--