From: Federico Tedin <federicotedin@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: phst@google.com, 49723-done@debbugs.gnu.org
Subject: bug#49723: 28.0.50; Test in coding.c for NUL bytes in filenames is not reliable
Date: Sat, 18 Sep 2021 19:57:56 +0200 [thread overview]
Message-ID: <CAA8GjPkEmZdQA+0b2__Bgmc-30GQ=0_fGO91FJb1Audwe3KGew@mail.gmail.com> (raw)
In-Reply-To: <83a6ka74wa.fsf@gnu.org>
[-- Attachment #1: Type: text/plain, Size: 1931 bytes --]
Noted! Thank you.
Eli Zaretskii <eliz@gnu.org> schrieb am Sa. 18. Sept. 2021 um 08:51:
> > From: Federico Tedin <federicotedin@gmail.com>
> > Cc: phst@google.com, 49723@debbugs.gnu.org
> > Date: Fri, 17 Sep 2021 21:00:08 +0200
> >
> > > Thanks. Did you run the test suite after applying the changes, and
> > > did you see no regressions? If you didn't yet run the test suite,
> > > please be sure to run all of it, as the use of expand-file-name is
> > > universal.
> >
> > I hadn't, so I checked out master aa59d38c59 and applied my patch on top
> > of it. I then ran "make check" and waited for a bit. There appears to be
> > only two tests failing in test/lisp/time-stamp-tests.el
> > ('time-stamp-format-day-of-week' and
> > 'time-stamp-format-string-width'). Both seem to be unrelated to my
> > change; maybe it's my system's strange combination of
> > Spanish/English/German locale-related configurations (I'm attaching the
> > log just in case). All other test files were run without problems.
>
> Thanks. I installed your changes, and I'm therefore closing this bug.
>
> A few minor stylistic comments, for the future
>
> . the lines in the commit log message are too wide, they should be at
> most 66 characters, because we produce ChangeLog files from Girt
> logs, and ChangeLog files have the fill-column set to 74, which
> includes 9-column TAB (perhaps this means the fill-column setting
> in .dire-locals.el should be amended?)
> . please quote symbols in commit log messages rather than leaving
> them unquoted (this doesn't apply to symbols in parentheses that
> state the functions which were changed)
> . please try to establish whether the changes need to be described in
> the manual(s), and mark the NEWS entries accordingly (if you decide
> there's a need to describe in the manual, please also include a
> suitable change for that)
>
> Thanks again for working on this.
>
[-- Attachment #2: Type: text/html, Size: 2694 bytes --]
prev parent reply other threads:[~2021-09-18 17:57 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-24 17:39 bug#49723: 28.0.50; Test in coding.c for NUL bytes in filenames is not reliable Eli Zaretskii
2021-09-14 19:01 ` Federico Tedin
2021-09-14 19:24 ` Eli Zaretskii
2021-09-14 22:17 ` Federico Tedin
2021-09-16 12:25 ` Eli Zaretskii
2021-09-16 16:58 ` Federico Tedin
2021-09-16 18:12 ` Michael Albinus
2021-09-16 18:30 ` Eli Zaretskii
2021-09-16 18:44 ` Michael Albinus
2021-09-16 19:07 ` Eli Zaretskii
2021-09-16 18:38 ` Federico Tedin
2021-09-16 18:51 ` Michael Albinus
2021-09-16 19:13 ` Federico Tedin
2021-09-20 11:59 ` Michael Albinus
2021-09-17 7:49 ` Eli Zaretskii
2021-09-17 19:00 ` Federico Tedin
2021-09-18 6:51 ` Eli Zaretskii
2021-09-18 17:57 ` Federico Tedin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAA8GjPkEmZdQA+0b2__Bgmc-30GQ=0_fGO91FJb1Audwe3KGew@mail.gmail.com' \
--to=federicotedin@gmail.com \
--cc=49723-done@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=phst@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).