From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Alex Murray Newsgroups: gmane.emacs.bugs Subject: bug#35141: Add a default action to erc-desktop-notifications to switch to the originating buffer Date: Sat, 6 Apr 2019 20:22:38 +1030 Message-ID: References: <87wok919ox.fsf@tcd.ie> <87d0m08zni.fsf@tcd.ie> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="000000000000466dc70585d99188" Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="161332"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 35141@debbugs.gnu.org To: "Basil L. Contovounesios" Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Apr 06 11:55:15 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hCi2c-000fpb-Q9 for geb-bug-gnu-emacs@m.gmane.org; Sat, 06 Apr 2019 11:55:15 +0200 Original-Received: from localhost ([127.0.0.1]:52843 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hCi2b-0007jD-IS for geb-bug-gnu-emacs@m.gmane.org; Sat, 06 Apr 2019 05:55:13 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:34460) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hCi2U-0007ij-QU for bug-gnu-emacs@gnu.org; Sat, 06 Apr 2019 05:55:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hCi1S-0002bt-FQ for bug-gnu-emacs@gnu.org; Sat, 06 Apr 2019 05:54:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:33028) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hCi1S-0002bf-2l for bug-gnu-emacs@gnu.org; Sat, 06 Apr 2019 05:54:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hCi1R-0007SV-W8 for bug-gnu-emacs@gnu.org; Sat, 06 Apr 2019 05:54:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Alex Murray Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 06 Apr 2019 09:54:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35141 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 35141-submit@debbugs.gnu.org id=B35141.155454438428609 (code B ref 35141); Sat, 06 Apr 2019 09:54:01 +0000 Original-Received: (at 35141) by debbugs.gnu.org; 6 Apr 2019 09:53:04 +0000 Original-Received: from localhost ([127.0.0.1]:46572 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hCi0V-0007RN-Uw for submit@debbugs.gnu.org; Sat, 06 Apr 2019 05:53:04 -0400 Original-Received: from mail-wr1-f54.google.com ([209.85.221.54]:34580) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hCi0T-0007Qp-E3 for 35141@debbugs.gnu.org; Sat, 06 Apr 2019 05:53:02 -0400 Original-Received: by mail-wr1-f54.google.com with SMTP id p10so10696800wrq.1 for <35141@debbugs.gnu.org>; Sat, 06 Apr 2019 02:53:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=yLX7FX3vkH/EilWBzQWgRJ3Z1bMZuQ90184dyESlRaA=; b=fv/ROPIADg42EV2M0EFDg9CZvtHnBRq9aRr1Oa6Z2ZYWL0zyQZx5R/UqkmtoPjBblJ Em/eFAbl0i9bkADTxtv+bicKCK4mEBKaxkuJzV2Ku8FqY+8LmdGMkOE32HQw3rSU7BAU nNJ34zKUsmOipr7/JJCxO/ssjhwQs7am4/vLUjSfyU0u3sEluK3MDuOofksHa3C1tBvU ZFM7umlLIZTVym6bKgRWR0RjzM1e+10vg9xHC3JYvI3fD6SHHjstZAxsySp9hKV5GUCy BK8AFngyktuY/q9Bac+IFzzV02LyzLnq9gimNPmjTnnYsmAEc/K2ZtMvX0rEuQqU8N2P 1gHA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=yLX7FX3vkH/EilWBzQWgRJ3Z1bMZuQ90184dyESlRaA=; b=rG3h1f4IZI+w3QRlVS6Hh5Ca7K3K1xR146NeluviujprlSDz2/ccPOXAw/Rt41xdj8 vWy8q9pmWVafq3jF230/pu1vFn+5EbWd7QJ6jle9mhZ/RwYzqMpZEdSOdkW7NY4aGzNp lrI9voZEGZrQv2FLI8q9WUTKiuPKxMUumDuejqf4pPQ8bVpEIZ0G76V8LTVOYimxUykD pUhdGwtwVBS9051+03m8rej6sOHEYhfEBBaL7W7gj6m1QEwMEWVI5mLqwn34gb96ngXu 9k068RjpGDdoh2IuTCQuIMXDTNaJ+vMUqZok08glM37NS2+PCK+8rN12dvHzcHKKfLCd tDkA== X-Gm-Message-State: APjAAAWNAJo+oX0WuO4c/RjPuf5jI+V2Qd67n+jus+mAs7nrIT44tALA VyX9YA3rGw1tHWoT+CjONCDf1eNi6bnykqJzXQ4= X-Google-Smtp-Source: APXvYqz8D42P4ku0uLxFT+QXvdGfvZL1LArrF0MAv+GuPX1dWo8r36BsFni202AnN8BaRJI07+28AyPV7vClgsjIcpw= X-Received: by 2002:a5d:634c:: with SMTP id b12mr11886947wrw.203.1554544375248; Sat, 06 Apr 2019 02:52:55 -0700 (PDT) In-Reply-To: <87d0m08zni.fsf@tcd.ie> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:157262 Archived-At: --000000000000466dc70585d99188 Content-Type: multipart/alternative; boundary="000000000000466dbe0585d99186" --000000000000466dbe0585d99186 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Done - see attached. Thanks again for your help. On Fri, 5 Apr 2019 at 21:52, Basil L. Contovounesios wrote: > Alex Murray writes: > > > Thanks for the review - see attached for an updated version based on > your feedback. > > I just tried byte-compiling the patched file and got the following > warning: > > ELC erc/erc-desktop-notifications.elc > In toplevel form: > erc/erc-desktop-notifications.el:74:1: > Warning: Unused lexical argument =E2=80=98proc=E2=80=99 > > Since this arises because of lexical-binding, could you please also add > an underscore to the name of the PROC argument in > erc-notifications-PRIVMSG? > > Otherwise LGTM, but we'll have to wait a few days to give others a > chance to comment. > > Thanks, > > -- > Basil > --000000000000466dbe0585d99186 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Done - see attached. Thanks again for your help.
On Fr= i, 5 Apr 2019 at 21:52, Basil L. Contovounesios <contovob@tcd.ie> wrote:
Alex Murray <murray.alex@gmail.com> writes:

> Thanks for the review - see attached for an updated version based on y= our feedback.

I just tried byte-compiling the patched file and got the following
warning:

=C2=A0 ELC=C2=A0 =C2=A0 =C2=A0 erc/erc-desktop-notifications.elc
=C2=A0 In toplevel form:
=C2=A0 erc/erc-desktop-notifications.el:74:1:
=C2=A0 Warning: Unused lexical argument =E2=80=98proc=E2=80=99

Since this arises because of lexical-binding, could you please also add
an underscore to the name of the PROC argument in
erc-notifications-PRIVMSG?

Otherwise LGTM, but we'll have to wait a few days to give others a
chance to comment.

Thanks,

--
Basil
--000000000000466dbe0585d99186-- --000000000000466dc70585d99188 Content-Type: text/x-patch; charset="US-ASCII"; name="0001-Switch-to-originating-erc-buffer-when-clicking-deskt.patch" Content-Disposition: attachment; filename="0001-Switch-to-originating-erc-buffer-when-clicking-deskt.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_ju5bkksn0 RnJvbSA1ODY3N2I0OTNiYThmYmRjMzJiZTdlNzc2MzQ2M2I2YzZjYzU5YTBkIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBBbGV4IE11cnJheSA8bXVycmF5LmFsZXhAZ21haWwuY29tPgpE YXRlOiBUaHUsIDQgQXByIDIwMTkgMTY6NDk6NDggKzEwMzAKU3ViamVjdDogW1BBVENIXSBTd2l0 Y2ggdG8gb3JpZ2luYXRpbmcgZXJjIGJ1ZmZlciB3aGVuIGNsaWNraW5nIGRlc2t0b3AKIG5vdGlm aWNhdGlvbgoKKiBsaXNwL2VyYy9lcmMtZGVza3RvcC1ub3RpZmljYXRpb25zLmVsOiBTd2l0Y2gg dG8gbGV4aWNhbC1iaW5kaW5nLgogIChlcmMtbm90aWZpY2F0aW9ucy1ub3RpZnkpIEFkZCBhIGRl ZmF1bHQgYWN0aW9uIHRvIHRoZSBkZXNrdG9wCiAgbm90aWZpY2F0aW9uIHdoaWNoIHN3aXRjaGVz IHRvIHRoZSBidWZmZXIgZnJvbSB3aGljaCB0aGUKICBub3RpZmljYXRpb24gb3JpZ2luYXRlZC4g QXMgc3VjaCBjbGlja2luZyBvbiB0aGUgbm90aWZpY2F0aW9uIG5vdwogIGF1dG9tYXRpY2FsbHkg c3dpdGNoZXMgdG8gdGhhdCBidWZmZXIuIChCdWcjMzUxNDEpCgpDb3B5cmlnaHQtcGFwZXJ3b3Jr LWV4ZW1wdDogeWVzCi0tLQogbGlzcC9lcmMvZXJjLWRlc2t0b3Atbm90aWZpY2F0aW9ucy5lbCB8 IDIyICsrKysrKysrKysrKysrLS0tLS0tLS0KIDEgZmlsZSBjaGFuZ2VkLCAxNCBpbnNlcnRpb25z KCspLCA4IGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL2xpc3AvZXJjL2VyYy1kZXNrdG9wLW5v dGlmaWNhdGlvbnMuZWwgYi9saXNwL2VyYy9lcmMtZGVza3RvcC1ub3RpZmljYXRpb25zLmVsCmlu ZGV4IDU2YjkzOTI1Y2UuLjQxYjc0MjAzMjAgMTAwNjQ0Ci0tLSBhL2xpc3AvZXJjL2VyYy1kZXNr dG9wLW5vdGlmaWNhdGlvbnMuZWwKKysrIGIvbGlzcC9lcmMvZXJjLWRlc2t0b3Atbm90aWZpY2F0 aW9ucy5lbApAQCAtMSw0ICsxLDQgQEAKLTs7IGVyYy1kZXNrdG9wLW5vdGlmaWNhdGlvbnMuZWwg LS0gU2VuZCBub3RpZmljYXRpb24gb24gUFJJVk1TRyBvciBtZW50aW9ucworOzsgZXJjLWRlc2t0 b3Atbm90aWZpY2F0aW9ucy5lbCAtLSBTZW5kIG5vdGlmaWNhdGlvbiBvbiBQUklWTVNHIG9yIG1l bnRpb25zIC0qLSBsZXhpY2FsLWJpbmRpbmc6dCAtKi0KIAogOzsgQ29weXJpZ2h0IChDKSAyMDEy LTIwMTkgRnJlZSBTb2Z0d2FyZSBGb3VuZGF0aW9uLCBJbmMuCiAKQEAgLTU5LDEzICs1OSwxOSBA QAogVGhpcyB3aWxsIHJlcGxhY2UgdGhlIGxhc3Qgbm90aWZpY2F0aW9uIHNlbnQgd2l0aCB0aGlz IGZ1bmN0aW9uLiIKICAgKGRidXMtaWdub3JlLWVycm9ycwogICAgIChzZXRxIGVyYy1ub3RpZmlj YXRpb25zLWxhc3Qtbm90aWZpY2F0aW9uCi0gICAgICAgICAgKG5vdGlmaWNhdGlvbnMtbm90aWZ5 IDpidXMgZXJjLW5vdGlmaWNhdGlvbnMtYnVzCi0JCQkJOnRpdGxlICh4bWwtZXNjYXBlLXN0cmlu ZyBuaWNrKQotICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICA6Ym9keSAoeG1sLWVzY2Fw ZS1zdHJpbmcgbXNnKQotICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICA6cmVwbGFjZXMt aWQgZXJjLW5vdGlmaWNhdGlvbnMtbGFzdC1ub3RpZmljYXRpb24KLSAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgOmFwcC1pY29uIGVyYy1ub3RpZmljYXRpb25zLWljb24pKSkpCi0KLShk ZWZ1biBlcmMtbm90aWZpY2F0aW9ucy1QUklWTVNHIChwcm9jIHBhcnNlZCkKKyAgICAgICAgICAo bGV0ICgoY2hhbm5lbCAoY3VycmVudC1idWZmZXIpKSkKKyAgICAgICAgICAgIChub3RpZmljYXRp b25zLW5vdGlmeSA6YnVzIGVyYy1ub3RpZmljYXRpb25zLWJ1cworICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgIDp0aXRsZSAoZm9ybWF0ICIlcyBpbiAlcyIKKyAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAoeG1sLWVzY2FwZS1zdHJpbmcgbmlj aykKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBjaGFu bmVsKQorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIDpib2R5ICh4bWwtZXNjYXBl LXN0cmluZyBtc2cpCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgOnJlcGxhY2Vz LWlkIGVyYy1ub3RpZmljYXRpb25zLWxhc3Qtbm90aWZpY2F0aW9uCisgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgOmFwcC1pY29uIGVyYy1ub3RpZmljYXRpb25zLWljb24KKyAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICA6YWN0aW9ucyAnKCJkZWZhdWx0IiAiU3dpdGNo IHRvIGJ1ZmZlciIpCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgOm9uLWFjdGlv biAobGFtYmRhICgmcmVzdCBfKQorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAocG9wLXRvLWJ1ZmZlciBjaGFubmVsKSkpKSkpKQorCisoZGVmdW4gZXJjLW5v dGlmaWNhdGlvbnMtUFJJVk1TRyAoX3Byb2MgcGFyc2VkKQogICAobGV0ICgobmljayAoY2FyIChl cmMtcGFyc2UtdXNlciAoZXJjLXJlc3BvbnNlLnNlbmRlciBwYXJzZWQpKSkpCiAgICAgICAgICh0 YXJnZXQgKGNhciAoZXJjLXJlc3BvbnNlLmNvbW1hbmQtYXJncyBwYXJzZWQpKSkKICAgICAgICAg KG1zZyAoZXJjLXJlc3BvbnNlLmNvbnRlbnRzIHBhcnNlZCkpKQotLSAKMi4xNy4xCgo= --000000000000466dc70585d99188--