From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Oleh Krehel Newsgroups: gmane.emacs.bugs Subject: bug#20357: 25.0.50; deactivate-mark behavior broken Date: Fri, 17 Apr 2015 20:30:14 +0200 Message-ID: References: <87pp735a42.fsf@gmail.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-Trace: ger.gmane.org 1429295496 2233 80.91.229.3 (17 Apr 2015 18:31:36 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 17 Apr 2015 18:31:36 +0000 (UTC) Cc: 20357-done@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Apr 17 20:31:27 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1YjB2l-000134-ES for geb-bug-gnu-emacs@m.gmane.org; Fri, 17 Apr 2015 20:31:11 +0200 Original-Received: from localhost ([::1]:43044 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YjB2k-0002gz-OH for geb-bug-gnu-emacs@m.gmane.org; Fri, 17 Apr 2015 14:31:10 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:41095) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YjB2g-0002gj-Fz for bug-gnu-emacs@gnu.org; Fri, 17 Apr 2015 14:31:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YjB2c-0007eQ-CA for bug-gnu-emacs@gnu.org; Fri, 17 Apr 2015 14:31:06 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:41302) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YjB2c-0007eL-92 for bug-gnu-emacs@gnu.org; Fri, 17 Apr 2015 14:31:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1YjB2b-0007am-SV for bug-gnu-emacs@gnu.org; Fri, 17 Apr 2015 14:31:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Oleh Krehel Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 17 Apr 2015 18:31:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 20357 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 20357-done@debbugs.gnu.org id=D20357.142929542529141 (code D ref 20357); Fri, 17 Apr 2015 18:31:01 +0000 Original-Received: (at 20357-done) by debbugs.gnu.org; 17 Apr 2015 18:30:25 +0000 Original-Received: from localhost ([127.0.0.1]:59311 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YjB1z-0007Zv-57 for submit@debbugs.gnu.org; Fri, 17 Apr 2015 14:30:23 -0400 Original-Received: from mail-wg0-f53.google.com ([74.125.82.53]:35757) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YjB1w-0007Yt-Lm for 20357-done@debbugs.gnu.org; Fri, 17 Apr 2015 14:30:21 -0400 Original-Received: by wgyo15 with SMTP id o15so121916945wgy.2 for <20357-done@debbugs.gnu.org>; Fri, 17 Apr 2015 11:30:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=gd71L5KJArlUWewI5GagUcc3hliKJt7Bk4iUhn+9GrA=; b=tc0hdc3bdo39zLjICoMjdBi/AVTrZiVpysqtXaJcrzz+2TPZ5spoy+/6G+93LTc7Ry YSFju9eQhehRhvGUBqmVEvkTUelqHuJmRI2i+sxhC42AIw8H7qSY5cIFgwi6mY2nasmA W6vtsndWtnbw69MlYJPBsPfr4SqcVsuNxoJzcPfalItFybsV9KgztuKN4R5YTaAjJ5EC EP1SacmfzjTjnUT3yzID6MBEstbUl6cTYSWS9j4IbqyVAMjiu/thqrUteDOYI9TxV+Tu zzGC0fqh4c50ojlrL3Aj41mWb/HF2cP0dzFU6BQ707Vmujmdcdz5hOh4nYsfuvpxIq8n QFAg== X-Received: by 10.194.143.20 with SMTP id sa20mr8150244wjb.16.1429295414896; Fri, 17 Apr 2015 11:30:14 -0700 (PDT) Original-Received: by 10.27.215.21 with HTTP; Fri, 17 Apr 2015 11:30:14 -0700 (PDT) In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:101649 Archived-At: On Fri, Apr 17, 2015 at 8:22 PM, Stefan Monnier wrote: >> (with-temp-buffer >> (insert "foobar") >> (set-mark (point)) >> (goto-char (point-min)) >> (indent-region (point-min) >> (point-max)) >> mark-active) >> In 24.5 it returns nil, which is correct. While in 25 it returns t. > > Why is it more correct to return nil than to return t? Because it's a long standing behavior that if you mark some stuff and press TAB, the mark will be deactivated. And in 25, the mark actually is deactivated outside of temp buffers, which is where I run my ERT tests. So the tests are passing for 24.5 and failing for 25, while the functions actually do work in both. > >> This is a recent change, 24.5.2 doesn't have this bug. >> >> (let (deactivate-mark) >> (indent-region (region-beginning) >> (region-end))) >> >> Expected behavior: the mark isn't deactivated. > > At least in 24.4, the mark does get deactivated in my test. This may be possible. Previously, I was testing using the emacs24 ppa install, that uses emacs-24.3. I've started testing with emacs-snapshot only this week, and the tests started failing. But when I've tested with 24.5 or 25 on my own machine, the tests were running fine. Oleh