From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Oleh Krehel Newsgroups: gmane.emacs.bugs Subject: bug#20357: 25.0.50; deactivate-mark behavior broken Date: Fri, 17 Apr 2015 18:02:57 +0200 Message-ID: References: <87pp735a42.fsf@gmail.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-Trace: ger.gmane.org 1429286660 7649 80.91.229.3 (17 Apr 2015 16:04:20 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 17 Apr 2015 16:04:20 +0000 (UTC) Cc: 20357-done@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Apr 17 18:04:14 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Yj8kY-0003ph-Dp for geb-bug-gnu-emacs@m.gmane.org; Fri, 17 Apr 2015 18:04:14 +0200 Original-Received: from localhost ([::1]:42431 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yj8kX-0003tr-9A for geb-bug-gnu-emacs@m.gmane.org; Fri, 17 Apr 2015 12:04:13 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:60159) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yj8kR-0003oN-7b for bug-gnu-emacs@gnu.org; Fri, 17 Apr 2015 12:04:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Yj8kM-0000L8-BC for bug-gnu-emacs@gnu.org; Fri, 17 Apr 2015 12:04:07 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:41201) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yj8kM-0000L3-95 for bug-gnu-emacs@gnu.org; Fri, 17 Apr 2015 12:04:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1Yj8kM-0003Ok-1L for bug-gnu-emacs@gnu.org; Fri, 17 Apr 2015 12:04:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Oleh Krehel Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 17 Apr 2015 16:04:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 20357 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 20357-done@debbugs.gnu.org id=D20357.142928658612937 (code D ref 20357); Fri, 17 Apr 2015 16:04:01 +0000 Original-Received: (at 20357-done) by debbugs.gnu.org; 17 Apr 2015 16:03:06 +0000 Original-Received: from localhost ([127.0.0.1]:59210 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Yj8jR-0003MZ-IF for submit@debbugs.gnu.org; Fri, 17 Apr 2015 12:03:05 -0400 Original-Received: from mail-wi0-f180.google.com ([209.85.212.180]:37316) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Yj8jP-0003Lq-GU for 20357-done@debbugs.gnu.org; Fri, 17 Apr 2015 12:03:03 -0400 Original-Received: by widdi4 with SMTP id di4so25596283wid.0 for <20357-done@debbugs.gnu.org>; Fri, 17 Apr 2015 09:02:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=byUMc27cUSQuOqEKb66eCJmbJWyetwgwi+NAHMCGqGs=; b=RXgUTZsCT1e+vxrHAIjd+thBkVxBqd1ai37XuC3HYncXKvah0Sp2ZUaYF+X+kPoO06 Gy2tcNIuLm3ty5IMDx7AQCKDUiNtN01ohRhLlWvknEmmfbT95J8IKl5lWtQrMXHbGzfa NCz1EOTPfYs+mvz4PJ6JK4JuFM2juW5AQV/eRuC30WLv4Du71YTR+dsTNFFB+yfSTbeT a22UYgMfGP69ZkIMngYllQ8s/d1JDPGWTs9uvmQYdsRJDl0dETXwqWOywZ8EZLCfwKcA ODEO1ByF8u1TdfVJHIF5ockn1zSfWyaGrs2c4uDcL3olYMDJtypNOk35v9bHh6IqsZ+n 4M4A== X-Received: by 10.194.59.4 with SMTP id v4mr7622473wjq.54.1429286577889; Fri, 17 Apr 2015 09:02:57 -0700 (PDT) Original-Received: by 10.27.215.21 with HTTP; Fri, 17 Apr 2015 09:02:57 -0700 (PDT) In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:101634 Archived-At: Hi Stefan, On Fri, Apr 17, 2015 at 4:31 PM, Stefan Monnier wrote: >> (let (deactivate-mark) >> (indent-region (region-beginning) >> (region-end))) >> Expected behavior: the mark isn't deactivated. >> Actual behavior: the mark is deactivated. > > Oops, indeed. Fixed with the patch below, > > diff --git a/lisp/indent.el b/lisp/indent.el > index 74e73a6..18c1fd4 100644 > --- a/lisp/indent.el > +++ b/lisp/indent.el > @@ -537,7 +537,7 @@ column to indent to; if it is nil, use one of the three methods above." > ;; In most cases, reindenting modifies the buffer, but it may also > ;; leave it unmodified, in which case we have to deactivate the mark > ;; by hand. > - (deactivate-mark)) > + (setq deactivate-mark t)) > > (defun indent-relative-maybe () > "Indent a new line like previous nonblank line. This is still not the correct behavior. Example code: (with-temp-buffer (insert "foobar") (set-mark (point)) (goto-char (point-min)) (indent-region (point-min) (point-max)) mark-active) In 24.5 it returns nil, which is correct. While in 25 it returns t. Oleh