From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Oleh Krehel Newsgroups: gmane.emacs.bugs Subject: bug#20365: 24.5; all-completions returns duplicates for Info-read-node-name-1 Date: Sat, 18 Apr 2015 19:49:44 +0200 Message-ID: References: <87egnhfmcd.fsf@gmail.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-Trace: ger.gmane.org 1429379434 25633 80.91.229.3 (18 Apr 2015 17:50:34 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 18 Apr 2015 17:50:34 +0000 (UTC) Cc: 20365@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Apr 18 19:50:18 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1YjWsj-0002TQ-7j for geb-bug-gnu-emacs@m.gmane.org; Sat, 18 Apr 2015 19:50:17 +0200 Original-Received: from localhost ([::1]:46437 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YjWsd-00016m-LL for geb-bug-gnu-emacs@m.gmane.org; Sat, 18 Apr 2015 13:50:11 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:36122) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YjWsZ-00012J-Iv for bug-gnu-emacs@gnu.org; Sat, 18 Apr 2015 13:50:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YjWsU-00055k-Q1 for bug-gnu-emacs@gnu.org; Sat, 18 Apr 2015 13:50:07 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:42148) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YjWsU-00055A-LK for bug-gnu-emacs@gnu.org; Sat, 18 Apr 2015 13:50:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1YjWsU-0003O3-1T for bug-gnu-emacs@gnu.org; Sat, 18 Apr 2015 13:50:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Oleh Krehel Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 18 Apr 2015 17:50:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 20365 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 20365-submit@debbugs.gnu.org id=B20365.142937939313001 (code B ref 20365); Sat, 18 Apr 2015 17:50:01 +0000 Original-Received: (at 20365) by debbugs.gnu.org; 18 Apr 2015 17:49:53 +0000 Original-Received: from localhost ([127.0.0.1]:60157 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YjWsL-0003Nd-0x for submit@debbugs.gnu.org; Sat, 18 Apr 2015 13:49:53 -0400 Original-Received: from mail-wi0-f181.google.com ([209.85.212.181]:37952) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YjWsI-0003NP-FA for 20365@debbugs.gnu.org; Sat, 18 Apr 2015 13:49:51 -0400 Original-Received: by wiun10 with SMTP id n10so50971311wiu.1 for <20365@debbugs.gnu.org>; Sat, 18 Apr 2015 10:49:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=2rPW9hjqclxhmC5o3D7KjiuxZ3MUrB159Tnnw/tk+f8=; b=iZvbow0PwTBuXSo35jOSR2aYm/riidy64ZN53sw9enayBkCPYyzrmrUEHH1mJIEOCm DY98ffnffsdJikGV8BbKmQ/40jB7wmygiuaiRyyl3tm1UMroytcarwKgmv9YUrSRHoKV oMeiuz5n9e2ulOjQgBxykar7FOtNixG+2gbPdPkEsT+1VbWK0lLH6M40gg7h0T9t/5GH 6TfUroRPJHv4XGBUfhgpgGmP35/Hd27jNDOGqCeVUdswSJWzqGZLVjakeLdSXBxV/qlO tfauyPSvVUF2c6cRRksHX16WsuKikV6ACDTOZzfbvCnZEdfCGvTp8UydsXytVVFA5QnY 3Waw== X-Received: by 10.194.161.193 with SMTP id xu1mr3991301wjb.48.1429379384756; Sat, 18 Apr 2015 10:49:44 -0700 (PDT) Original-Received: by 10.27.215.21 with HTTP; Sat, 18 Apr 2015 10:49:44 -0700 (PDT) In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:101684 Archived-At: On Sat, Apr 18, 2015 at 7:41 PM, Stefan Monnier wrote: > Just a first comment: it's not considered incorrect for > `all-completions' to return a list with duplicate entries in it. > More specifically, it's considered the completion UI's job to remove > those duplicates. > >> (setq x (all-completions "(" 'Info-read-node-name-1)) >> x will contain many duplicates for each node, like "org" "org" "org" >> "org" "org.info.gz" "org" "org.info.gz" "org" "org.info.gz". > > Maybe the way these entries are generated could be reviewed to try and > reduce the number of duplicates. And we could call `delete-dups' on the > result: while a completion-table shouldn't need to go out of its way to > reduce the number of duplicates (since the UI is supposed to handle it > anyway), it's probably good to avoid having such expected large number of > duplicates, indeed. > >> Finally, if one of the elements of `all-completions' is passed, it still >> doesn't work. > > What does "is passed" mean here? What does "doesn't work" mean here? > >> I'm guessing that it expects "(org)" instead of "org", but >> then why not offer these on the completion list? > > What is "it"? What I think is happening there is that Info calls `completing-read-function' and ultimately gives it (through all-completions) a list like '("org" "emacs"...). And then it expects the answer to be in the form "(org)" or "(emacs)". Which I think is strange. I've pushed recently this hack to `ivy-read', which makes it work for Info: ((eq collection 'Info-read-node-name-1) (if (equal Info-current-file "dir") (setq collection (mapcar (lambda (x) (format "(%s)" x)) (cl-delete-duplicates (all-completions "(" collection predicate) :test 'equal))) (setq collection (all-completions "" collection predicate)))) This is quite ugly to go to such lengths to deal with just one completion case. Oleh