From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Oleh Krehel Newsgroups: gmane.emacs.bugs Subject: bug#20365: 24.5; all-completions returns duplicates for Info-read-node-name-1 Date: Mon, 20 Apr 2015 16:52:57 +0200 Message-ID: References: <87egnhfmcd.fsf@gmail.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-Trace: ger.gmane.org 1429541660 22835 80.91.229.3 (20 Apr 2015 14:54:20 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 20 Apr 2015 14:54:20 +0000 (UTC) Cc: 20365@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Apr 20 16:54:11 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1YkD5O-0000Zt-E3 for geb-bug-gnu-emacs@m.gmane.org; Mon, 20 Apr 2015 16:54:10 +0200 Original-Received: from localhost ([::1]:54016 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YkD5N-0002mz-Gv for geb-bug-gnu-emacs@m.gmane.org; Mon, 20 Apr 2015 10:54:09 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:38948) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YkD5J-0002mj-PN for bug-gnu-emacs@gnu.org; Mon, 20 Apr 2015 10:54:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YkD5H-0006GD-1O for bug-gnu-emacs@gnu.org; Mon, 20 Apr 2015 10:54:05 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:43931) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YkD5G-0006G9-TS for bug-gnu-emacs@gnu.org; Mon, 20 Apr 2015 10:54:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1YkD5G-0006kM-Dc for bug-gnu-emacs@gnu.org; Mon, 20 Apr 2015 10:54:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Oleh Krehel Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 20 Apr 2015 14:54:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 20365 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 20365-submit@debbugs.gnu.org id=B20365.142954158625865 (code B ref 20365); Mon, 20 Apr 2015 14:54:02 +0000 Original-Received: (at 20365) by debbugs.gnu.org; 20 Apr 2015 14:53:06 +0000 Original-Received: from localhost ([127.0.0.1]:33707 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YkD4L-0006j6-Rn for submit@debbugs.gnu.org; Mon, 20 Apr 2015 10:53:06 -0400 Original-Received: from mail-wi0-f182.google.com ([209.85.212.182]:37951) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YkD4J-0006ic-HX for 20365@debbugs.gnu.org; Mon, 20 Apr 2015 10:53:04 -0400 Original-Received: by wiun10 with SMTP id n10so94801081wiu.1 for <20365@debbugs.gnu.org>; Mon, 20 Apr 2015 07:52:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=MGRn7niOn+7jIbssleQ9Bf7fZogdDDv3CbI8ZnqX6Yg=; b=0KhcBg2HiOQVHVTFe8I6dSXqn3kZ+9m0sn+ULCWXDTKUUL1ixYEet7oID7ljw4qdNK dMLDoUgd/3Nm8eu40gTzcbLUO39nsk2jcKhqVUrC6o3EcH1DNwVgj/Y926cL2oWg7Ze/ erpbQna+eQ2KzgA8Z/Eqa0eEYwOQtR2JSKe13Mr2tRKtyoFxNxjaktSm3Q7BTIthgHXX altRmXBw5sqC/SBih1dw9xABczYdPo0tXhxh+J1eCzLlxVFep1GYEpDDpDYIQU3kA4gv lvcajxi/SNSRwaC6TeNNXQ68QcGvoiw87pUYbU/q0AjXxI4Bt2Rsk2Vcx+v5Eq7RH6n/ 42HA== X-Received: by 10.194.59.4 with SMTP id v4mr32362920wjq.54.1429541577693; Mon, 20 Apr 2015 07:52:57 -0700 (PDT) Original-Received: by 10.27.215.21 with HTTP; Mon, 20 Apr 2015 07:52:57 -0700 (PDT) In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:101759 Archived-At: On Mon, Apr 20, 2015 at 4:38 PM, Stefan Monnier wrote: >> nodes. This concept can be adapted to all compltetion types with >> "infinite" candidates. And there would be zero confusion: >> `all-completions' would immediately return a list of strings, some of >> them terminal nodes, some of them "directories". Then it only remains >> to provide a generic `file-directory-p' and we're done. > > Yes, that's also what I was thinking. Basically, if all-completions > returns something which requires further input, then this something > should include the "terminating char" which makes completion-boundaries > change (which is how to detect that your candidate list is out-of-date > because the input has "moved to another directory"). I'm not fully familiar with the concept of completion-boundaries, but I have a feeling that I won't like it, specifically the multiple callback passes for a response to a single completion input change. Is the concept of completion-boundaries irreplaceable, could it maybe be replaced by a notion of navigating a tree (just like navigating a file system, with terminal and non-terminal nodes). Which Emacs features use the completion-boundaries concept? >>> That's the case currently. The completion-table is called and the >>> caller is the UI, and currently it's the UI's responsibility to remove >>> the duplicates. >> So Info returning duplicates is a bug that should be fixed? > > Our UI already does remove duplicates (not in info.el, of course, since > our UI is in minibuffer.el). I've added a fix to Info in any case. Can you please look at it in the fix-info-dups branch? >>>> Here's my line of thought: a completion function is expected to have >>>> an O(N) complexity, where N is the amount of candidates. Removing >>>> duplicates is O(N^2) at worst, and O(NlogN) at best. >>> Actually, with a hash-table it's pretty much down to O(N). >> Yeah, but we're not using that. > > Not sure who's "we", here. But the point is that if the performance of > delete-dups becomes a problem, it can be improved. We are the happy Emacs users. >> And having no assumptions on the data, the hashing function would be >> the most basic one. > > I don't think that should make much difference: (make-hash-table :test #'equal) > should work just fine. OK, that's good to keep in mind. But even better is to avoid placing the overhead on the UI, be it minibuffer.el or ivy.el or whatever. Oleh