* bug#30588: 26.0.90; Documentation error in docstring of `input-method-function'
@ 2018-02-23 20:43 Adam Tack
2018-02-24 9:31 ` Eli Zaretskii
0 siblings, 1 reply; 2+ messages in thread
From: Adam Tack @ 2018-02-23 20:43 UTC (permalink / raw)
To: 30588
The listed range of "printing characters" appears to be out of date.
Currently the docstring of `input-method-function'
(src/keyboard.c:11739
http://git.savannah.gnu.org/cgit/emacs.git/tree/src/keyboard.c?id=15863145cb8468b18b620d9dd82f90eaf4775d25#n11736
)
says that:
It’s called with one argument, a printing character that was just read.
(That means a character with code 040...0176.)
As can be seen at src/keyboard.c:2977 (with context:
http://git.savannah.gnu.org/cgit/emacs.git/tree/src/keyboard.c?id=15863145cb8468b18b620d9dd82f90eaf4775d25#n2969
) this is no longer the case (since
8d76911517ef7cefc7939845e920145ef89282f7) — the character can also be
in the range 0200...0377, so the docstring should probably say:
It’s called with one argument, a printing character that was just read.
(That means a character with code 040...0176 or 0200...0377.)
Thanks!
Adam
^ permalink raw reply [flat|nested] 2+ messages in thread
* bug#30588: 26.0.90; Documentation error in docstring of `input-method-function'
2018-02-23 20:43 bug#30588: 26.0.90; Documentation error in docstring of `input-method-function' Adam Tack
@ 2018-02-24 9:31 ` Eli Zaretskii
0 siblings, 0 replies; 2+ messages in thread
From: Eli Zaretskii @ 2018-02-24 9:31 UTC (permalink / raw)
To: Adam Tack; +Cc: 30588-done
> From: Adam Tack <adam.tack.513@gmail.com>
> Date: Fri, 23 Feb 2018 20:43:43 +0000
>
> The listed range of "printing characters" appears to be out of date.
>
> Currently the docstring of `input-method-function'
>
> (src/keyboard.c:11739
> http://git.savannah.gnu.org/cgit/emacs.git/tree/src/keyboard.c?id=15863145cb8468b18b620d9dd82f90eaf4775d25#n11736
> )
>
> says that:
>
> It’s called with one argument, a printing character that was just read.
> (That means a character with code 040...0176.)
>
> As can be seen at src/keyboard.c:2977 (with context:
> http://git.savannah.gnu.org/cgit/emacs.git/tree/src/keyboard.c?id=15863145cb8468b18b620d9dd82f90eaf4775d25#n2969
> ) this is no longer the case (since
> 8d76911517ef7cefc7939845e920145ef89282f7) — the character can also be
> in the range 0200...0377, so the docstring should probably say:
>
> It’s called with one argument, a printing character that was just read.
> (That means a character with code 040...0176 or 0200...0377.)
Thanks, fixed.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-02-24 9:31 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-02-23 20:43 bug#30588: 26.0.90; Documentation error in docstring of `input-method-function' Adam Tack
2018-02-24 9:31 ` Eli Zaretskii
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).