From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Martin Trojer Newsgroups: gmane.emacs.bugs Subject: bug#17497: The text-mode menu looks very broken in emacs-24 Date: Wed, 18 Mar 2015 16:51:48 +0000 Message-ID: References: <5374B271.50803@yandex.ru> <83a8zaxnrx.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary=f46d0444e8ed2f9992051192e621 X-Trace: ger.gmane.org 1426697548 9501 80.91.229.3 (18 Mar 2015 16:52:28 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 18 Mar 2015 16:52:28 +0000 (UTC) To: 17497@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Mar 18 17:52:19 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1YYHCW-0004ZL-IQ for geb-bug-gnu-emacs@m.gmane.org; Wed, 18 Mar 2015 17:52:12 +0100 Original-Received: from localhost ([::1]:34827 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YYHCV-0004CD-RN for geb-bug-gnu-emacs@m.gmane.org; Wed, 18 Mar 2015 12:52:11 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:35254) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YYHCS-0004BS-1V for bug-gnu-emacs@gnu.org; Wed, 18 Mar 2015 12:52:09 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YYHCM-0001bO-TH for bug-gnu-emacs@gnu.org; Wed, 18 Mar 2015 12:52:07 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:53266) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YYHCM-0001bG-Py for bug-gnu-emacs@gnu.org; Wed, 18 Mar 2015 12:52:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1YYHCM-0006hi-EA for bug-gnu-emacs@gnu.org; Wed, 18 Mar 2015 12:52:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Martin Trojer Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 18 Mar 2015 16:52:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 17497 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 17497-submit@debbugs.gnu.org id=B17497.142669751425756 (code B ref 17497); Wed, 18 Mar 2015 16:52:02 +0000 Original-Received: (at 17497) by debbugs.gnu.org; 18 Mar 2015 16:51:54 +0000 Original-Received: from localhost ([127.0.0.1]:51834 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YYHCE-0006hL-07 for submit@debbugs.gnu.org; Wed, 18 Mar 2015 12:51:54 -0400 Original-Received: from mail-wi0-f176.google.com ([209.85.212.176]:34930) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YYHC9-0006h9-4U for 17497@debbugs.gnu.org; Wed, 18 Mar 2015 12:51:53 -0400 Original-Received: by wibdy8 with SMTP id dy8so95448808wib.0 for <17497@debbugs.gnu.org>; Wed, 18 Mar 2015 09:51:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type; bh=9J06YBoqeUs3TWMUWhQBttRrbhT+0JXOyam8XF+yY3A=; b=egX/4N1Stba6f1wgDj33RuFHIseFRrrNkHXlPhqpDORtSzH/5iJPzjJsU3OnBjjaNA x44e5JMUPKP9f0hXD1f6IjYWQbWU07hP6YB3rK5HxUAUBi670ptFmNVPUb57a+DmQiL6 zEYgG32GlerKD4yhWSkGmRsike1dljkkLhukXrn4uorqwhTJR1JqMUmsk1ODAgwRFRxO 0/sI4h3hzkEs0/rsEjw2wcOJHIyDwqBul162QBKc6QWFVwKfXlvG+7WCah3xGUVzngon G3NzcwEGxpb74D+Eh1nuGHBEo7jy+LeB4cJLCtDMP2ec5uFF6ywy+2mqfgj8fbmMZ7aO l4MQ== X-Received: by 10.180.102.73 with SMTP id fm9mr8835581wib.12.1426697508328; Wed, 18 Mar 2015 09:51:48 -0700 (PDT) Original-Received: by 10.27.1.85 with HTTP; Wed, 18 Mar 2015 09:51:48 -0700 (PDT) In-Reply-To: <83a8zaxnrx.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:100620 Archived-At: --f46d0444e8ed2f9992051192e621 Content-Type: text/plain; charset=UTF-8 Hello, I believe that snippet of code was from you :) I simply put that quoted snipped in the cmgoto function as per your instructions. I'm sure this isn't the 'right thing to do' since it completely bypasses the switch statement that tries to do the cheapest cursor move. For what I can tell from the long discussion this is very hairy bug to observe and debug. But for some reason that I don't fully understand this patch solves my re-draw issues. Also, if you are interested in solving this issue properly, running emacs inside a VM (in this case Virtualbox) seems to make re-draw issues a lot more likely and thus perhaps easier to diagnose. Cheers... On Wed, Mar 18, 2015 at 4:40 PM, Eli Zaretskii wrote: > > Date: Wed, 18 Mar 2015 11:45:17 +0000 > > From: Martin Trojer > > > > > I don't think it's memory corruption. I suspect the problem is > > > related to the different ways cmgoto chooses to get to the specified > > > screen coordinates. If someone on the affected systems could tweak > > > cmgoto such that only the direct move is used, i.e. this code: > > > > > > p = (dcm == tty->Wcm->cm_habs > > > ? tgoto (dcm, row, col) > > > : tgoto (dcm, col, row)); > > > emacs_tputs (tty, p, 1, cmputc); > > > curY (tty) = row, curX (tty) = col; > > > > > > then perhaps we could see if my suspicions are in the right direction. > > > > Hi Eli, > > I just applied this patch trying to solve a different but related issue ( > https://www.virtualbox.org/ticket/13687). > > I am happy to report that applying this patch completely solved the > redrawing issues I was experiencing! > > You don't quote the person who wrote the above, so I need to ask you > who wrote the code. We need to know to whom to attribute it. > > Also, I'd be happier if someone could explain why this is the the > right thing to do in that place. > > Thanks. > --f46d0444e8ed2f9992051192e621 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Hello,

I believe that snip= pet of code was from you :) I simply put that quoted snipped in the cmgoto = function as per your instructions. I'm sure this isn't the 'rig= ht thing to do' since it completely bypasses the switch statement that = tries to do the cheapest cursor move.=C2=A0

For what I can tell from the lo= ng discussion this is very hairy bug to observe and debug. But for some rea= son that I don't fully understand this patch solves my re-draw issues.<= /div>

= Also, if you are interested in solving this issue properly, running emacs i= nside a VM (in this case Virtualbox) seems to make re-draw issues a lot mor= e likely and thus perhaps easier to diagnose.

Cheers...

On Wed, Mar 18, 2015 at 4= :40 PM, Eli Zaretskii <eliz@gnu.org> wrote:
> Date: Wed, 18 Mar 2015 11:45:17 +0000
> From: Martin Trojer <mar= tin.trojer@gmail.com>
>
> > I don't think it's memory corruption.=C2=A0 I suspect the= problem is
> > related to the different ways cmgoto chooses to get to the specif= ied
> > screen coordinates.=C2=A0 If someone on the affected systems coul= d tweak
> > cmgoto such that only the direct move is used, i.e. this code: > >
> >=C2=A0 =C2=A0 =C2=A0 p =3D (dcm =3D=3D tty->Wcm->cm_habs
> >=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0? tgoto (dcm, row, col) > >=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0: tgoto (dcm, col, row));=
> >=C2=A0 =C2=A0 =C2=A0 emacs_tputs (tty, p, 1, cmputc);
> >=C2=A0 =C2=A0 =C2=A0 curY (tty) =3D row, curX (tty) =3D col;
> >
> > then perhaps we could see if my suspicions are in the right direc= tion.
>
> Hi Eli,
> I just applied this patch trying to solve a different but related issu= e (ht= tps://www.virtualbox.org/ticket/13687).
> I am happy to report that applying this patch completely solved the re= drawing issues I was experiencing!

You don't quote the person who wrote the above, so I need to ask you who wrote the code.=C2=A0 We need to know to whom to attribute it.

Also, I'd be happier if someone could explain why this is the the
right thing to do in that place.

Thanks.

--f46d0444e8ed2f9992051192e621--