From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Michael Gallagher - NOAA Affiliate via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#50506: 28.0.50; display-line-numbers equivalent for linum-format? Date: Wed, 15 Sep 2021 09:22:18 -0600 Message-ID: References: <87czpgc1yb.fsf@noaa.gov> <83fsucipdz.fsf@gnu.org> <87tuirnwu0.fsf@gnus.org> <83sfy8cpvz.fsf@gnu.org> <83pmtccovd.fsf@gnu.org> <834kancb73.fsf@gnu.org> Reply-To: Michael Gallagher - NOAA Affiliate Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="000000000000acde5d05cc0a4503" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="4749"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 50506@debbugs.gnu.org, Lars Ingebrigtsen To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Sep 15 17:24:28 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mQWlw-00010W-NK for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 15 Sep 2021 17:24:28 +0200 Original-Received: from localhost ([::1]:47286 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mQWlv-0004MX-MH for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 15 Sep 2021 11:24:27 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:42672) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mQWlW-0004MP-82 for bug-gnu-emacs@gnu.org; Wed, 15 Sep 2021 11:24:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:41368) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mQWlW-00066D-0N for bug-gnu-emacs@gnu.org; Wed, 15 Sep 2021 11:24:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mQWlV-0001IK-R2 for bug-gnu-emacs@gnu.org; Wed, 15 Sep 2021 11:24:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Michael Gallagher - NOAA Affiliate Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 15 Sep 2021 15:24:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50506 X-GNU-PR-Package: emacs Original-Received: via spool by 50506-submit@debbugs.gnu.org id=B50506.16317193834910 (code B ref 50506); Wed, 15 Sep 2021 15:24:01 +0000 Original-Received: (at 50506) by debbugs.gnu.org; 15 Sep 2021 15:23:03 +0000 Original-Received: from localhost ([127.0.0.1]:52914 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mQWkY-0001H7-Oz for submit@debbugs.gnu.org; Wed, 15 Sep 2021 11:23:03 -0400 Original-Received: from mail-pl1-f171.google.com ([209.85.214.171]:42734) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mQWkW-0001GQ-6G for 50506@debbugs.gnu.org; Wed, 15 Sep 2021 11:23:01 -0400 Original-Received: by mail-pl1-f171.google.com with SMTP id n4so1825702plh.9 for <50506@debbugs.gnu.org>; Wed, 15 Sep 2021 08:23:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=noaa.gov; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=CcLWcsq6oXgHOK2T1sm7cFkGLmySXUrDEs740TGwrkg=; b=Mr+0rVdK58e0fIzg6drFWRF2FcNzgZZUIvfMGTSuXCqpISBDZCjDfyN5hLmJUzDLfB sNIZ/x9Eu4vhPQ6/ZW8Jfv/lG6+CdAapo2SNeO3IguFUSPtEi8B2eN4Gk/A/w7AZysmC /oMZP6FvOmIeDprQO0mtU/aDHtoA6t8jvcURn6sgYDfgXy6A5/HNT0X3iFGR5aIecTvS m8K70yX37/55TUZGKFUcQCQe8ocKhRLRShNWy5wzgCiRww2AfYyEwKYdH4pRWHIpaJAy el6xdWM25UT0Q3fvWHOOz4SD2kYPKbfQq4I7xyEXEXBF9fm8uL2YnxW6ClaS+D25LJsu wVhw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=CcLWcsq6oXgHOK2T1sm7cFkGLmySXUrDEs740TGwrkg=; b=QSYIVheu6a8qpxHMsxJOwTHpw9X+oJrzX8KdD+Qyyp0sL8t/9u/xgcQc1XbWDENTF+ Ml+E45mJGPCMi+vkFneQgZIbv11i9Kgd+75nNxo1FPdgh9XzEe24q9fckhsPGX3tDJ/X rrBhkE26zQQd9UiEXYGC81RX7e+O+qt8cVEUaeNcqSK0q2bx3mS7oULEZKUDaUOFTA/N iRORicVSRhGjOamSJ9H2fxsFotwYDHFizHH6u5yu96kaiAaMBi8dVsrE8+krVrINpvLt law4iWOpuffsRhqFtkbl3GVDtZ2MaPQ+Nvj71yJo7/5AEfizzvG6NuYMTwBardY437wL QH3w== X-Gm-Message-State: AOAM533asJtdMbCACrzVhMTNBfrxaGOAcklWYJE59pGtMgZeTGQbgPz2 6nFKuA3S8j/irXyzdeYpIW6eSzX8+yCuVrrrOBIQIw== X-Google-Smtp-Source: ABdhPJx17vSjsPuALdDZRxSc4V8iUIE4YZLTJPRu2663i/2A8wWLfSr8Lqa6CTZpEgqce7swxYdrxiGb+7EuRRfI8Wk= X-Received: by 2002:a17:902:b789:b0:13b:90bc:f184 with SMTP id e9-20020a170902b78900b0013b90bcf184mr225029pls.31.1631719374220; Wed, 15 Sep 2021 08:22:54 -0700 (PDT) In-Reply-To: <834kancb73.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:214402 Archived-At: --000000000000acde5d05cc0a4503 Content-Type: multipart/alternative; boundary="000000000000acde5b05cc0a4501" --000000000000acde5b05cc0a4501 Content-Type: text/plain; charset="UTF-8" Eli, I did indeed. I've added corrections to account for L2R vs R2L and the updated patch is attached. Let me know what you think On Tue, Sep 14, 2021 at 11:35 AM Eli Zaretskii wrote: > > From: Michael Gallagher - NOAA Affiliate > > Date: Tue, 14 Sep 2021 10:17:31 -0600 > > Cc: Lars Ingebrigtsen , 50506@debbugs.gnu.org > > > > OK. Here we go. I found some time last night. Attached is a git patch > file for changes that implement this > > feature request as well as (GNU) diffs for the individual files in > question. It's a pretty simple commit. It's worth > > noting that I'm probably overlooking something in how I create the > glyph, I definitely don't understand the > > nuances of the display code. But I hope it's helpful. > > Thanks. But I don't see that you did anything about the problem with > R2L lines. What happens if you turn on display-line-numbers-mode in > the buffer that visits TUTORIAL.he, and then turn on this feature in > that buffer? don't you see the separator line on the wrong side of the > line numbers? > -- Michael Gallagher, PhD CIRES Research Scientist Polar Observations and Processes Team (ESRL/NOAA/PSD) 325 Broadway, Boulder, Colorado 80305 --000000000000acde5b05cc0a4501 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Eli, I did indeed. I've added corrections to account f= or L2R vs R2L and the updated patch is attached. Let me know what you think=

On Tue, Sep 14, 2021 at 11:35 AM Eli Zaretskii <eliz@gnu.org> wrote:
> From: Michael Gallagher - NOAA Affiliate <<= a href=3D"mailto:michael.r.gallagher@noaa.gov" target=3D"_blank">michael.r.= gallagher@noaa.gov>
> Date: Tue, 14 Sep 2021 10:17:31 -0600
> Cc: Lars Ingebrigtsen <larsi@gnus.org>, 50506@debbugs.gnu.org
>
> OK. Here we go. I found some time last night. Attached is a git patch = file for changes that implement this
> feature request as well as (GNU) diffs for the individual files in que= stion. It's a pretty simple commit. It's worth
> noting that I'm probably overlooking something in how I create the= glyph, I definitely don't understand the
> nuances of the display code. But I hope it's helpful.

Thanks.=C2=A0 But I don't see that you did anything about the problem w= ith
R2L lines.=C2=A0 What happens if you turn on display-line-numbers-mode in the buffer that visits TUTORIAL.he, and then turn on this feature in
that buffer? don't you see the separator line on the wrong side of the<= br> line numbers?


--
Michael Gallagher, PhD
CIRES Research Scientist
<= /div>
Polar Obser= vations and Processes Team (ESRL/NOAA/PSD)
325 Broadway, Boulder, Colorado 80305
--000000000000acde5b05cc0a4501-- --000000000000acde5d05cc0a4503 Content-Type: text/x-patch; charset="UTF-8"; name="0021-inclusion-of-line-number-separator-character.patch" Content-Disposition: attachment; filename="0021-inclusion-of-line-number-separator-character.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_ktlnjk1p0 RnJvbSA1NTBkMjcxNmZlYjc4Y2Y2MzUzZThkOWE4ZjYzYjdmZDEyYWRmZDgzIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBwb2xhaXIgPG1pY2hhZWwuci5nYWxsYWdoZXJAbm9hYS5nb3Y+ CkRhdGU6IFdlZCwgMTUgU2VwIDIwMjEgMDk6MTg6NTggLTA2MDAKU3ViamVjdDogW1BBVENIIDIx LzIxXSBpbmNsdXNpb24gb2YgbGluZSBudW1iZXIgc2VwYXJhdG9yIGNoYXJhY3RlcgoKLS0tCiBs aXNwL2N1cy1zdGFydC5lbCB8ICA2ICsrKysrKwogbGlzcC9mcmFtZS5lbCAgICAgfCAgMSArCiBz cmMveGRpc3AuYyAgICAgICB8IDI0ICsrKysrKysrKysrKysrKysrKysrKysrKwogMyBmaWxlcyBj aGFuZ2VkLCAzMSBpbnNlcnRpb25zKCspCgpkaWZmIC0tZ2l0IGEvbGlzcC9jdXMtc3RhcnQuZWwg Yi9saXNwL2N1cy1zdGFydC5lbAppbmRleCAxYTNlNTY4MmJiYS4uYzc1NWFhYTQxY2YgMTAwNjQ0 Ci0tLSBhL2xpc3AvY3VzLXN0YXJ0LmVsCisrKyBiL2xpc3AvY3VzLXN0YXJ0LmVsCkBAIC03NDAs NiArNzQwLDEyIEBAIG1pbmlidWZmZXItcHJvbXB0LXByb3BlcnRpZXMtLXNldHRlcgogICAgICAg ICAgICAgICAgKGNvbnN0IDp0YWcgIlZpc3VhbGx5IHJlbGF0aXZlIGxpbmUgbnVtYmVycyIKICAg ICAgICAgICAgICAgICAgICAgICA6dmFsdWUgdmlzdWFsKSkKICAgICAgICAgICAgICAgIjI2LjEi KQorICAgICAgICAgICAgIChkaXNwbGF5LWxpbmUtbnVtYmVycy1zZXBhcmF0b3ItY2hhcmFjdGVy CisgICAgICAgICAgICAgIGRpc3BsYXktbGluZS1udW1iZXJzCisgICAgICAgICAgICAgIChjaGFy YWN0ZXIgOnRhZyAiQ2hhcmFjdGVyIHRvIHNlcGFyYXRlIG51bWJlcnMgZnJvbSBidWZmZXIiKQor ICAgICAgICAgICAgICA6c2FmZSAobGFtYmRhICh2YWx1ZSkgKG9yIChjaGFyYWN0ZXJwIHZhbHVl KSAobnVsbCB2YWx1ZSkpKQorICAgICAgICAgICAgICAiMjguMDUiKQorICAgICAgICAgICAgICA7 OnNhZmUgKGxhbWJkYSAodmFsdWUpIChvciAoY2hhcmFjdGVycCB2YWx1ZSkgKG51bGwgdmFsdWUp KSkpCiAgICAgICAgICAgICAgKGRpc3BsYXktbGluZS1udW1iZXJzLXdpZHRoCiAgICAgICAgICAg ICAgIGRpc3BsYXktbGluZS1udW1iZXJzCiAgICAgICAgICAgICAgIChjaG9pY2UKZGlmZiAtLWdp dCBhL2xpc3AvZnJhbWUuZWwgYi9saXNwL2ZyYW1lLmVsCmluZGV4IDYwMjM0ZmMyYWU5Li5jNjk3 NWE3MWNmMiAxMDA2NDQKLS0tIGEvbGlzcC9mcmFtZS5lbAorKysgYi9saXNwL2ZyYW1lLmVsCkBA IC0yODc2LDYgKzI4NzYsNyBAQCBzZXQtZnJhbWUtcHJvcGVydHktLWludGVyYWN0aXZlCiAgICAg ICAgIGhlYWRlci1saW5lLWZvcm1hdAogICAgICAgICB0YWItbGluZS1mb3JtYXQKICAgICAgICAg ZGlzcGxheS1saW5lLW51bWJlcnMKKyAgICAgICAgZGlzcGxheS1saW5lLW51bWJlcnMtc2VwYXJh dG9yLWNoYXJhY3RlcgogICAgICAgICBkaXNwbGF5LWxpbmUtbnVtYmVycy13aWR0aAogICAgICAg ICBkaXNwbGF5LWxpbmUtbnVtYmVycy1jdXJyZW50LWFic29sdXRlCiAgICAgICAgIGRpc3BsYXkt bGluZS1udW1iZXJzLXdpZGVuCmRpZmYgLS1naXQgYS9zcmMveGRpc3AuYyBiL3NyYy94ZGlzcC5j CmluZGV4IGQzMGE2ODU3MGYwLi4zMmZjNjA4OTI5MiAxMDA2NDQKLS0tIGEvc3JjL3hkaXNwLmMK KysrIGIvc3JjL3hkaXNwLmMKQEAgLTIzMjY1LDYgKzIzMjY1LDE0IEBAIG1heWJlX3Byb2R1Y2Vf bGluZV9udW1iZXIgKHN0cnVjdCBpdCAqaXQpCiAJdGVtX2l0LmZhY2VfaWQgPSBtZXJnZV9mYWNl cyAoaXQtPncsIFFsaW5lX251bWJlcl9taW5vcl90aWNrLAogCQkJCSAgICAgIDAsIERFRkFVTFRf RkFDRV9JRCk7CiAgICAgfQorICBpZiAoRklYTkFUUCAoVmRpc3BsYXlfbGluZV9udW1iZXJzX3Nl cGFyYXRvcl9jaGFyYWN0ZXIpCisgICAgICAmJiBpdC0+cGFyYWdyYXBoX2VtYmVkZGluZyAhPSBM MlIpCisgICAgeworICAgICAgdGVtX2l0LmMgPSB0ZW1faXQuY2hhcl90b19kaXNwbGF5ID0gWEZJ WE5BVCAoVmRpc3BsYXlfbGluZV9udW1iZXJzX3NlcGFyYXRvcl9jaGFyYWN0ZXIpOworICAgICAg dGVtX2l0LmxlbiA9IDE7CisgICAgICBTRVRfVEVYVF9QT1MgKHRlbV9pdC5wb3NpdGlvbiwgLTEs IC0xKTsKKyAgICAgIFBST0RVQ0VfR0xZUEhTICgmdGVtX2l0KTsKKyAgICB9CiAKICAgLyogUHJv ZHVjZSBnbHlwaHMgZm9yIHRoZSBsaW5lIG51bWJlciBpbiBhIHNjcmF0Y2ggZ2x5cGhfcm93LiAg Ki8KICAgZm9yIChjb25zdCBjaGFyICpwID0gbG51bV9idWY7ICpwOyBwKyspCkBAIC0yMzI5Niw2 ICsyMzMwNCwxNSBAQCBtYXliZV9wcm9kdWNlX2xpbmVfbnVtYmVyIChzdHJ1Y3QgaXQgKml0KQog CX0KICAgICB9CiAKKyAgaWYgKEZJWE5BVFAgKFZkaXNwbGF5X2xpbmVfbnVtYmVyc19zZXBhcmF0 b3JfY2hhcmFjdGVyKQorICAgICAgJiYgaXQtPnBhcmFncmFwaF9lbWJlZGRpbmcgPT0gTDJSKQor ICAgIHsKKyAgICAgIHRlbV9pdC5jID0gdGVtX2l0LmNoYXJfdG9fZGlzcGxheSA9IFhGSVhOQVQg KFZkaXNwbGF5X2xpbmVfbnVtYmVyc19zZXBhcmF0b3JfY2hhcmFjdGVyKTsKKyAgICAgIHRlbV9p dC5sZW4gPSAxOworICAgICAgU0VUX1RFWFRfUE9TICh0ZW1faXQucG9zaXRpb24sIC0xLCAtMSk7 CisgICAgICBQUk9EVUNFX0dMWVBIUyAoJnRlbV9pdCk7CisgICAgfQorCiAgIGluaGliaXRfZnJl ZV9yZWFsaXplZF9mYWNlcyA9IHNhdmVfZnJlZV9yZWFsaXplZF9mYWNlczsKIAogICAvKiBSZWNv cmQgdGhlIHdpZHRoIGluIHBpeGVscyB3ZSBuZWVkIGZvciB0aGUgbGluZSBudW1iZXIgZGlzcGxh eS4gICovCkBAIC0zNTUwOSw2ICszNTUyNiwxMyBAQCBzeW1zX29mX3hkaXNwICh2b2lkKQogICBE RUZTWU0gKFFyZWxhdGl2ZSwgInJlbGF0aXZlIik7CiAgIERFRlNZTSAoUXZpc3VhbCwgInZpc3Vh bCIpOwogCisgIERFRlZBUl9MSVNQICgiZGlzcGxheS1saW5lLW51bWJlcnMtc2VwYXJhdG9yLWNo YXJhY3RlciIsIFZkaXNwbGF5X2xpbmVfbnVtYmVyc19zZXBhcmF0b3JfY2hhcmFjdGVyLAorICAg IGRvYzogLyogQ2hhcmFjdGVyIHRvIGRyYXcgYmV0d2VlbiBsaW5lIG51bWJlcnMgYW5kIGJ1ZmZl ciB3aGVuIG5vbi1uaWwuIFNvbWUgaW50ZXJlc3RpbmcKK29wdGlvbnMgYXJlOiDilJwsIOKVniwg 4pSCLCDilIMsIOKVkSwg4pa2LCDip70sIGFuZCDin6sgKi8pOworICBWZGlzcGxheV9saW5lX251 bWJlcnNfc2VwYXJhdG9yX2NoYXJhY3RlciA9IFFuaWw7CisgIERFRlNZTSAoUWRpc3BsYXlfbGlu ZV9udW1iZXJzX3NlcGFyYXRvcl9jaGFyYWN0ZXIsICJkaXNwbGF5LWxpbmUtbnVtYmVycy1zZXBh cmF0b3ItY2hhcmFjdGVyIik7CisgIC8vRm1ha2VfdmFyaWFibGVfYnVmZmVyX2xvY2FsIChRZGlz cGxheV9saW5lX251bWJlcnNfc2VwYXJhdG9yX2NoYXJhY3Rlcik7CisKICAgREVGVkFSX0xJU1Ag KCJkaXNwbGF5LWxpbmUtbnVtYmVycy13aWR0aCIsIFZkaXNwbGF5X2xpbmVfbnVtYmVyc193aWR0 aCwKICAgICBkb2M6IC8qIE1pbmltdW0gd2lkdGggb2Ygc3BhY2UgcmVzZXJ2ZWQgZm9yIGxpbmUg bnVtYmVyIGRpc3BsYXkuCiBBIHBvc2l0aXZlIG51bWJlciBtZWFucyByZXNlcnZlIHRoYXQgbWFu eSBjb2x1bW5zIGZvciBsaW5lIG51bWJlcnMsCi0tIAoyLjMzLjAKCg== --000000000000acde5d05cc0a4503--