unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: 张云峰 <zhangyunfeng0101@gmail.com>
To: martin rudalics <rudalics@gmx.at>
Cc: 60163@debbugs.gnu.org
Subject: bug#60163: 29.0.60; Error in post-command-hook (winner-save-old-configurations): (wrong-type-argument frame-live-p #<dead frame code action 0x563ea51cbf70>)
Date: Thu, 22 Dec 2022 10:34:36 +0800	[thread overview]
Message-ID: <CA+cG9GwGYj4yNEoPu1iobmFvkcU1QcJDbD4My2u5qzt05otBrA@mail.gmail.com> (raw)
In-Reply-To: <34dfc125-25b2-d84c-356d-dedaabdced85@gmx.at>

[-- Attachment #1: Type: text/plain, Size: 1099 bytes --]

Hello, I tested your patch just now, unfortunately, it doesn't work。

martin rudalics <rudalics@gmx.at> 于2022年12月22日周四 01:06写道:

>  > echo "Please make sure 'clangd' has installed!"
>
> Sorry, but I don't have clangd installed either.
>
> But let's try one thing first: IIUC 'winner-save-old-configurations' can
> fail in the indicated way only if it tries to insert a dead frame.  So
> please try with the following trivial patch:
>
> diff --git a/lisp/winner.el b/lisp/winner.el
> index c8354b18be..9fd86ae23f 100644
> --- a/lisp/winner.el
> +++ b/lisp/winner.el
> @@ -178,7 +178,8 @@ winner-save-old-configurations
>         (setq winner-last-frames nil)
>         (setq winner-last-command this-command))
>       (dolist (frame winner-modified-list)
> -      (winner-insert-if-new frame))
> +      (when (frame-live-p frame)
> +        (winner-insert-if-new frame)))
>       (setq winner-modified-list nil)
>       (winner-remember)))
>
>
> I doubt it will help much but at least we can exclude one possible
> source of troubles.
>
> martin
>

[-- Attachment #2: Type: text/html, Size: 1497 bytes --]

  reply	other threads:[~2022-12-22  2:34 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-17 14:35 bug#60163: 29.0.60; Error in post-command-hook (winner-save-old-configurations): (wrong-type-argument frame-live-p #<dead frame code action 0x563ea51cbf70>) 张云峰
2022-12-17 17:54 ` Eli Zaretskii
     [not found]   ` <CA+cG9Gw0CJNsfWViAbU8Zoooo4OJhynhD5k4y0dy_J=Uuu-F-Q@mail.gmail.com>
2022-12-19 12:15     ` Eli Zaretskii
2022-12-19 12:54       ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-12-19 12:58       ` Eli Zaretskii
2022-12-19 13:32         ` 张云峰
2022-12-19 14:28           ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-12-19 15:49             ` 张云峰
2022-12-20  1:40               ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-12-20  2:25                 ` 张云峰
2022-12-19 16:11             ` 张云峰
2022-12-19 14:12         ` 张云峰
2022-12-20  8:12 ` martin rudalics
     [not found]   ` <CA+cG9GwuyL+UxC_L5aRC+MJLFzLMrhYDzOVE8SmJzRrHTmB0NQ@mail.gmail.com>
2022-12-21  9:22     ` martin rudalics
2022-12-21 14:50       ` 张云峰
2022-12-21 17:06         ` martin rudalics
2022-12-22  2:34           ` 张云峰 [this message]
2022-12-22 10:15           ` martin rudalics
2023-06-07  1:34             ` Michael Heerdegen
2023-09-11 18:10               ` Stefan Kangas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CA+cG9GwGYj4yNEoPu1iobmFvkcU1QcJDbD4My2u5qzt05otBrA@mail.gmail.com \
    --to=zhangyunfeng0101@gmail.com \
    --cc=60163@debbugs.gnu.org \
    --cc=rudalics@gmx.at \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).