unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Vibhav Pant <vibhavp@gmail.com>
To: ikumi@ikumi.que.jp
Cc: schwab@suse.de, 31718@debbugs.gnu.org,
	robert-emacs@cochranmail.com, npostavs@gmail.com
Subject: bug#31718: 26.1; Strange behavior of `cond'
Date: Wed, 13 Jun 2018 11:56:52 +0530	[thread overview]
Message-ID: <CA+T2Sh39fHzP0D-XeY5LqCSnaE-eHVD957ZahQ5VaQH1miMkgA@mail.gmail.com> (raw)
In-Reply-To: <20110.1528869083@localhost>

Hi,

Sorry for the late reply, this entire thread was somehow going into my
spam folder, and I didn't notice it until today.

The patch looks good to go, adding a doc-string for parameter
DEFAULT-SYM should be sufficient.

Thanks,
Vibhav

On Wed, Jun 13, 2018 at 11:21 AM Ikumi Keita <ikumi@ikumi.que.jp> wrote:
>
> Hi Noam and Robert,
>
> >>>>> Noam Postavsky <npostavs@gmail.com> writes:
>
> > Anyway, the patch looks good, I think it should go to emacs-26 as it's
> > solving a pretty important regression.
>
> That's a good news, thanks.
>
> > I will push there in a couple of days, assuming no objections.
>
> As a minor issue, I suppose the doc string of
> `byte-compile-cond-jump-table-info' should include mention about a new
> argument `default-sym'.
>
> Regards,
> Ikumi Keita



-- 
Vibhav Pant
vibhavp@gmail.com





  reply	other threads:[~2018-06-13  6:26 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-05  6:26 bug#31718: 26.1; Strange behavior of `cond' Ikumi Keita
2018-06-05  8:07 ` Andreas Schwab
2018-06-06  5:41   ` Ikumi Keita
2018-06-06  7:41     ` Robert Cochran
2018-06-06  9:14       ` Ikumi Keita
2018-06-12  1:34         ` Robert Cochran
2018-06-12 22:22           ` Noam Postavsky
2018-06-13  5:51             ` Ikumi Keita
2018-06-13  6:26               ` Vibhav Pant [this message]
2018-06-16 15:10 ` Paul Eggert
2018-06-16 15:20   ` Eli Zaretskii
2018-06-16 15:28     ` Paul Eggert
2018-06-16 16:02       ` Eli Zaretskii
2018-06-16 16:45         ` Paul Eggert
2018-06-16 15:23   ` Noam Postavsky
2018-06-16 15:30     ` Paul Eggert
2018-06-16 23:00       ` Drew Adams
2018-06-17  4:44   ` Michael Heerdegen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CA+T2Sh39fHzP0D-XeY5LqCSnaE-eHVD957ZahQ5VaQH1miMkgA@mail.gmail.com \
    --to=vibhavp@gmail.com \
    --cc=31718@debbugs.gnu.org \
    --cc=ikumi@ikumi.que.jp \
    --cc=npostavs@gmail.com \
    --cc=robert-emacs@cochranmail.com \
    --cc=schwab@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).