From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Ivan Andrus Newsgroups: gmane.emacs.bugs Subject: bug#23610: 25.0.94; c++-mode doesn't fontify typename... like typename Date: Wed, 22 Jun 2016 09:22:01 -0600 Message-ID: References: <20160619211440.86830.qmail@mail.muc.de> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-Trace: ger.gmane.org 1466609190 3921 80.91.229.3 (22 Jun 2016 15:26:30 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 22 Jun 2016 15:26:30 +0000 (UTC) Cc: 23610@debbugs.gnu.org To: Alan Mackenzie Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Jun 22 17:26:22 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1bFk2o-0002Y9-2s for geb-bug-gnu-emacs@m.gmane.org; Wed, 22 Jun 2016 17:26:22 +0200 Original-Received: from localhost ([::1]:59086 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bFk2n-00039y-4m for geb-bug-gnu-emacs@m.gmane.org; Wed, 22 Jun 2016 11:26:21 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:39756) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bFjzf-0000YT-Mx for bug-gnu-emacs@gnu.org; Wed, 22 Jun 2016 11:23:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bFjza-0003Xk-Mj for bug-gnu-emacs@gnu.org; Wed, 22 Jun 2016 11:23:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:38976) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bFjza-0003Xe-Il; Wed, 22 Jun 2016 11:23:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1bFjza-0005R9-EV; Wed, 22 Jun 2016 11:23:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Ivan Andrus Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org, bug-cc-mode@gnu.org Resent-Date: Wed, 22 Jun 2016 15:23:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 23610 X-GNU-PR-Package: emacs,cc-mode X-GNU-PR-Keywords: Original-Received: via spool by 23610-submit@debbugs.gnu.org id=B23610.146660893120819 (code B ref 23610); Wed, 22 Jun 2016 15:23:02 +0000 Original-Received: (at 23610) by debbugs.gnu.org; 22 Jun 2016 15:22:11 +0000 Original-Received: from localhost ([127.0.0.1]:51313 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bFjyk-0005Pi-UE for submit@debbugs.gnu.org; Wed, 22 Jun 2016 11:22:11 -0400 Original-Received: from mail-vk0-f54.google.com ([209.85.213.54]:32820) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bFjyh-0005PS-Sd for 23610@debbugs.gnu.org; Wed, 22 Jun 2016 11:22:10 -0400 Original-Received: by mail-vk0-f54.google.com with SMTP id d185so66495685vkg.0 for <23610@debbugs.gnu.org>; Wed, 22 Jun 2016 08:22:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=NHLYz4rYd+tVel0hxu2G8xAUL4lSnX5m+rNQaOo/5nY=; b=W0jnkO4n69abqJLDTjcLclgU8X18TaE+ylwEFwZkNNtNwpTmSgSHnO0mKQUq71vzfY AQatCX9iEpPoET+g12tAd1yk16VJhyEakhqzOVgXwY+qLduC35JjafvPlLiElsNoce60 qA1xBMErO49vw5uc6Knit02QOmM99FbALGBD/DJK3cdm+McrJAhM19uWS6kG6KlXbtxE 2W0XCRzVN/kQqFSy9A7gjh2rCt6ic8m75tVucljSeLa53cknfSo6n9OOkl1UwFb1CEaZ o8Ec+GZXKjA5BnN72eBfr0XiSE5t5scaMFKNhXwFDcfClYhcoTjQg/eDmH07Ykg1Zcdx Gh3g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=NHLYz4rYd+tVel0hxu2G8xAUL4lSnX5m+rNQaOo/5nY=; b=BX9QOdwWh9F/vsuG1OTDloe6YNzylBRbDjV59wSkYfbkasO/yKrWdeP08Yxe+sbunG RF+XGS1HN+c9FfNJuzXxXXoBU0f/iqPgaCqKlRwv6+LiQJ8DG9gtXPMXmsgISWdyXVxD 9DXjk11evGFDmssR1z0AWYo96pUvnuEB3Aci+kK0aGorevh4B15V4YrlMc+Kz360cUEL r1Vd1BPokAbM7HvVPiD1J5AspWNVFuCwWceKCZoQgNVbiswdftDY+0XL/Ne2j3GqvtUc VcwKTvuEsTnKUxzXu2EMTPbCCUam93w4ySlGeh/hGZibL3JUBcDOjUHU1UH3DSJmX4kJ A3Cg== X-Gm-Message-State: ALyK8tKUwGwGYMvjvUlTMUccpG9xt/1mPLBOsmZUP/mhvV65Kd/8jdGjittY9NNu2yjLxJPoM34mwoXdT266MA== X-Received: by 10.159.34.229 with SMTP id 92mr10415957uan.150.1466608922182; Wed, 22 Jun 2016 08:22:02 -0700 (PDT) Original-Received: by 10.103.28.5 with HTTP; Wed, 22 Jun 2016 08:22:01 -0700 (PDT) In-Reply-To: <20160619211440.86830.qmail@mail.muc.de> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:119939 Archived-At: On Sun, Jun 19, 2016 at 3:14 PM, Alan Mackenzie wrote: > Hello, Ivan. > > In article you wrote: >> Starting with emacs -Q, Y is not fontified in the snippet below, whereas >> X is. > >> -Ivan > > >> template >> class bob { > >> }; > > [ .... ] > > The following patch is a first attempt to fontify parameter packs. After > applying it, please be sure either to recompile CC Mode entirely, or > first to compile cc-langs.el (which contains macros), and then all three > of cc-fonts.el, cc-engine.el, and cc-mode.el. > > It seems to fontify the "Y" above OK. I've tried it on a stock example > out of Wikipedia, and that works. Could you try it out on your code, > please, and let me know how well it works. It looks pretty good. I didn't notice this before, but the following example from Wikipedia is fontified differently if the ... is removed from before the `args`. In that case args is fontified with `font-lock-variable-name-face`. template inline void expand(Args&&... args) { pass( some_function(args)... ); } FWIW, I've seen similar mis-fontifications before (without ...) and it hasn't bothered me too much. I just found a reproducible case, so I guess I'll open a bug for it. Thanks for working on this. The raw string support is awesome! -Ivan