unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Erik Overdahl <erik.overdahl@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 66549@debbugs.gnu.org
Subject: bug#66549: 29.1.50; SIGABRT received parsing file with tree-sitter in PGTK Emacs
Date: Sun, 15 Oct 2023 15:03:09 -0500	[thread overview]
Message-ID: <CA+PiuB6i+_cPaYTZS48yuJrjHSp8q+-YggP5x=14WS5+-3W1SA@mail.gmail.com> (raw)
In-Reply-To: <83a5sjpuna.fsf@gnu.org>

I am unable to reproduce this; a manually built shared object still
crashes for me. I am not sure what steps you took to build the
grammar. When I build it manually, I still get the crash. However, the
tree-sitter-hcl maintainer had the same success that you did:
https://github.com/MichaHoffmann/tree-sitter-hcl/issues/38#issuecomment-1763385350.

Does the crash occur if you build the grammar using
`treesit-install-language-grammar`?

Regarding the difference in environment - this is what I was hoping to
avoid by providing container files in which I know the crash is
reliably reproduced. I hope the backtrace file I provided is adequate.
Apologies for the delay on that.

On 10/15/23, Eli Zaretskii <eliz@gnu.org> wrote:
>> From: Erik Overdahl <erik.overdahl@gmail.com>
>> Date: Sun, 15 Oct 2023 13:36:26 -0500
>> Cc: 66549@debbugs.gnu.org
>>
>> The reproduction instructions included in my bug report are all that
>> is required. The linked GitHub repo contains Dockerfiles that allow
>> the bug to be reproduced exactly, but does not have any information
>> that is missing from this bug report.
>>
>> Here is a minimal HCL file that I can confirm causes the SIGABRT when
>> parsed:
>>
>> resource "example" "literals" {
>>   attr1 = "val1"
>> }
>
> Thanks.  My configuration is different from yours, but I tried to
> reproduce the problem as best I could, and failed.
>
> Here's what I did:
>
>   . cloned the treesit-hcl grammar, built it and installed it
>   . started Emacs as "emacs -Q"
>   . M-x load-library RET treesit RET
>   . M-: (treesit-ready-p 'hcl) RET -- this yielded t, so the grammar
>     is installed and available
>   . typed the following in *scratch*:
>
> (with-temp-buffer
>   (insert-file-contents "~/data/example.hcl")
>   ;; `treesit-parser-create' creates a parser for the buffer that is
>   ;; then invoked lazily. Using `treesit-parse-string' to force parse.
>   (treesit-parse-string (buffer-string) 'hcl))
>
>   . evaluated this expression with C-x C-e
>
> The result was:
>
>   #<treesit-node config_file in 1-52>
>
> So I'm unable to reproduce the abort.
>
> This is why I asked you to run Emacs under GDB and post the backtrace
> when it crashes.
>





  reply	other threads:[~2023-10-15 20:03 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-14 20:19 bug#66549: 29.1.50; SIGABRT received parsing file with tree-sitter in PGTK Emacs Erik Overdahl
2023-10-15  5:40 ` Eli Zaretskii
2023-10-15 18:36   ` Erik Overdahl
2023-10-15 19:12     ` Eli Zaretskii
2023-10-15 20:03       ` Erik Overdahl [this message]
2023-10-16 11:29         ` Eli Zaretskii
     [not found]           ` <CA+PiuB7EfnM9SG6syhNRGBAMvpr3BH_pgbLtdsU2usVpcvXxyw@mail.gmail.com>
2023-10-17  2:29             ` Eli Zaretskii
2023-10-17 21:24               ` Erik Overdahl
2023-10-18  2:30                 ` Eli Zaretskii
2023-10-29 11:28                   ` Eli Zaretskii
2023-10-15 19:31     ` Erik Overdahl
2023-10-16 11:22       ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CA+PiuB6i+_cPaYTZS48yuJrjHSp8q+-YggP5x=14WS5+-3W1SA@mail.gmail.com' \
    --to=erik.overdahl@gmail.com \
    --cc=66549@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).