From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Robert Weiner Newsgroups: gmane.emacs.bugs Subject: bug#23567: find-function-search-for-symbol of find-func.el leaves point moved but should not Date: Tue, 17 May 2016 15:51:40 -0400 Message-ID: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary=001a113d0f0498016205330f13c9 X-Trace: ger.gmane.org 1463537349 31107 80.91.229.3 (18 May 2016 02:09:09 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 18 May 2016 02:09:09 +0000 (UTC) To: 23567@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed May 18 04:09:00 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1b2quw-0001Hf-G7 for geb-bug-gnu-emacs@m.gmane.org; Wed, 18 May 2016 04:08:58 +0200 Original-Received: from localhost ([::1]:42222 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b2quv-0003mu-OV for geb-bug-gnu-emacs@m.gmane.org; Tue, 17 May 2016 22:08:57 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:60482) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b2qTz-00040z-IJ for bug-gnu-emacs@gnu.org; Tue, 17 May 2016 21:41:11 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b2qTu-0000KB-RO for bug-gnu-emacs@gnu.org; Tue, 17 May 2016 21:41:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:44047) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b2qTu-0000K5-Mo for bug-gnu-emacs@gnu.org; Tue, 17 May 2016 21:41:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1b2qTu-0006sd-IF for bug-gnu-emacs@gnu.org; Tue, 17 May 2016 21:41:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Robert Weiner Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 18 May 2016 01:41:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 23567 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.146353565426399 (code B ref -1); Wed, 18 May 2016 01:41:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 18 May 2016 01:40:54 +0000 Original-Received: from localhost ([127.0.0.1]:56380 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b2qTm-0006rj-5u for submit@debbugs.gnu.org; Tue, 17 May 2016 21:40:54 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:40723) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b2qTk-0006rS-5r for submit@debbugs.gnu.org; Tue, 17 May 2016 21:40:52 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b2qTb-00007Z-7r for submit@debbugs.gnu.org; Tue, 17 May 2016 21:40:47 -0400 Original-Received: from lists.gnu.org ([2001:4830:134:3::11]:39331) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b2qTb-00006e-4E for submit@debbugs.gnu.org; Tue, 17 May 2016 21:40:43 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:56139) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b2qTW-0001Gk-Ia for bug-gnu-emacs@gnu.org; Tue, 17 May 2016 21:40:41 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b2l2I-0004Hx-QO for bug-gnu-emacs@gnu.org; Tue, 17 May 2016 15:52:11 -0400 Original-Received: from mail-oi0-x22b.google.com ([2607:f8b0:4003:c06::22b]:34348) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b2l2I-0004Ht-Ld for bug-gnu-emacs@gnu.org; Tue, 17 May 2016 15:52:10 -0400 Original-Received: by mail-oi0-x22b.google.com with SMTP id k142so42823691oib.1 for ; Tue, 17 May 2016 12:52:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:from:date:message-id:subject:to; bh=h7/TRkRu4+pb/VnrtQPR53cTbROVPnTlnCT2GxNUBhA=; b=JM79kgpGic9F0hYVRGOqAOIXfOLh6fTT47VPaWtqZr80lED5OUiotsB3NPwVmlZe9h J0V0ixIW5QXTLgVwQ4syBwnKeXgMCujeUoeS9/782zw/cQmMaCVlzMsfE6AFWY5ykByJ PfsXfofXrVp4RU0GcokzNmIgROlQKPEhsi/IMSCHf8NPiztXkYDHORl0Wd8AuZjuWXTZ Vih5Y8AJ0Z52qSokQ4sHDVrzkd6WrNJ/gSU+vUiYEZLAeFH6XQYL05wrk5CYZ6W6OXYB lDpNvilx3JUwqNIV+8+kd5uvatd0qRiUm6LNsxbtacX8wPQ20wIuBmhkMfFY4nQvoqXd 0lpw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=h7/TRkRu4+pb/VnrtQPR53cTbROVPnTlnCT2GxNUBhA=; b=jriVFB1FCQ6BFv7Ew51plDvXIyy7cO7nwzjXN0u248D1F0xu3oYtuRFxbXivnnwieB 47kCS2ZKd7bqWOaqh8yIs/urjUyf8g0zBSt4QMc7ybslHXVpJUBG5z3Vmzewy/indd2r RXY/OSYdKjq7LAlHbzmGkpmWU76dtUgWNq0Ig1sWzErMieJpjysqOzVIwDhGvn18wh0G g7OxRP/FWjzNZax4D4uwkB8GN/B7OYPFNME2TFVl17qXTXagGGWos4tRyXGVIIRT4RGf M+XKY5nrJBX5LYmCu/RE4kEFUmLZ81F+2ntCF/sAdH+85gNzsi3+pQpMSNPzlVSve65X NTEA== X-Gm-Message-State: AOPr4FXp8wcZi/vM654iyToG9cp33j/8n9l3e4YOa/NITkoK2alOaJPEoC/qNK3wKXC1GzNAmvV5TThOFEIIBA== X-Received: by 10.157.15.163 with SMTP id d32mr1969249otd.160.1463514729806; Tue, 17 May 2016 12:52:09 -0700 (PDT) Original-Received: by 10.202.83.135 with HTTP; Tue, 17 May 2016 12:51:40 -0700 (PDT) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:118368 Archived-At: --001a113d0f0498016205330f13c9 Content-Type: text/plain; charset=UTF-8 find-function-search-for-symbol in find-func.el is called for its return value and not for side-effects but presently it moves point around in the buffers it affects. It needs some save-excursion protection. This is true for the most recent 25.1 release I looked at and I don't think any changes have been made to it since then. One example of where this causes a problem is in xref-location-marker of elisp-mode.el. Again, that is called simply to return the marker but because it calls find-function-search-for-symbol, it can move point and cause other problems. It would be best if someone familiar with this first function made the change to ensure it is correct. --001a113d0f0498016205330f13c9 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
find-function-search-for-symbol in find-func.el is ca= lled for its
return value and not for side-effects but presen= tly it moves point
around in the buffers it affects.=C2=A0 It nee= ds some save-excursion
protection.=C2=A0 This is true for the mos= t recent 25.1 release I looked at
and I don't think any chang= es have been made to it since then.

One example of= where this causes a problem is in xref-location-marker
of elisp-= mode.el.=C2=A0 Again, that is called simply to return the marker
= but because it calls find-function-search-for-symbol, it can move
point and cause other problems.

It would be best = if someone familiar with this first function made the
change to e= nsure it is correct.

--001a113d0f0498016205330f13c9--