bug#23567: find-function-search-for-symbol of find-func.el leaves point moved but should not

bug#23567: find-function-search-for-symbol of find-func.el leaves point moved but should not

[Robert Weiner]

[-- Attachment #1: Type: text/plain, Size: 673 bytes --]

find-function-search-for-symbol in find-func.el is called for its
return value and not for side-effects but presently it moves point
around in the buffers it affects.  It needs some save-excursion
protection.  This is true for the most recent 25.1 release I looked at
and I don't think any changes have been made to it since then.

One example of where this causes a problem is in xref-location-marker
of elisp-mode.el.  Again, that is called simply to return the marker
but because it calls find-function-search-for-symbol, it can move
point and cause other problems.

It would be best if someone familiar with this first function made the
change to ensure it is correct.

[-- Attachment #2: Type: text/html, Size: 860 bytes --]

bug#23567: find-function-search-for-symbol of find-func.el leaves point moved but should not

[Dmitry Gutov]

Hi Robert,

On 05/17/2016 10:51 PM, Robert Weiner wrote:

> One example of where this causes a problem is in xref-location-marker
> of elisp-mode.el.  Again, that is called simply to return the marker
> but because it calls find-function-search-for-symbol, it can move
> point and cause other problems.

Could you please describe a step-by-step scenario illustrating such 
problem? Preferably starting with 'emacs -Q'.

bug#23567: find-function-search-for-symbol of find-func.el leaves point moved but should not

[Robert Weiner]

[-- Attachment #1: Type: text/plain, Size: 1030 bytes --]

On Thu, May 19, 2016 at 7:47 PM, Dmitry Gutov <dgutov@yandex.ru> wrote:

> Hi Robert,
>
> On 05/17/2016 10:51 PM, Robert Weiner wrote:
>
> One example of where this causes a problem is in xref-location-marker
>> of elisp-mode.el.  Again, that is called simply to return the marker
>> but because it calls find-function-search-for-symbol, it can move
>> point and cause other problems.
>>
>
> Could you please describe a step-by-step scenario illustrating such
> problem? Preferably starting with 'emacs -Q'.
>

As of Emacs 25.0.94, I can no longer replicate the problem, so some updates
must have fixed it.  Great.  Please close this issue.

If you ever need a test case for this, the following code should show the
definition of outline-show-all in only the upper window but when the bug
existed, both windows would be scrolled to its definition.

(progn
  (delete-other-windows)
  (find-library "outline")
  (display-buffer-pop-up-window "outline.el.gz" nil)
  (find-function-search-for-symbol 'outline-show-all nil "outline"))

[-- Attachment #2: Type: text/html, Size: 1753 bytes --]

bug#23567: find-function-search-for-symbol of find-func.el leaves point moved but should not

[Dmitry Gutov]

On 05/23/2016 08:53 PM, Robert Weiner wrote:

> As of Emacs 25.0.94, I can no longer replicate the problem, so some
> updates must have fixed it.  Great.  Please close this issue.

Good to hear, closing. And that why we usually ask for the reproduction 
scenario in bug reports, not just "this code doesn't look right to me".

I don't think any of the recent changes fixed this. Even as we discussed 
this issue in private (a couple of weeks ago?), I tried to produce a 
problem scenario, and failed.