From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Tom Gillespie Newsgroups: gmane.emacs.bugs Subject: bug#56487: xgselect race condition leading to abort when USE_GTK not defined Date: Sun, 10 Jul 2022 19:50:08 -0700 Message-ID: References: <871qus1kkt.fsf@yahoo.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="000000000000de4b4305e37e9c30" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="1167"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Po Lu To: 56487@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Jul 11 04:51:12 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oAjVw-000071-B8 for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 11 Jul 2022 04:51:12 +0200 Original-Received: from localhost ([::1]:57532 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oAjVv-0004ay-6s for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 10 Jul 2022 22:51:11 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:54744) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oAjVn-0004ap-GL for bug-gnu-emacs@gnu.org; Sun, 10 Jul 2022 22:51:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:44193) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oAjVm-0000Jk-IN for bug-gnu-emacs@gnu.org; Sun, 10 Jul 2022 22:51:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oAjVm-0006G6-Bj for bug-gnu-emacs@gnu.org; Sun, 10 Jul 2022 22:51:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Tom Gillespie Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 11 Jul 2022 02:51:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 56487 X-GNU-PR-Package: emacs Original-Received: via spool by 56487-submit@debbugs.gnu.org id=B56487.165750782824013 (code B ref 56487); Mon, 11 Jul 2022 02:51:02 +0000 Original-Received: (at 56487) by debbugs.gnu.org; 11 Jul 2022 02:50:28 +0000 Original-Received: from localhost ([127.0.0.1]:38090 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oAjVE-0006FD-0c for submit@debbugs.gnu.org; Sun, 10 Jul 2022 22:50:28 -0400 Original-Received: from mail-pl1-f172.google.com ([209.85.214.172]:40715) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oAjVC-0006Ev-WC for 56487@debbugs.gnu.org; Sun, 10 Jul 2022 22:50:27 -0400 Original-Received: by mail-pl1-f172.google.com with SMTP id b2so3325993plx.7 for <56487@debbugs.gnu.org>; Sun, 10 Jul 2022 19:50:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=fK1IRhNmUzOAZsBQaBEwJQloklV9QpgFaBPkjKkIewo=; b=eYIhFd9ZyRlJqzRced/9HnaiWynZPyFUxvu0CUG7zpxRz1i40RxPjXgphUXpoqQSZt PJgcU37yL037w7AIozdZ3UrSAyiBq/Kf+GnT/rTvM4AynGgAnZQ5nTosrRnLI45r7GuH GgjhHIPPaHUjbciJSiYG9PKig1xP7AkEg/OIgubFLh2E1NaYm4FxgmKgxyX2Gdu6HQWb eFbiluwKfyZBO1JMBtxjDaFMPSUCtmRPlqPogwiy/6JzC4WU07K58Or2RueteTACjO4U Gf2iUIuBPg2VgSn6bfhB3PUSqWrJ/zekPY/Po/6RxSSbMhQL5/kmvezfn3MRiB6fakwq wcmQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=fK1IRhNmUzOAZsBQaBEwJQloklV9QpgFaBPkjKkIewo=; b=eyWA0gcNmEUtSyTIyAbmCKkO+8VOVo3azKhCx3QYE5BnjU7Bg9ZdQWQS/Sa9B/QAPW Wo1dP1WcPSYXmGYUaKS9ckENeBmybGzA8ExJRhFNh20cig9zeLJgHJqruurMrMnMz8q5 r/tF2nP+ur55h8FUaGzWubLcH9cMKPm6ThZ0vkD4Fr8+I+Fdwzq2lx/INtCjUr4T8kNZ YmX6mlQvW8DHDo3juMddj0JqGrISaXc2NatauRbYH/ygsmG1j1YU6N6TEubfBNCcv9kh rmRsAAKHSUiwvZehXkgs9aKh0eLR3q+dDzGVChGn74R3NujRC+IUm4kxypzgBFqKUwk/ briw== X-Gm-Message-State: AJIora94vA8Yi6Ud6xc2jR3ZHQLOVwlnpqLylo2+ZZv174OqfTr6z6es T+xzPFdFpkzzIPPfHgHGaFlbrVwke4z5osmgYw19t/mg X-Google-Smtp-Source: AGRyM1vuahhVFTWs0E6nB1eWpiO1DGhFjY9DngGdBwRfureOZST7m7NrlXGN/grs9vwu/oDOo3+u+5OyoK5mkw9GUIY= X-Received: by 2002:a17:902:7244:b0:16b:d4a8:b92e with SMTP id c4-20020a170902724400b0016bd4a8b92emr16511275pll.16.1657507820731; Sun, 10 Jul 2022 19:50:20 -0700 (PDT) In-Reply-To: <871qus1kkt.fsf@yahoo.com> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:236602 Archived-At: --000000000000de4b4305e37e9c30 Content-Type: text/plain; charset="UTF-8" Here is (I think) the patch with correctly formatted change log entries. --000000000000de4b4305e37e9c30 Content-Type: text/x-patch; charset="US-ASCII"; name="0001-xgselect.c-avoid-race-condition-leading-to-abort.patch" Content-Disposition: attachment; filename="0001-xgselect.c-avoid-race-condition-leading-to-abort.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_l5g5cdc50 RnJvbSBiM2E3YzU3MTViMTk5YzljZTkzNWE5MDFkMmViMDJmMjM4YWYwNzY5IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBUb20gR2lsbGVzcGllIDx0Z2J1Z3NAZ21haWwuY29tPgpEYXRl OiBUdWUsIDUgSnVsIDIwMjIgMTM6NDM6MjUgLTA3MDAKU3ViamVjdDogW1BBVENIXSB4Z3NlbGVj dC5jOiBhdm9pZCByYWNlIGNvbmRpdGlvbiBsZWFkaW5nIHRvIGFib3J0CgoqIHNyYy94Z3NlbGVj dC5jICh4Z19zZWxlY3QpOiBSZW1vdmUgaWZkZWZzIHRoYXQgd2VyZSBwcmV2aW91c2x5IFVTRV9H VEsKc3BlY2lmaWMgdG8gYmUgdW5jb25kaXRpb25hbC4gVGhpcyBwcmV2ZW50cyBhIHJhY2UgY29u ZGl0aW9uIGNhdXNlZCBieQphIGNhbGwgdG8gcmVsZWFzZV9zZWxlY3RfbG9jayBmcm9tIHRyaWdn ZXJpbmcgd2hlbiBjb25maWd1cmluZyBFbWFjcwp3aXRoIGFueSB0b29sa2l0IG90aGVyIHRoYW4g Z3RrLgoocmVsZWFzZV9zZWxlY3RfbG9jayk6IEFkZCBhIGJyYW5jaCB0byBjaGVjayB3aGV0aGVy CnRocmVhZHNfaG9sZGluZ19nbGliX2xvY2sgaGFzIGdvbmUgbmVnYXRpdmUsIGFuZCBpZiBzbywg cmVzdG9yZSB0bwp6ZXJvLiAgSW4gdGhlIGNhc2Ugd2hlcmUgdGhlcmUgYXJlIG11bHRpcGxlIHRo cmVhZHMsCnRocmVhZHNfaG9sZGluZ19nbGliX2xvY2sgY291bGQgYmVjb21lIGFuZCBzdGF5IG5l Z2F0aXZlLCBwcmV2ZW5kaW5nCmdfbWFpbl9jb250ZXh0X3JlbGVhc2UgZnJvbSBldmVyIGJlaW5n IGNhbGxlZCwgZXZlbiB3aGVuIGl0IHNob3VsZApoYXZlIGJlZW4uCgpBcyBmYXIgYXMgSSBjYW4g dGVsbCB0aGUgd2F5IHRoYXQgdGhlIHRocmVhZC5jIGFuZCB4Z3NlbGVjdC5jIGNvZGUgd2FzCndy aXR0ZW4gd2FzIHdpdGggdGhlIGludGVudGlvbiBvZiBhdm9pZGluZyBhZGRpdGlvbmFsIGxvY2tz LiBUaGlzIG1lYW5zCnRoYXQgdGhpcyBjb2RlIGlzIGV4cXVpc2l0ZWx5IHNlbnN0aXZpZSB0byBz bGlnaHQgY2hhbmdlcyBpbiB0aW1pbmcuIEEKY29tbWVudCBpbiB0aHJlYWQuYyBoYXMgYmVlbiBh ZGRlZCBhdCBvbmUgbG9jYXRpb24gd2hlcmUgdGhpcyBoYXBwZW5zLgoKSXQgaXMgZW50aXJlbHkg cG9zc2libGUgdGhhdCB0aGUgcmVtb3ZhbCBvZiB0aGUgaWZkZWZzIGJyYW5jaGluZyBvbgpVU0Vf R1RLIHJlc29sdmVzIHRoaXMgaXNzdWUgYnkgc2xpZ2h0bHkgY2hhbmdpbmcgdGhlIHRpbWluZ3Mg d2hlbgp1c2luZyBvdGhlci9ubyB0b29sa2l0cyBzbyB0aGF0IHRoZSBhYm9ydCBkb2VzIG5vdCB0 cmlnZ2VyLiBJbiBhbGwKY2FzZXMgYWJvcnRzIGNhbiBiZSBpbmR1Y2VkIGJ5IGFkZGluZyBzb21l dGhpbmcgbGlrZSBmcHV0cyBpbiB0aHJlYWQuYwphdCB0aGUgbG9jYXRpb24gb2YgdGhlIG5ldyBj b21tZW50LgoKRm9yIHRoZSByZWNvcmQsIHRoZSBhYm9ydCBiZWhhdmlvciBpcyBub3QgcHJlc2Vu dCBpbiBFbWFjcyAyNywgYW5kIHdhcwppbnRyb2R1Y2VkIGJ5IDljNjJmZmIwODI2MmM4MmI3ZTM4 ZTZlYjU3NjdmMjA4NzQyNGFhNDcgKHRoZSBiaXNlY3Qgd2FzCnF1aXRlIGEgcGFpbiwgc28gaG9w ZWZ1bGx5IG5vIG9uZSBldmVyIG5lZWRzIHRvIGRvIGl0IGFnYWluKS4KLS0tCiBzcmMvdGhyZWFk LmMgICB8ICA1ICsrKysrCiBzcmMveGdzZWxlY3QuYyB8IDI5ICsrKysrKysrKysrKy0tLS0tLS0t LS0tLS0tLS0tCiAyIGZpbGVzIGNoYW5nZWQsIDE3IGluc2VydGlvbnMoKyksIDE3IGRlbGV0aW9u cygtKQoKZGlmZiAtLWdpdCBhL3NyYy90aHJlYWQuYyBiL3NyYy90aHJlYWQuYwppbmRleCA2MjZk MTRhYWQwLi5hMGU4NWJiNzVjIDEwMDY0NAotLS0gYS9zcmMvdGhyZWFkLmMKKysrIGIvc3JjL3Ro cmVhZC5jCkBAIC02MTIsNiArNjEyLDExIEBAIHJlYWxseV9jYWxsX3NlbGVjdCAodm9pZCAqYXJn KQogICBzYS0+cmVzdWx0ID0gKHNhLT5mdW5jKSAoc2EtPm1heF9mZHMsIHNhLT5yZmRzLCBzYS0+ d2Zkcywgc2EtPmVmZHMsCiAJCQkgICBzYS0+dGltZW91dCwgc2EtPnNpZ21hc2spOwogCisgIC8q IFRoZSBleGFjdCB0aW1pbmcgb2YgdGhpcyBjYWxsIGlzIGNyaXRpY2FsLiBJZiB5b3UgYXJlIGRl YnVnZ2luZworICAgICBhbmQgYWRkIGEgY2FsbCB0byBlLmcuIGZwdXRzIGJlZm9yZSByZWxlYXNl X3NlbGVjdF9sb2NrLCB0aGVuCisgICAgIHRoZSBpbnRlcm5hbCBjYWxsIHRvIGdfbWFpbl9jb250 ZXh0X3JlbGVhc2UgY2FuIHNvbWV0aW1lcyByZXN1bHQKKyAgICAgaW4gYSBuZWdhdGl2ZSBvdmVy ZmxvdyBvZiBnbWFpbiBjb250ZXh0LT5vd25lcl9jb3VudCwgdHJpZ2dlcmluZworICAgICBhbiBh Ym9ydC4gKi8KICAgcmVsZWFzZV9zZWxlY3RfbG9jayAoKTsKIAogICBibG9ja19pbnRlcnJ1cHRf c2lnbmFsICgmb2xkc2V0KTsKZGlmZiAtLWdpdCBhL3NyYy94Z3NlbGVjdC5jIGIvc3JjL3hnc2Vs ZWN0LmMKaW5kZXggNmUwOWExNWZhOC4uOWE3OTEyMTYxNyAxMDA2NDQKLS0tIGEvc3JjL3hnc2Vs ZWN0LmMKKysrIGIvc3JjL3hnc2VsZWN0LmMKQEAgLTM5LDEyICszOSwyMCBAQCBDb3B5cmlnaHQg KEMpIDIwMDktMjAyMiBGcmVlIFNvZnR3YXJlIEZvdW5kYXRpb24sIEluYy4KIHZvaWQKIHJlbGVh c2Vfc2VsZWN0X2xvY2sgKHZvaWQpCiB7CisgIHB0cmRpZmZfdCBsdGhnbDsKICNpZiBHTlVDX1BS RVJFUSAoNCwgNywgMCkKLSAgaWYgKF9fYXRvbWljX3N1Yl9mZXRjaCAoJnRocmVhZHNfaG9sZGlu Z19nbGliX2xvY2ssIDEsIF9fQVRPTUlDX0FDUV9SRUwpID09IDApCi0gICAgZ19tYWluX2NvbnRl eHRfcmVsZWFzZSAoZ2xpYl9tYWluX2NvbnRleHQpOworICBsdGhnbCA9IF9fYXRvbWljX3N1Yl9m ZXRjaCAoJnRocmVhZHNfaG9sZGluZ19nbGliX2xvY2ssIDEsIF9fQVRPTUlDX0FDUV9SRUwpOwor ICBpZiAobHRoZ2wgPT0gMCkKKyAgICAgIGdfbWFpbl9jb250ZXh0X3JlbGVhc2UgKGdsaWJfbWFp bl9jb250ZXh0KTsKKyAgZWxzZSBpZiAobHRoZ2wgPCAwKQorICAgIC8qIHJlc2V0IHRvIHplcm8g aW4gdGhlIGV2ZW50IHRoYXQgbXVsdGlwbGUgdGhyZWFkcyBjYXVzZSB0aGlzIHRvIGdvIHRvIC0x ICovCisgICAgX19hdG9taWNfZmV0Y2hfYWRkICgmdGhyZWFkc19ob2xkaW5nX2dsaWJfbG9jaywg MSwgX19BVE9NSUNfQUNRX1JFTCk7CiAjZWxzZQotICBpZiAoLS10aHJlYWRzX2hvbGRpbmdfZ2xp Yl9sb2NrID09IDApCisgIGx0aGdsID0gLS10aHJlYWRzX2hvbGRpbmdfZ2xpYl9sb2NrOworICBp ZiAobHRoZ2wgPT0gMCkKICAgICBnX21haW5fY29udGV4dF9yZWxlYXNlIChnbGliX21haW5fY29u dGV4dCk7CisgIGVsc2UgaWYgKGx0aGdsIDwgMCkKKyAgICB0aHJlYWRzX2hvbGRpbmdfZ2xpYl9s b2NrKys7CiAjZW5kaWYKIH0KIApAQCAtMTE2LDkgKzEyNCw3IEBAIHhnX3NlbGVjdCAoaW50IGZk c19saW0sIGZkX3NldCAqcmZkcywgZmRfc2V0ICp3ZmRzLCBmZF9zZXQgKmVmZHMsCiAgIGludCBu X2dmZHMsIHJldHZhbCA9IDAsIG91cl9mZHMgPSAwLCBtYXhfZmRzID0gZmRzX2xpbSAtIDE7CiAg IGludCBpLCBuZmRzLCB0bW9faW5fbWlsbGlzZWMsIG11c3RfZnJlZSA9IDA7CiAgIGJvb2wgbmVl ZF90b19kaXNwYXRjaDsKLSNpZmRlZiBVU0VfR1RLCiAgIGJvb2wgYWxyZWFkeV9oYXNfZXZlbnRz OwotI2VuZGlmCiAKICAgaWYgKHhnX3NlbGVjdF9zdXBwcmVzc19jb3VudCkKICAgICByZXR1cm4g cHNlbGVjdCAoZmRzX2xpbSwgcmZkcywgd2ZkcywgZWZkcywgdGltZW91dCwgc2lnbWFzayk7CkBA IC0xMjYsOCArMTMyLDggQEAgeGdfc2VsZWN0IChpbnQgZmRzX2xpbSwgZmRfc2V0ICpyZmRzLCBm ZF9zZXQgKndmZHMsIGZkX3NldCAqZWZkcywKICAgY29udGV4dCA9IGdfbWFpbl9jb250ZXh0X2Rl ZmF1bHQgKCk7CiAgIGFjcXVpcmVfc2VsZWN0X2xvY2sgKGNvbnRleHQpOwogCi0jaWZkZWYgVVNF X0dUSwogICBhbHJlYWR5X2hhc19ldmVudHMgPSBnX21haW5fY29udGV4dF9wZW5kaW5nIChjb250 ZXh0KTsKKyNpZmRlZiBVU0VfR1RLCiAjaWZuZGVmIEhBVkVfUEdUSwogICBhbHJlYWR5X2hhc19l dmVudHMgPSBhbHJlYWR5X2hhc19ldmVudHMgJiYgeF9ndGtfdXNlX25hdGl2ZV9pbnB1dDsKICNl bmRpZgpAQCAtMTc5LDEyICsxODUsNiBAQCB4Z19zZWxlY3QgKGludCBmZHNfbGltLCBmZF9zZXQg KnJmZHMsIGZkX3NldCAqd2ZkcywgZmRfc2V0ICplZmRzLAogCXRtb3AgPSAmdG1vOwogICAgIH0K IAotI2lmbmRlZiBVU0VfR1RLCi0gIGZkc19saW0gPSBtYXhfZmRzICsgMTsKLSAgbmZkcyA9IHRo cmVhZF9zZWxlY3QgKHBzZWxlY3QsIGZkc19saW0sCi0JCQkmYWxsX3JmZHMsIGhhdmVfd2ZkcyA/ ICZhbGxfd2ZkcyA6IE5VTEwsIGVmZHMsCi0JCQl0bW9wLCBzaWdtYXNrKTsKLSNlbHNlCiAgIC8q IE9uIFBHVEssIHdoZW4geW91IHR5cGUgYSBrZXksIHRoZSBrZXkgcHJlc3MgZXZlbnQgYXJlIHJl Y2VpdmVkLAogICAgICBhbmQgb25lIG1vcmUga2V5IHByZXNzIGV2ZW50IHNlZW1zIHRvIGJlIHJl Y2VpdmVkIGludGVybmFsbHkuCiAKQEAgLTIxNyw3ICsyMTcsNiBAQCB4Z19zZWxlY3QgKGludCBm ZHNfbGltLCBmZF9zZXQgKnJmZHMsIGZkX3NldCAqd2ZkcywgZmRfc2V0ICplZmRzLAogCUZEX1pF Uk8gKGVmZHMpOwogICAgICAgb3VyX2ZkcysrOwogICAgIH0KLSNlbmRpZgogCiAgIGlmIChuZmRz IDwgMCkKICAgICByZXR2YWwgPSBuZmRzOwpAQCAtMjQ4LDExICsyNDcsNyBAQCB4Z19zZWxlY3Qg KGludCBmZHNfbGltLCBmZF9zZXQgKnJmZHMsIGZkX3NldCAqd2ZkcywgZmRfc2V0ICplZmRzLAog CiAgIC8qIElmIEd0aysgaXMgaW4gdXNlIGV2ZW50dWFsbHkgZ3RrX21haW5faXRlcmF0aW9uIHdp bGwgYmUgY2FsbGVkLAogICAgICB1bmxlc3MgcmV0dmFsIGlzIHplcm8uICAqLwotI2lmZGVmIFVT RV9HVEsKICAgbmVlZF90b19kaXNwYXRjaCA9IHJldHZhbCA9PSAwOwotI2Vsc2UKLSAgbmVlZF90 b19kaXNwYXRjaCA9IHRydWU7Ci0jZW5kaWYKIAogICAvKiB4d2lkZ2V0cyBtYWtlIGhlYXZ5IHVz ZSBvZiBHTGliIHN1YnByb2Nlc3Nlcywgd2hpY2ggYWRkIHRoZWlyIG93bgogICAgICBTSUdDSExE IGhhbmRsZXIgYXQgYXJiaXRyYXJ5IGxvY2F0aW9ucy4gIFRoYXQgZG9lc24ndCBwbGF5IHdlbGwK LS0gCjIuMzUuMQoK --000000000000de4b4305e37e9c30--