From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Tom Gillespie Newsgroups: gmane.emacs.bugs Subject: bug#56002: src/process.c; make-process fails to clean up stderr process on early exit Date: Sun, 7 Aug 2022 16:48:44 -0700 Message-ID: References: <83pmj9qjgk.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="000000000000b27eab05e5af57ca" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="39748"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 56002@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Aug 08 02:03:10 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oKqEf-000A5s-Ox for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 08 Aug 2022 02:03:09 +0200 Original-Received: from localhost ([::1]:43888 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oKqEd-0001LN-Iu for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 07 Aug 2022 20:03:07 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:39488) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oKq1y-0006q8-M2 for bug-gnu-emacs@gnu.org; Sun, 07 Aug 2022 19:50:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:48809) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oKq1y-0001hO-Be for bug-gnu-emacs@gnu.org; Sun, 07 Aug 2022 19:50:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oKq1y-0001J7-41 for bug-gnu-emacs@gnu.org; Sun, 07 Aug 2022 19:50:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Tom Gillespie Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 07 Aug 2022 23:50:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 56002 X-GNU-PR-Package: emacs Original-Received: via spool by 56002-submit@debbugs.gnu.org id=B56002.16599161474957 (code B ref 56002); Sun, 07 Aug 2022 23:50:02 +0000 Original-Received: (at 56002) by debbugs.gnu.org; 7 Aug 2022 23:49:07 +0000 Original-Received: from localhost ([127.0.0.1]:38558 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oKq15-0001Hs-3E for submit@debbugs.gnu.org; Sun, 07 Aug 2022 19:49:07 -0400 Original-Received: from mail-pj1-f50.google.com ([209.85.216.50]:37407) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oKq11-0001HM-1S for 56002@debbugs.gnu.org; Sun, 07 Aug 2022 19:49:05 -0400 Original-Received: by mail-pj1-f50.google.com with SMTP id w11-20020a17090a380b00b001f73f75a1feso2107588pjb.2 for <56002@debbugs.gnu.org>; Sun, 07 Aug 2022 16:49:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc; bh=wBJWB+jVLf+Sf/a7Ga4Z6PgH1SJgcBiI6KpxYvOdKCQ=; b=LcC1+w8bzZmyXNAm08JP11mjupeeQLEjLB2kGQ54telZc5uDMmK7C8okF0ieLsv3s0 /dJDKyZgyucjDiYyL8NEP2TXZJ180oN2DcWIZDnyv/Xq/rH+qZ/otcQ8Pgdnpc0Oqvi0 pI3ZQBR0CfCD/NtPdCOQTrQmVBvPI2eGNG4GSTrfHR+ZHrPi9SIJKM5g1nESRODqPaMq laRnqEfrIJPKTfN1oDBFoXCz9I8VZBaJ6i2dBhLNZp4VWr+mnTRSkrbZKwV+nIm9ioFU 303uTOClD0CbNl1CvyHUVqcJmONpxU2JVtGbWVMiW546A5pT9hm/b34dWuBe1QFVCO/t yyAQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc; bh=wBJWB+jVLf+Sf/a7Ga4Z6PgH1SJgcBiI6KpxYvOdKCQ=; b=NFlqgWyJfwFeBkgK+M7Ikg4MyjdflIH4nwl1lSk1IF13coMgPyIABhk4pcI3lSj2g0 ZBU6qgLbjv+Do5FoWAiOYee/kvBct3gf31RVfYRoSLKHTcC/C1RoJ1tV6lE+YSb6YYf9 Jhq5s97vZ79CblIEfU3R6jS1f6IxlTLJABZTUtIfTFOkgjBbm0KWlVQTdM58UcmWHvJg HuAd9lJMA908EwASPOVtA85kyEwLP2aIfQx24EN7PXUpDwdSBubvmC0TzyGzWlplglrV EVhFCCr4dD8n4CWnxgn7qpfnneA25HqnwAVKUIMSLQwn60J7J0BY4kXCjpRR4nhcevxg c85w== X-Gm-Message-State: ACgBeo2St2sg4QyN5Yz2DVCrRrCfw7uZx/rSzLRK498qNc2A0iIlvC4O GZWHsjrC1mjOv0iWgvnCza/9+RWCaduert0z398= X-Google-Smtp-Source: AA6agR43ydRuaSG1uH9IpuuoGKd1oVTHxTosevgycjx3oaLExzUEY5m62/nryg5CdAspbGBTP8WSAsu2AGZWPw4xDpc= X-Received: by 2002:a17:903:2c6:b0:16d:d2c2:9939 with SMTP id s6-20020a17090302c600b0016dd2c29939mr16364765plk.42.1659916136887; Sun, 07 Aug 2022 16:48:56 -0700 (PDT) In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:239091 Archived-At: --000000000000b27eab05e5af57ca Content-Type: text/plain; charset="UTF-8" Here is an update to the 0002 patch to account for recent changes. --000000000000b27eab05e5af57ca Content-Type: text/x-patch; charset="US-ASCII"; name="0002-make-process-stderrproc-cleanup-on-failure-decouple-v2.patch" Content-Disposition: attachment; filename="0002-make-process-stderrproc-cleanup-on-failure-decouple-v2.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_l6jz76050 RnJvbSBmODgzMDA0NTE4N2QyOGM5MGVlNjE2N2VhZmM3OWEwMDE5YzQxYWI3IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBUb20gR2lsbGVzcGllIDx0Z2J1Z3NAZ21haWwuY29tPgpEYXRl OiBTdW4sIDcgQXVnIDIwMjIgMTY6NDM6MTMgLTA3MDAKU3ViamVjdDogW1BBVENIXSBtYWtlLXBy b2Nlc3Mgc3RkZXJycHJvYyBjbGVhbnVwIG9uIGZhaWx1cmUgZGVjb3VwbGUgc3RkZXJyCiBxdWVy eQoKKiBzcmMvcHJvY2Vzcy5jIChGbWFrZV9wcm9jZXNzKTogTW92ZSB0aGUgY2FsbCB0byBjcmVh dGUgdGhlIHN0ZGVycgpwcm9jZXNzIGFzIGxhdGUgYXMgcG9zc2libGUgdG8gYXZvaWQgaGF2aW5n IHRvIGNsZWFuIHVwIHN0ZGVycnByb2MgaW4KdGhlIGV2ZW50IG9mIGFuIGVycm9yIHByaW9yIHRv IHRoZSBjYWxsIHRvIGNyZWF0ZV9wcm9jZXNzLiBUaGlzIGNoYW5nZQppcyBuZWVkZWQgdG8gZW5z dXJlIHRoYXQgd2hlbiBjYWxsZWQgd2l0aCA6cXVlcnktc3RkZXJyIHQgKGFrYSB0aGUKZGVmYXVs dCBiZWhhdmlvciBwcmlvciB0byB0aGUgYWRkaXRpb24gb2YgOnF1ZXJ5LXN0ZGVycikgbWFrZS1w cm9jZXNzCndpbGwgbm90IGxlYWsgdGhlIHN0ZGVyciBwcm9jZXNzIGlmIGEgY2FsbCB0byBtYWtl LXByb2Nlc3MgZmFpbHMuCkFsc28gYWRkcyBhIG5ldyBrZXl3b3JkIGFyZ3VtZW50IDpxdWVyeS1z dGRlcnIgdG8gY29udHJvbCB3aGV0aGVyIHRvCnF1ZXJ5IG9uIGV4aXQgdGhlIHN0ZGVyciBwcm9j ZXNzIChpZiBvbmUgaXMgY3JlYXRlZCkuIChidWcjNTYwMDIpCgpOb3cgd2l0aCBjaGFuZ2VzIHRv IGFjY291bnQgZm9yIGludGVydmVuaW5nIGNoYW5nZXMgdG8gcHR5IGNvZGUuCi0tLQogc3JjL3By b2Nlc3MuYyB8IDQ1ICsrKysrKysrKysrKysrKysrKysrKysrKysrKystLS0tLS0tLS0tLS0tLS0t LQogMSBmaWxlIGNoYW5nZWQsIDI4IGluc2VydGlvbnMoKyksIDE3IGRlbGV0aW9ucygtKQoKZGlm ZiAtLWdpdCBhL3NyYy9wcm9jZXNzLmMgYi9zcmMvcHJvY2Vzcy5jCmluZGV4IDIzNDc5YzA2MTku LjExZjg1YzVkMWQgMTAwNjQ0Ci0tLSBhL3NyYy9wcm9jZXNzLmMKKysrIGIvc3JjL3Byb2Nlc3Mu YwpAQCAtMTc2Miw2ICsxNzYyLDExIEBAIERFRlVOICgibWFrZS1wcm9jZXNzIiwgRm1ha2VfcHJv Y2VzcywgU21ha2VfcHJvY2VzcywgMCwgTUFOWSwgMCwKIDpub3F1ZXJ5IEJPT0wgLS0gV2hlbiBl eGl0aW5nIEVtYWNzLCBxdWVyeSB0aGUgdXNlciBpZiBCT09MIGlzIG5pbCBhbmQKIHRoZSBwcm9j ZXNzIGlzIHJ1bm5pbmcuICBJZiBCT09MIGlzIG5vdCBnaXZlbiwgcXVlcnkgYmVmb3JlIGV4aXRp bmcuCiAKKzpxdWVyeS1zdGRlcnIgQk9PTCAtLSBXaGVuIGV4aXRpbmcgRW1hY3MsIHF1ZXJ5IHRo ZSB1c2VyIGlmIEJPT0wgaXMKK25vbi1uaWwgYW5kIHRoZSBzdGRlcnIgcHJvY2VzcyBpcyBydW5u aW5nLiBJZiBCT09MIGlzIG5vdCBnaXZlbiwgZG8KK25vdCBxdWVyeSBiZWZvcmUgZXhpdGluZy4g VGhpcyBoYXMgbm8gZWZmZWN0IGlmIHRoZSB2YWx1ZSBwYXNzZWQgdG8KKzpzdGRlcnIgaXMgYSBw cm9jZXNzLgorCiA6c3RvcCBCT09MIC0tIEJPT0wgbXVzdCBiZSBuaWwuICBUaGUgYDpzdG9wJyBr ZXkgaXMgaWdub3JlZCBvdGhlcndpc2UKIGFuZCBpcyByZXRhaW5lZCBmb3IgY29tcGF0aWJpbGl0 eSB3aXRoIG90aGVyIHByb2Nlc3MgdHlwZXMgc3VjaCBhcwogcGlwZSBwcm9jZXNzZXMuICBBc3lu Y2hyb25vdXMgc3VicHJvY2Vzc2VzIG5ldmVyIHN0YXJ0IGluIHRoZQpAQCAtMTgzNyw4ICsxODQy LDYgQEAgREVGVU4gKCJtYWtlLXByb2Nlc3MiLCBGbWFrZV9wcm9jZXNzLCBTbWFrZV9wcm9jZXNz LCAwLCBNQU5ZLCAwLAogICBpZiAoIU5JTFAgKHByb2dyYW0pKQogICAgIENIRUNLX1NUUklORyAo cHJvZ3JhbSk7CiAKLSAgYm9vbCBxdWVyeV9vbl9leGl0ID0gTklMUCAocGxpc3RfZ2V0IChjb250 YWN0LCBRQ25vcXVlcnkpKTsKLQogICBzdGRlcnJwcm9jID0gUW5pbDsKICAgeHN0ZGVyciA9IHBs aXN0X2dldCAoY29udGFjdCwgUUNzdGRlcnIpOwogICBpZiAoUFJPQ0VTU1AgKHhzdGRlcnIpKQpA QCAtMTg0OCwxNiArMTg1MSw3IEBAIERFRlVOICgibWFrZS1wcm9jZXNzIiwgRm1ha2VfcHJvY2Vz cywgU21ha2VfcHJvY2VzcywgMCwgTUFOWSwgMCwKICAgICAgIHN0ZGVycnByb2MgPSB4c3RkZXJy OwogICAgIH0KICAgZWxzZSBpZiAoIU5JTFAgKHhzdGRlcnIpKQotICAgIHsKLSAgICAgIENIRUNL X1NUUklORyAocHJvZ3JhbSk7Ci0gICAgICBzdGRlcnJwcm9jID0gQ0FMTE4gKEZtYWtlX3BpcGVf cHJvY2VzcywKLQkJCSAgUUNuYW1lLAotCQkJICBjb25jYXQyIChuYW1lLCBidWlsZF9zdHJpbmcg KCIgc3RkZXJyIikpLAotCQkJICBRQ2J1ZmZlciwKLQkJCSAgRmdldF9idWZmZXJfY3JlYXRlICh4 c3RkZXJyLCBRbmlsKSwKLQkJCSAgUUNub3F1ZXJ5LAotCQkJICBxdWVyeV9vbl9leGl0ID8gUW5p bCA6IFF0KTsKLSAgICB9CisgICAgQ0hFQ0tfU1RSSU5HIChwcm9ncmFtKTsKIAogICBwcm9jID0g bWFrZV9wcm9jZXNzIChuYW1lKTsKICAgcmVjb3JkX3Vud2luZF9wcm90ZWN0IChzdGFydF9wcm9j ZXNzX3Vud2luZCwgcHJvYyk7CkBAIC0xODcwLDcgKzE4NjQsNyBAQCBERUZVTiAoIm1ha2UtcHJv Y2VzcyIsIEZtYWtlX3Byb2Nlc3MsIFNtYWtlX3Byb2Nlc3MsIDAsIE1BTlksIDAsCiAgIHBzZXRf ZmlsdGVyIChYUFJPQ0VTUyAocHJvYyksIHBsaXN0X2dldCAoY29udGFjdCwgUUNmaWx0ZXIpKTsK ICAgcHNldF9jb21tYW5kIChYUFJPQ0VTUyAocHJvYyksIEZjb3B5X3NlcXVlbmNlIChjb21tYW5k KSk7CiAKLSAgaWYgKCFxdWVyeV9vbl9leGl0KQorICBpZiAoIU5JTFAgKHBsaXN0X2dldCAoY29u dGFjdCwgUUNub3F1ZXJ5KSkpCiAgICAgWFBST0NFU1MgKHByb2MpLT5raWxsX3dpdGhvdXRfcXVl cnkgPSAxOwogICB0ZW0gPSBwbGlzdF9nZXQgKGNvbnRhY3QsIFFDc3RvcCk7CiAgIC8qIE5vcm1h bCBwcm9jZXNzZXMgY2FuJ3QgYmUgc3RhcnRlZCBpbiBhIHN0b3BwZWQgc3RhdGUsIHNlZQpAQCAt MTg4OSw5ICsxODgzLDYgQEAgREVGVU4gKCJtYWtlLXByb2Nlc3MiLCBGbWFrZV9wcm9jZXNzLCBT bWFrZV9wcm9jZXNzLCAwLCBNQU5ZLCAwLAogCWlzX3B0eV9mcm9tX3N5bWJvbCAodGVtKTsKICAg ICB9CiAKLSAgaWYgKCFOSUxQIChzdGRlcnJwcm9jKSkKLSAgICBwc2V0X3N0ZGVycnByb2MgKFhQ Uk9DRVNTIChwcm9jKSwgc3RkZXJycHJvYyk7Ci0KICNpZmRlZiBIQVZFX0dOVVRMUwogICAvKiBB S0EgR05VVExTX0lOSVRTVEFHRShwcm9jKS4gICovCiAgIHZlcmlmeSAoR05VVExTX1NUQUdFX0VN UFRZID09IDApOwpAQCAtMjA1NywxMCArMjA0OCwyOSBAQCBERUZVTiAoIm1ha2UtcHJvY2VzcyIs IEZtYWtlX3Byb2Nlc3MsIFNtYWtlX3Byb2Nlc3MsIDAsIE1BTlksIDAsCiAJICB0ZW0gPSBYQ0RS ICh0ZW0pOwogCX0KIAorICAgICAgaWYgKCFQUk9DRVNTUCAoeHN0ZGVycikgJiYgIU5JTFAgKHhz dGRlcnIpKQorCXsKKwkgIHN0ZGVycnByb2MgPSBDQUxMTiAoRm1ha2VfcGlwZV9wcm9jZXNzLAor CQkJICAgICAgUUNuYW1lLAorCQkJICAgICAgY29uY2F0MiAobmFtZSwgYnVpbGRfc3RyaW5nICgi IHN0ZGVyciIpKSwKKwkJCSAgICAgIFFDYnVmZmVyLAorCQkJICAgICAgRmdldF9idWZmZXJfY3Jl YXRlICh4c3RkZXJyLCBRbmlsKSwKKwkJCSAgICAgIFFDbm9xdWVyeSwKKwkJCSAgICAgIE5JTFAg KHBsaXN0X2dldCAoY29udGFjdCwgUUNxdWVyeV9zdGRlcnIpKSA/IFF0IDogUW5pbCk7CisJfQor CisgICAgICBpZiAoIU5JTFAgKHN0ZGVycnByb2MpKQorCXBzZXRfc3RkZXJycHJvYyAoWFBST0NF U1MgKHByb2MpLCBzdGRlcnJwcm9jKTsKKwogICAgICAgY3JlYXRlX3Byb2Nlc3MgKHByb2MsIG5l d19hcmd2LCBjdXJyZW50X2Rpcik7CiAgICAgfQogICBlbHNlCi0gICAgY3JlYXRlX3B0eSAocHJv Yyk7CisgICAgeworICAgICAgaWYgKCFOSUxQIChzdGRlcnJwcm9jKSkKKwlwc2V0X3N0ZGVycnBy b2MgKFhQUk9DRVNTIChwcm9jKSwgc3RkZXJycHJvYyk7CisKKyAgICAgIGNyZWF0ZV9wdHkgKHBy b2MpOworICAgIH0KIAogICByZXR1cm4gU0FGRV9GUkVFX1VOQklORF9UTyAoY291bnQsIHByb2Mp OwogfQpAQCAtODYwOSw2ICs4NjE5LDcgQEAgc3ltc19vZl9wcm9jZXNzICh2b2lkKQogICBERUZT WU0gKFFuc21fdmVyaWZ5X2Nvbm5lY3Rpb24sICJuc20tdmVyaWZ5LWNvbm5lY3Rpb24iKTsKICAg REVGU1lNIChRQ2xvZywgIjpsb2ciKTsKICAgREVGU1lNIChRQ25vcXVlcnksICI6bm9xdWVyeSIp OworICBERUZTWU0gKFFDcXVlcnlfc3RkZXJyLCAiOnF1ZXJ5LXN0ZGVyciIpOwogICBERUZTWU0g KFFDc3RvcCwgIjpzdG9wIik7CiAgIERFRlNZTSAoUUNwbGlzdCwgIjpwbGlzdCIpOwogICBERUZT WU0gKFFDY29tbWFuZCwgIjpjb21tYW5kIik7Ci0tIAoyLjM1LjEKCg== --000000000000b27eab05e5af57ca--