From: Tom Gillespie <tgbugs@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 56002@debbugs.gnu.org
Subject: bug#56002: src/process.c; make-process fails to clean up stderr process on early exit
Date: Wed, 15 Jun 2022 23:11:50 -0700 [thread overview]
Message-ID: <CA+G3_PNnJ2akU9D2i3CGeYg=p56wzuy-gtzEGTk6kzmYrQyd6A@mail.gmail.com> (raw)
In-Reply-To: <83pmj9qjgk.fsf@gnu.org>
> Can you elaborate on what do you mean by "clean up the stderr
> process"? Do you see the code which does that in the "normal" cases?
I'm not entirely sure as I am unfamiliar with the life cycle for processes in
the runtime. I think that the "normal" cleanup happens when the parent
process exits with a return code. The stderr process is a pipe process so
I assume that under normal circumstances the pipe process would receive
a signal from the primary process via the os and exit allowing calls to
accept-process-output to complete and then presumably the gc would
take care of the rest? I have no idea if this is remotely accurate.
It does look like remote_process is called during other failures though.
> Sounds like we lack some unwind-protect call somewhere?
It does look like there are a number of calls to record_unwind_protect
(remove_process, proc); in the code. Maybe there is a missing
record_unwind_protect (remove_process, stderrproc); in make-process?
next prev parent reply other threads:[~2022-06-16 6:11 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-15 22:38 bug#56002: src/process.c; make-process fails to clean up stderr process on early exit Tom Gillespie
2022-06-16 2:28 ` bug#56002: update with an additional example Tom Gillespie
2022-06-16 5:13 ` bug#56002: src/process.c; make-process fails to clean up stderr process on early exit Eli Zaretskii
2022-06-16 6:11 ` Tom Gillespie [this message]
2022-06-29 21:17 ` Tom Gillespie
2022-08-07 23:48 ` Tom Gillespie
2022-08-08 11:36 ` Lars Ingebrigtsen
2022-08-08 11:57 ` Eli Zaretskii
2022-08-08 18:54 ` Tom Gillespie
2022-08-09 11:43 ` Eli Zaretskii
2022-08-09 18:59 ` Tom Gillespie
2022-08-10 18:06 ` Eli Zaretskii
2022-08-11 2:33 ` Tom Gillespie
2022-08-11 6:30 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CA+G3_PNnJ2akU9D2i3CGeYg=p56wzuy-gtzEGTk6kzmYrQyd6A@mail.gmail.com' \
--to=tgbugs@gmail.com \
--cc=56002@debbugs.gnu.org \
--cc=eliz@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).