From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Fritz Stelzer Newsgroups: gmane.emacs.bugs Subject: bug#27557: 26.0.50: patch org-edit-src-code Date: Sun, 2 Jul 2017 12:53:10 +0200 Message-ID: NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="001a1140932ad143a10553537459" X-Trace: blaine.gmane.org 1499041875 26598 195.159.176.226 (3 Jul 2017 00:31:15 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 3 Jul 2017 00:31:15 +0000 (UTC) To: 27557@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Jul 03 02:31:07 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dRpGc-0006SM-M7 for geb-bug-gnu-emacs@m.gmane.org; Mon, 03 Jul 2017 02:31:06 +0200 Original-Received: from localhost ([::1]:59806 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dRpGh-0003Zx-QE for geb-bug-gnu-emacs@m.gmane.org; Sun, 02 Jul 2017 20:31:11 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:36432) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dRpGa-0003ZX-5q for bug-gnu-emacs@gnu.org; Sun, 02 Jul 2017 20:31:05 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dRpGZ-0006R9-23 for bug-gnu-emacs@gnu.org; Sun, 02 Jul 2017 20:31:04 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:46575) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dRpGY-0006QX-Sg for bug-gnu-emacs@gnu.org; Sun, 02 Jul 2017 20:31:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dRpGY-0004p3-D2 for bug-gnu-emacs@gnu.org; Sun, 02 Jul 2017 20:31:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Fritz Stelzer Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 03 Jul 2017 00:31:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 27557 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.149904183318494 (code B ref -1); Mon, 03 Jul 2017 00:31:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 3 Jul 2017 00:30:33 +0000 Original-Received: from localhost ([127.0.0.1]:49252 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dRpG5-0004oE-DH for submit@debbugs.gnu.org; Sun, 02 Jul 2017 20:30:33 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:43000) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dRcVG-0005u2-Ki for submit@debbugs.gnu.org; Sun, 02 Jul 2017 06:53:23 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dRcVA-0004AK-Du for submit@debbugs.gnu.org; Sun, 02 Jul 2017 06:53:17 -0400 Original-Received: from lists.gnu.org ([2001:4830:134:3::11]:54344) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dRcVA-0004AB-AF for submit@debbugs.gnu.org; Sun, 02 Jul 2017 06:53:16 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:33962) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dRcV8-0001T6-Ru for bug-gnu-emacs@gnu.org; Sun, 02 Jul 2017 06:53:15 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dRcV7-00049F-Up for bug-gnu-emacs@gnu.org; Sun, 02 Jul 2017 06:53:14 -0400 Original-Received: from mail-yw0-x234.google.com ([2607:f8b0:4002:c05::234]:33829) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dRcV7-00047F-Nr for bug-gnu-emacs@gnu.org; Sun, 02 Jul 2017 06:53:13 -0400 Original-Received: by mail-yw0-x234.google.com with SMTP id l21so53966127ywb.1 for ; Sun, 02 Jul 2017 03:53:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to; bh=hUmEncWJxjZrKx/9qsGwNAu8jFpnt0EmIbfMMRVgsXc=; b=DlQO0SbFavyBDhu5OzIqnBsXJUG1JjuYACYWC+i6VjPXmpa58mkR0VxbzK9vYguJtf Gt9mII4Dr1NWB+LPSAO+0/6lTaQ3GUpVwmh5JjdvgQavhQ2XMPWSLH/liv9hrZfWAYR8 vFXZu856jp2XpikSH3lLj8qlT3EWcpUOCguYPEPfZQlE6cUHW+tOCglMzWM75DX/lMd6 BHEQAZkgB12+MVXKxL+zmQphf5zFmQRfgkxO7tmvlC3skxUGfh3vMtifO7Iw80SBeHi7 5Ts3zCRbtxoZIXXPHO/B2hcIO1cl/8r6bFS4H+1ac85lqcP0IJlHBWFAl9JSp9THl1Jo Ew7g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=hUmEncWJxjZrKx/9qsGwNAu8jFpnt0EmIbfMMRVgsXc=; b=AjRaB3YcneLu4DK3jdRzQO0eiYKsuVgqrFNj5ae0qFkqKIZS36U5B943iKHt1ObF/+ vuIW51TGISEX05/XTEigxf2JfYrP2qWqmvBuCstXLPCntZtrEIzYPVBfz2AHYhFC/fZo nTmd2DA1ZE6wOukGqKSSWb/ko4EG0IYqBASIZM0wOIyifnx/S/f297lZ12Cjxrf37q0N ApB7s0bTux/T+kWGynbnh6LrAfj8g2l5TQ6VA0xzG9cJ0g0Yz3yD8qgYuMKPW+Z9xOql MsCUhyJJH5AGpHSgZ6oMeHUsBLJYsaGkKrJfswuwaTaqjYCaDowiorzHQJA+FsP+MuJi ZYmw== X-Gm-Message-State: AKS2vOzKK7D9Wui3wab99qRl1zR1XrZE8pGE8Zyh5qXNk87Wa877oRf5 HcVvZZ2la/dBzoMy9yZaCgI51B0+FeFP X-Received: by 10.129.50.140 with SMTP id y134mr22562451ywy.312.1498992790814; Sun, 02 Jul 2017 03:53:10 -0700 (PDT) Original-Received: by 10.129.131.71 with HTTP; Sun, 2 Jul 2017 03:53:10 -0700 (PDT) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Mailman-Approved-At: Sun, 02 Jul 2017 20:30:32 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:134108 Archived-At: --001a1140932ad143a10553537459 Content-Type: text/plain; charset="UTF-8" When I use "org-edit-special" in an org babel block, I get this traceback: Debugger entered--Lisp error: (wrong-type-argument listp t) delete((org-filtered) t) remove((org-filtered) t) org-move-to-column(5) org-edit-src-code() org-edit-special(nil) funcall-interactively(org-edit-special nil) call-interactively(org-edit-special record nil) command-execute(org-edit-special record) execute-extended-command(nil "org-edit-special" "org-edit-sp") funcall-interactively(execute-extended-command nil "org-edit-special" "org-edit-sp") call-interactively(execute-extended-command nil nil) command-execute(execute-extended-command) The reason for this seems to be a rewrite of the c function "delete", that does not accept "t" instead of a list anymore. I guess it was done for a reason. I think "org-move-to-column" causes the problem as it is called in org-src buffers. I tried "org-move-to-column" in an org buffer and it seems to work. My solution would be to use "move-to-column" instead: master ff87c8da24b40399f18f1c4c6fcab601287683ae Author: brotzeit AuthorDate: Sun Jul 2 12:44:53 2017 +0200 Commit: brotzeit CommitDate: Sun Jul 2 12:44:53 2017 +0200 Parent: 9a2a7bb6e6 Let test summary go through even if some logs were not generated Merged: master Containing: master Follows: emacs-25.1 (129272) use move-to-column in source block editing buffer modified lisp/org/org-src.el @@ -356,13 +356,13 @@ org-edit-src-code (org-unescape-code-in-region (point-min) (point-max)) (when markline (org-goto-line (1+ (- markline begline))) - (org-move-to-column + (move-to-column (if org-src-preserve-indentation markcol (max 0 (- markcol total-nindent)))) (push-mark (point) 'no-message t) (setq deactivate-mark nil)) (org-goto-line (1+ (- line begline))) - (org-move-to-column + (move-to-column (if org-src-preserve-indentation col (max 0 (- col total-nindent)))) (org-src-mode) (set-buffer-modified-p nil) --001a1140932ad143a10553537459 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

When I use "org-edit-special" in an org babe= l block, I get this traceback:

Debugger entered--Lisp error: (wrong-= type-argument listp t)
=C2=A0 delete((org-filtered) t)
=C2=A0 remove(= (org-filtered) t)
=C2=A0 org-move-to-column(5)
=C2=A0 org-edit-src-co= de()
=C2=A0 org-edit-special(nil)
=C2=A0 funcall-interactively(org-ed= it-special nil)
=C2=A0 call-interactively(org-edit-special record nil)=C2=A0 command-execute(org-edit-special record)
=C2=A0 execute-extende= d-command(nil "org-edit-special" "org-edit-sp")
=C2= =A0 funcall-interactively(execute-extended-command nil "org-edit-speci= al" "org-edit-sp")
=C2=A0 call-interactively(execute-exte= nded-command nil nil)
=C2=A0 command-execute(execute-extended-command)

The reason for this seems to be a rewrite of the c function "= ;delete", that does not accept "t" instead of a list anymore= . I guess it was done for a reason.
I think "org-move-to-column&quo= t; causes the problem as it is called in org-src buffers. I tried "org= -move-to-column" in an org buffer and it seems to work.


My solution would be to use "move-to-column" instead:

master ff87c8da24b40399f18f1c4c6fcab601287683ae
Author:=C2=A0=C2=A0=C2= =A0=C2=A0 brotzeit <brotzeit= macher@gmail.com>
AuthorDate: Sun Jul 2 12:44:53 2017 +0200
Co= mmit:=C2=A0=C2=A0=C2=A0=C2=A0 brotzeit <brotzeitmacher@gmail.com>
CommitDate: Sun Jul 2 12:44= :53 2017 +0200

Parent:=C2=A0=C2=A0=C2=A0=C2=A0 9a2a7bb6e6 Let test s= ummary go through even if some logs were not generated
Merged:=C2=A0=C2= =A0=C2=A0=C2=A0 master
Containing: master
Follows:=C2=A0=C2=A0=C2=A0 = emacs-25.1 (129272)

use move-to-column in source block editing buffe= r

modified=C2=A0=C2=A0 lisp/org/org-src.el
@@ -356,13 +356,13 @@ = org-edit-src-code
=C2=A0=C2=A0=C2=A0=C2=A0 (org-unescape-code-in-region = (point-min) (point-max))
=C2=A0=C2=A0=C2=A0=C2=A0 (when markline
=C2= =A0=C2=A0=C2=A0=C2=A0 =C2=A0 (org-goto-line (1+ (- markline begline)))
-= =C2=A0=C2=A0=C2=A0 =C2=A0 (org-move-to-column
+=C2=A0=C2=A0=C2=A0 =C2=A0= (move-to-column
=C2=A0=C2=A0=C2=A0=C2=A0 =C2=A0=C2=A0 (if org-src-prese= rve-indentation markcol
=C2=A0=C2=A0=C2=A0=C2=A0 =C2=A0=C2=A0=C2=A0=C2= =A0 (max 0 (- markcol total-nindent))))
=C2=A0=C2=A0=C2=A0=C2=A0 =C2=A0 = (push-mark (point) 'no-message t)
=C2=A0=C2=A0=C2=A0=C2=A0 =C2=A0 (s= etq deactivate-mark nil))
=C2=A0=C2=A0=C2=A0=C2=A0 (org-goto-line (1+ (-= line begline)))
-=C2=A0=C2=A0=C2=A0 (org-move-to-column
+=C2=A0=C2= =A0=C2=A0 (move-to-column
=C2=A0=C2=A0=C2=A0=C2=A0 =C2=A0(if org-src-pre= serve-indentation col (max 0 (- col total-nindent))))
=C2=A0=C2=A0=C2=A0= =C2=A0 (org-src-mode)
=C2=A0=C2=A0=C2=A0=C2=A0 (set-buffer-modified-p ni= l)
--001a1140932ad143a10553537459--