unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Fritz Stelzer <brotzeitmacher@gmail.com>
To: 27557@debbugs.gnu.org
Subject: bug#27557: 26.0.50: patch org-edit-src-code
Date: Sun, 2 Jul 2017 12:53:10 +0200	[thread overview]
Message-ID: <CA+CiP9DcCRh95X-6zDAa_3TMfh6Lj5_0hemducbxDhAZESNguA@mail.gmail.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 2095 bytes --]

When I use "org-edit-special" in an org babel block, I get this traceback:

Debugger entered--Lisp error: (wrong-type-argument listp t)
  delete((org-filtered) t)
  remove((org-filtered) t)
  org-move-to-column(5)
  org-edit-src-code()
  org-edit-special(nil)
  funcall-interactively(org-edit-special nil)
  call-interactively(org-edit-special record nil)
  command-execute(org-edit-special record)
  execute-extended-command(nil "org-edit-special" "org-edit-sp")
  funcall-interactively(execute-extended-command nil "org-edit-special"
"org-edit-sp")
  call-interactively(execute-extended-command nil nil)
  command-execute(execute-extended-command)


The reason for this seems to be a rewrite of the c function "delete", that
does not accept "t" instead of a list anymore. I guess it was done for a
reason.
I think "org-move-to-column" causes the problem as it is called in org-src
buffers. I tried "org-move-to-column" in an org buffer and it seems to work.



My solution would be to use "move-to-column" instead:


master ff87c8da24b40399f18f1c4c6fcab601287683ae
Author:     brotzeit <brotzeitmacher@gmail.com>
AuthorDate: Sun Jul 2 12:44:53 2017 +0200
Commit:     brotzeit <brotzeitmacher@gmail.com>
CommitDate: Sun Jul 2 12:44:53 2017 +0200

Parent:     9a2a7bb6e6 Let test summary go through even if some logs were
not generated
Merged:     master
Containing: master
Follows:    emacs-25.1 (129272)

use move-to-column in source block editing buffer

modified   lisp/org/org-src.el
@@ -356,13 +356,13 @@ org-edit-src-code
     (org-unescape-code-in-region (point-min) (point-max))
     (when markline
       (org-goto-line (1+ (- markline begline)))
-      (org-move-to-column
+      (move-to-column
        (if org-src-preserve-indentation markcol
          (max 0 (- markcol total-nindent))))
       (push-mark (point) 'no-message t)
       (setq deactivate-mark nil))
     (org-goto-line (1+ (- line begline)))
-    (org-move-to-column
+    (move-to-column
      (if org-src-preserve-indentation col (max 0 (- col total-nindent))))
     (org-src-mode)
     (set-buffer-modified-p nil)

[-- Attachment #2: Type: text/html, Size: 2596 bytes --]

             reply	other threads:[~2017-07-02 10:53 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-02 10:53 Fritz Stelzer [this message]
2017-07-03 12:46 ` bug#27557: 26.0.50: patch org-edit-src-code npostavs

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CA+CiP9DcCRh95X-6zDAa_3TMfh6Lj5_0hemducbxDhAZESNguA@mail.gmail.com \
    --to=brotzeitmacher@gmail.com \
    --cc=27557@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).