From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: James Youngman Newsgroups: gmane.emacs.bugs Subject: bug#8754: submission of vimvars Date: Wed, 6 Jul 2011 15:22:33 +0100 Message-ID: References: NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-Trace: dough.gmane.org 1309963275 31748 80.91.229.12 (6 Jul 2011 14:41:15 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Wed, 6 Jul 2011 14:41:15 +0000 (UTC) Cc: 8754@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Jul 06 16:41:10 2011 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1QeTHn-0002iz-8m for geb-bug-gnu-emacs@m.gmane.org; Wed, 06 Jul 2011 16:41:07 +0200 Original-Received: from localhost ([::1]:44165 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QeTHm-0004fZ-Fm for geb-bug-gnu-emacs@m.gmane.org; Wed, 06 Jul 2011 10:41:06 -0400 Original-Received: from eggs.gnu.org ([140.186.70.92]:39093) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QeT1J-0000Yp-3y for bug-gnu-emacs@gnu.org; Wed, 06 Jul 2011 10:24:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QeT1H-00028j-C1 for bug-gnu-emacs@gnu.org; Wed, 06 Jul 2011 10:24:04 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:33074) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QeT1G-00028b-Ra for bug-gnu-emacs@gnu.org; Wed, 06 Jul 2011 10:24:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1QeT1G-0008QO-EW; Wed, 06 Jul 2011 10:24:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: James Youngman Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 06 Jul 2011 14:24:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 8754 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 8754-submit@debbugs.gnu.org id=B8754.130996218832302 (code B ref 8754); Wed, 06 Jul 2011 14:24:02 +0000 Original-Received: (at 8754) by debbugs.gnu.org; 6 Jul 2011 14:23:08 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QeT0N-0008Ox-Uo for submit@debbugs.gnu.org; Wed, 06 Jul 2011 10:23:08 -0400 Original-Received: from smtp-out.google.com ([74.125.121.67]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QeT0I-0008OI-Rj for 8754@debbugs.gnu.org; Wed, 06 Jul 2011 10:23:06 -0400 Original-Received: from kpbe17.cbf.corp.google.com (kpbe17.cbf.corp.google.com [172.25.105.81]) by smtp-out.google.com with ESMTP id p66EMuRr031330 for <8754@debbugs.gnu.org>; Wed, 6 Jul 2011 07:22:56 -0700 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=google.com; s=beta; t=1309962177; bh=yORzw5ZQ3FJYnQkHNZFQZFOkmUM=; h=MIME-Version:In-Reply-To:References:From:Date:Message-ID:Subject: To:Cc:Content-Type:Content-Transfer-Encoding; b=BzKgijmVfXKjkT660rU4hnol+SBpXqnEfPXFUrFjs4S15emBUxMPeR4tYSKjBI7Iy zt+AnSbuH7cK9svi2CmNg== DomainKey-Signature: a=rsa-sha1; s=beta; d=google.com; c=nofws; q=dns; h=dkim-signature:mime-version:in-reply-to:references:from:date: message-id:subject:to:cc:content-type: content-transfer-encoding:x-system-of-record; b=SPLICTylySgYbpE+7txwItf2bNFgfiGyvH+JdrW+LsrfvCDgbj8LlmODdUFHXYlbi fl+hFEXL9ZfY85Nhvc4Sg== Original-Received: from ewy10 (ewy10.prod.google.com [10.241.103.10]) by kpbe17.cbf.corp.google.com with ESMTP id p66ELv2K031849 (version=TLSv1/SSLv3 cipher=RC4-SHA bits=128 verify=NOT) for <8754@debbugs.gnu.org>; Wed, 6 Jul 2011 07:22:54 -0700 Original-Received: by ewy10 with SMTP id 10so2702411ewy.37 for <8754@debbugs.gnu.org>; Wed, 06 Jul 2011 07:22:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=beta; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type:content-transfer-encoding; bh=U8AwCuFF+O7oC2tTYL6Pr4c+NLHoPQNztvTXg/yAUIA=; b=oN+1g9rbCQeEV0hKZdoSOjOquMhqOUBDbpuIJAIWEtvMGpmphvkCYC4NniDO2lpV0/ ZA1kHbEX8x4Cs6kwwEug== Original-Received: by 10.213.35.209 with SMTP id q17mr1953943ebd.76.1309962173196; Wed, 06 Jul 2011 07:22:53 -0700 (PDT) Original-Received: by 10.213.114.71 with HTTP; Wed, 6 Jul 2011 07:22:33 -0700 (PDT) In-Reply-To: X-System-Of-Record: true X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Wed, 06 Jul 2011 10:24:02 -0400 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:48075 Archived-At: On Wed, Jul 6, 2011 at 14:12, Stefan Monnier wro= te: > > > Sorry, I'm attaching the patch instead of sending it inline, contrary > > to the contribution guidelines, but I'll include the commit message > > inline. =A0Google already has an FSF copyright assignment for Emacs; > > fwiw, so do I. =A0 Feedback on the right place in the manual to documen= t > > this would be particularly welcome, since I wasn't certain which the > > optimal spot was. > > This looks like an interesting feature, thanks. > I think we should add it to the GNU ELPA, does that sound goo to you? I'm not opposed, but it is not my ideal choice for a small number of reason= s: 1. It interacts a bit with Emacs' own local variables in order to avoid surprising behaviour, and my guess was that it may make sense to put the code in the same repo as the code interpreting Emacs' own local variables. 2. I wanted to make sure this was adequately documented in the same place as the Emacs' various VI emulations, since people wanting to use a VI emulation stand a high chance of finding this useful too. > - There's some redundancy between vimvars-enabled and (memq > =A0'vimvars-obey-vim-modeline find-file-hook), I think the user should > =A0only have to use one of the two. I had to make some assumptions about user preferences, and I guessed that someone might want to leave vimvars-obey-vim-modeline in find-file-hook and yet disable vimvars for specific projects via .dir-locals.el. But I admit my thinking on this wasn't that exhaustive. > - if vimvars-enabled stays, it should be renamed vimvars-mode and be > =A0made into a minor-mode. > - vimvars-enabled being buffer-local seems odd. =A0What was the motivatio= n > =A0for it? > - if the user has to add vimvars-obey-vim-modeline to the hook, then add > =A0an autoload cookie before it so that the user does not need to > =A0(require 'vimvars). [ and some other code style changes, thanks for those, I'll incorporate the= m. ] > - next time someone adds support for shiftwidth in some other modes > =A0(e.g. by setting smie-basic-indent), he'll probably forget to update > =A0the doc, so better keep the doc less specific to the current limits. Good tip, thanks. > - (equal major-mode 'c-mode) =A0=3D> =A0(derived-mode-p 'c-mode). > - you set compile-command globally. Oops. Thanks for catching this. It turns out that makeprg cannot be set in vi in a modeline anyway (only in .vimrc) so that feature needs to be removed in any case. I'm pretty sure this is the only such case. > - if we add it to the GNU ELPA rather than to Emacs itself, then the doc > =A0needs to be moved to the Commentary section. > > > =A0 =A0 =A0 =A0Stefan -- Google Ireland Ltd., Gordon House, Barrow Street, Dublin 4, Ireland Registered in Dublin, Ireland.=A0 Registration Number: 368047 http://tinyurl.com/345mmx