bug#24959: 26.0.50; cancel-timer: void-variable timer

[Oleg Sivokon <oleg.sivokon@elastifile.com>]

Eli, Lars,

I know what the timer handler is. I'm not sure how to interpret the
backtrace then: did it or did it not enter the cancel-timer function?
I thought it did, and this is why I filed this ticket.

More background (this applies if the backtrace says that cancel-timer
was not entered):
The code in the handler relies on the code that sets up the timer to
create a special variable "timer". This variable is created by calling
setq (but no defvar). setq used to make variable special, if it wasn't
already let-bound. Now it seems like this behavior has changed. Does
this make sense?

On Thu, Nov 17, 2016 at 7:11 PM, Lars Ingebrigtsen <larsi@gnus.org> wrote:
> Oleg Sivokon <oleg.sivokon@elastifile.com> writes:
>
>> Debugger entered--Lisp error: (void-variable timer)
>>   (cancel-timer timer)
>>   (condition-case err (if (let* ((--cl-var-- buffs) (buf nil) (--cl-flag-- t) --cl-var--) (while (and (consp --cl-var--) (progn (setq buf (car --cl-var--)) (setq --cl-flag-- (not ...)))) (setq --cl-var-- (cdr --cl-var--))) --cl-var--) nil (let* ((--cl-var-- buffs) (buf nil) (container nil) (contents nil)) (while (consp --cl-var--) (setq buf (car --cl-var--)) (setq container (save-current-buffer (set-buffer buf) container)) (setq contents (save-current-buffer (set-buffer buf) (buffer-substring (point-min) (point-max)))) (kill-buffer buf) (save-current-buffer (set-buffer output) (insert (format "\n\n===== %s =====\n\n" container)) (insert contents)) (setq --cl-var-- (cdr --cl-var--))) nil) (cancel-timer timer)) (error (let* ((--cl-var-- buffs) (buf nil)) (while (consp --cl-var--) (setq buf
>
> I've grepped around the Emacs sources a bit, and I'm unable to find a
> string like "===== %s =====" or "setq container" anywhere in Emacs.
>
> Could this be from a local package you've installed?
>
> --
> (domestic pets only, the antidote for overdose, milk.)
>    bloggy blog: http://lars.ingebrigtsen.no