From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Newsgroups: gmane.emacs.bugs Subject: bug#43764: Calc shift right broken Date: Fri, 9 Oct 2020 17:29:58 +0200 Message-ID: References: <87h7r9ozuh.fsf@gnus.org> <87wo04nnvr.fsf@gnus.org> <4648BF2F-8507-4D39-85F1-1C40C0E8BFC2@acm.org> Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.17\)) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="37802"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Vincent =?UTF-8?Q?Bela=C3=AFche?= , 43764@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Oct 09 17:31:13 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kQuMT-0009k8-2e for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 09 Oct 2020 17:31:13 +0200 Original-Received: from localhost ([::1]:50022 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kQuMS-0000IK-2z for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 09 Oct 2020 11:31:12 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:52646) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kQuMI-0000Fq-EI for bug-gnu-emacs@gnu.org; Fri, 09 Oct 2020 11:31:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:52756) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kQuMI-0006Hc-2H for bug-gnu-emacs@gnu.org; Fri, 09 Oct 2020 11:31:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kQuMH-0007eh-W2 for bug-gnu-emacs@gnu.org; Fri, 09 Oct 2020 11:31:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 09 Oct 2020 15:31:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43764 X-GNU-PR-Package: emacs Original-Received: via spool by 43764-submit@debbugs.gnu.org id=B43764.160225740929361 (code B ref 43764); Fri, 09 Oct 2020 15:31:01 +0000 Original-Received: (at 43764) by debbugs.gnu.org; 9 Oct 2020 15:30:09 +0000 Original-Received: from localhost ([127.0.0.1]:36069 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kQuLQ-0007dV-S5 for submit@debbugs.gnu.org; Fri, 09 Oct 2020 11:30:09 -0400 Original-Received: from mail1468c50.megamailservers.eu ([91.136.14.68]:47758 helo=mail268c50.megamailservers.eu) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kQuLP-0007bs-PK for 43764@debbugs.gnu.org; Fri, 09 Oct 2020 11:30:08 -0400 X-Authenticated-User: mattiase@bredband.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megamailservers.eu; s=maildub; t=1602257401; bh=melFlSOw4H8S7ylI87qlTzSL2GijpHWeR7xlxJpOM4s=; h=Subject:From:In-Reply-To:Date:Cc:References:To:From; b=Uqra+jNKQW0z0eN1Jb7UNuxVe99oMESiDNh3HmYXdYrA7txpAaEf1WjouwG80fWAu BKhiNvreXvc6JKAXe+VnoM3O+oR1n+v49SNuuMcyLyJEIlLsBmGiS6f/yQ9Axyy4wh 32trXuW0aK5xzOMr1p/ouVtvnqOa5GFzJ5ZYiiik= Feedback-ID: mattiase@acm.or Original-Received: from [192.168.0.4] (c188-150-171-71.bredband.comhem.se [188.150.171.71]) (authenticated bits=0) by mail268c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id 099FTxMm028579; Fri, 9 Oct 2020 15:30:00 +0000 In-Reply-To: <4648BF2F-8507-4D39-85F1-1C40C0E8BFC2@acm.org> X-Mailer: Apple Mail (2.3445.104.17) X-CTCH-RefID: str=0001.0A782F22.5F8081F9.005A, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown X-CTCH-Score: 0.000 X-CTCH-Flags: 0 X-CTCH-ScoreCust: 0.000 X-CSC: 0 X-CHA: v=2.3 cv=BZ+mLYl2 c=1 sm=1 tr=0 a=SF+I6pRkHZhrawxbOkkvaA==:117 a=SF+I6pRkHZhrawxbOkkvaA==:17 a=kj9zAlcOel0A:10 a=M51BFTxLslgA:10 a=HOkUblpsRhd81tqE1VMA:9 a=CjuIK1q_8ugA:10 X-Origin-Country: SE X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:190166 Archived-At: > What about a narrower change: clip the value after shifting right = instead of before? On the other hand it would introduce an inconsistency with arithmetic = right shift which ignores bits above the word size. Thus I will do nothing at all unless Vincent or anyone else speaks up. However, this bug has already been a success since inspecting the code = revealed a bug in the arithmetic right shift that has now been fixed, = and there is now a fairly comprehensive test for all binary shift and = rotate operations which should make future changes a lot safer and = easier.