From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Theodor Thornhill via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#61104: 29.0.60; typescript-ts-mode does not provide compilation-mode support Date: Fri, 03 Feb 2023 06:30:29 +0100 Message-ID: References: <316aee65-50c6-9dad-5b8d-08d90675c5a5@secure.kjonigsen.net> <83o7qjbu0l.fsf@gnu.org> <83lelnazs1.fsf@gnu.org> Reply-To: Theodor Thornhill Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="6758"; mail-complaints-to="usenet@ciao.gmane.io" Cc: casouri@gmail.com, 61104@debbugs.gnu.org To: jostein@kjonigsen.net, Jostein =?UTF-8?Q?Kj=C3=B8nigsen?= , Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Feb 03 06:31:28 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pNofX-0001dJ-NY for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 03 Feb 2023 06:31:27 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pNofC-0000U8-IJ; Fri, 03 Feb 2023 00:31:06 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pNof9-0000TU-4H for bug-gnu-emacs@gnu.org; Fri, 03 Feb 2023 00:31:05 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pNof8-0002ZJ-R5 for bug-gnu-emacs@gnu.org; Fri, 03 Feb 2023 00:31:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pNof8-0002MC-MY for bug-gnu-emacs@gnu.org; Fri, 03 Feb 2023 00:31:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Theodor Thornhill Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 03 Feb 2023 05:31:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61104 X-GNU-PR-Package: emacs Original-Received: via spool by 61104-submit@debbugs.gnu.org id=B61104.16754022469023 (code B ref 61104); Fri, 03 Feb 2023 05:31:02 +0000 Original-Received: (at 61104) by debbugs.gnu.org; 3 Feb 2023 05:30:46 +0000 Original-Received: from localhost ([127.0.0.1]:36288 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pNoer-0002LT-Kh for submit@debbugs.gnu.org; Fri, 03 Feb 2023 00:30:46 -0500 Original-Received: from out-168.mta0.migadu.com ([91.218.175.168]:13743) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pNoeo-0002LH-F2 for 61104@debbugs.gnu.org; Fri, 03 Feb 2023 00:30:43 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=thornhill.no; s=key1; t=1675402240; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=49UQWEQMAT9fHaGZBVFPMYKFq2oYceIRpZbjbsLRC3o=; b=v7CURzuqf8Ln+2jAqrmsuRbHBwUvgVSydBipCMJlzM1VOOCmyemXT1h61PbapMeVSkeAm4 ZDeTvL2JGF0F6r1o+PISX6LAVNDgIWqt2idRScCC5rvFHN5Dla5uf68szMz0dL+E1P8rYP OYc+9D8g3cRoA6lSHFBRxVNdBNX6UCFewxWZM+2YS4eqrvdfEAPW833sSi2kyRQvHZOtQ7 gwg0OeErxfP//M8RqYXqxwbPe2PN+HY7zH0xIbIWkjOu74M2e/V9uDtk2//HMHsfKctr2f 6D1DSEp3TxI/6QwJXEEJ/VAX3zk7svOd+qQGykGMyuuTbRhQxaHQIghFG5kOlw== X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. In-Reply-To: X-Migadu-Flow: FLOW_OUT X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:254709 Archived-At: On 2 February 2023 22:01:11 CET, "Jostein Kj=C3=B8nigsen" wrote: >Any news on this one? Will this be merged? :) > My guess is that it should go on master=2E I'll look at it today - sorry i= t took some time :) Theo >Vennlig hilsen >*Jostein Kj=C3=B8nigsen* > >jostein@kjonigsen=2Enet =F0=9F=8D=B5 jostein@gmail=2Ecom >https://jostein=2Ekj=C3=B8nigsen=2Eno >On 1/28/23 15:28, Jostein Kj=C3=B8nigsen wrote: >>=20 >> On 1/28/23 08:23, Eli Zaretskii wrote: >>>=20 >>> I don't think doing this in the major-mode file will improve locality, >>> because we have compilation-minor-mode, which should be able to do its >>> thing even if the relevant major mode is not yet loaded=2E >> Fair enough! >>>=20 >>>> - adding it in compile=2Eel, to improve ability to oversee all >>>> expressions, and be able to optimize those? >>>>=20 >>>> I see csharp-mode=2Eel has the expressions added directly there=2E Sh= ould I >>>> go about preparing patches doing >>>> the same for typescript-ts-mode too? >>> I don't see why not=2E >>=20 >> Ok=2E Attached is a patch which adds Typescript tsc-support to compile= =2Eel=2E Is this OK to install in emacs-29? >>=20 >> I also see in retrospect that my comment about csharp-mode above may be= en somewhat ambiguous and easy to misunderstand (and seemingly you did)=2E >>=20 >> To be clear: csharp-mode includes the compilation-mode regexps in the m= ajor-mode, not in compile=2Eel=2E Is this also something we should aim to f= ix for emacs-29, or should we leave that for master? >>=20 >> --=20 >> Jostein