From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Yuan Fu via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#59445: 29.0.50; Tweak tree sitter faces in Java and TypeScript Date: Tue, 22 Nov 2022 02:08:16 -0800 Message-ID: References: <87a64k8pzu.fsf@thornhill.no> Reply-To: Yuan Fu Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.1\)) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="26527"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 59445@debbugs.gnu.org, Theodor Thornhill To: Randy Taylor Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Nov 22 12:38:20 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oxRbX-0006cQ-Ia for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 22 Nov 2022 12:38:20 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oxRbJ-0005Y4-Po; Tue, 22 Nov 2022 06:38:05 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oxRbG-0005Xm-UG for bug-gnu-emacs@gnu.org; Tue, 22 Nov 2022 06:38:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oxRbG-0001ug-Kd for bug-gnu-emacs@gnu.org; Tue, 22 Nov 2022 06:38:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oxRbG-0001r3-Gx for bug-gnu-emacs@gnu.org; Tue, 22 Nov 2022 06:38:02 -0500 X-Loop: help-debbugs@gnu.org In-Reply-To: <87a64k8pzu.fsf@thornhill.no> Resent-From: Yuan Fu Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 22 Nov 2022 11:38:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59445 X-GNU-PR-Package: emacs Original-Received: via spool by 59445-submit@debbugs.gnu.org id=B59445.16691170517073 (code B ref 59445); Tue, 22 Nov 2022 11:38:02 +0000 Original-Received: (at 59445) by debbugs.gnu.org; 22 Nov 2022 11:37:31 +0000 Original-Received: from localhost ([127.0.0.1]:50042 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oxRak-0001pw-LO for submit@debbugs.gnu.org; Tue, 22 Nov 2022 06:37:31 -0500 Original-Received: from mx0b-0016e101.pphosted.com ([148.163.141.31]:15570) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oxQCR-0007v9-Sc for 59445@debbugs.gnu.org; Tue, 22 Nov 2022 05:08:21 -0500 Original-Received: from pps.filterd (m0151360.ppops.net [127.0.0.1]) by mx0b-0016e101.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 2AMA8Jj6001818 for <59445@debbugs.gnu.org>; Tue, 22 Nov 2022 02:08:19 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ucsd.edu; h=from : content-type : content-transfer-encoding : mime-version : subject : message-id : date : cc : to; s=campus; bh=b7Nx1ixWskPbxtsXJuNRV0VAco0rMb6McpbsAUVJvYc=; b=erjgJpkqJ8CEUM8qgFUIFGIQtMW+2EnP1JwHMOdabBBoK7KZMv4EZP1Fam0ZogY7qxAJ AbeirAAjvxT95hmPxeNh+/cHo2YrL8gk3fqfB0lVjDM0n7gxcM0SqMgnjbCP5Lpcjs3h MmtAlvV1mKNGdpZUSmTgv4c57vkhtTI2ncL8ezAQSixcxU/i1KgZXiIA8fp+g1sJhM+s HsKlcJQIVp+XrnUd0HZ0SDYgpCCsa30bFFFAxC1dnOeRmV+GCEnZ0wYGbBB9Quop/TlD pGkM3H/zXenpqp16xsAuozfXPQOn0wtUxfW+vL0g9Gg7Fcy1NFWe4Nh3K7qxDU3nnLU9 1w== Original-Received: from mail-pg1-f198.google.com (mail-pg1-f198.google.com [209.85.215.198]) by mx0b-0016e101.pphosted.com (PPS) with ESMTPS id 3kyganjfj6-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for <59445@debbugs.gnu.org>; Tue, 22 Nov 2022 02:08:19 -0800 Original-Received: by mail-pg1-f198.google.com with SMTP id h185-20020a636cc2000000b0046fc6e0065dso8339804pgc.5 for <59445@debbugs.gnu.org>; Tue, 22 Nov 2022 02:08:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ucsd.edu; s=google; h=to:cc:date:message-id:subject:mime-version :content-transfer-encoding:from:from:to:cc:subject:date:message-id :reply-to; bh=b7Nx1ixWskPbxtsXJuNRV0VAco0rMb6McpbsAUVJvYc=; b=a7YB5VeP92aUHMvSlIT/tEeplWTzMTV+tW6jmPjE/ogXvLdezEJkuQNFRcJR3pULzJ SDvQnh1OATfg7tvB++t+KCux6ffSYAHY4yyJrpdpIgvgE1pbW3W/7cET1OHE3/D1/lBs RNRgQPUUd4C5pn2AiY8B0w5KXM03K19Oytglc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:cc:date:message-id:subject:mime-version :content-transfer-encoding:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=b7Nx1ixWskPbxtsXJuNRV0VAco0rMb6McpbsAUVJvYc=; b=jy91Z4/7IOJb5SPsGcOZiv45zSxIiqHt9T0h0GQly8gOmsBO5rHu7bcb8THgkPuYL4 WBHsfEccTU6kdLs5G6+evf22x2G2oBbw0jNsOT7ilfXO3jq50y15gcR63ESYYKuyJhtE hbdT/XWlGUMIlAL/jIht0640281XYtFlpUSlVeljMprsPAIufRogPuiB071foytQe5IW beVm6GDUujtKbCwJHAHKRvzZ+i3mYATu3KsgC+Fk6HOAhiA9qBCHbnYRj4XHCx55NFxM ydRSWYyQmo1eAmVtr3t+NGG8Yb6sEVF2Bj2T43/lppdXbmoFlLVNr0H3alAgMhEUBh+c 0Ikw== X-Gm-Message-State: ANoB5pmtKq3VMlW85nRw1meXb7DBeky3y5ETxMLxmoPKQbKWgkqfzXYt BaQdENFTraSaOc1ftdpbF2gnSnCMS1PkRECYsrFtTfgSOY2HtXiwBzpgT4V5UhwMsgnChWYtswm H1eTGn8KZ5gCZFA== X-Received: by 2002:a65:6118:0:b0:476:d2e9:778e with SMTP id z24-20020a656118000000b00476d2e9778emr5618908pgu.309.1669111697823; Tue, 22 Nov 2022 02:08:17 -0800 (PST) X-Google-Smtp-Source: AA0mqf6YNR8bblTaWdkLuCmXY4uz0TYhk7NxN8utmB30IsqJ3aDl/IxT327m5oGcUr7+y5wYlmnd4w== X-Received: by 2002:a65:6118:0:b0:476:d2e9:778e with SMTP id z24-20020a656118000000b00476d2e9778emr5618892pgu.309.1669111697506; Tue, 22 Nov 2022 02:08:17 -0800 (PST) Original-Received: from smtpclient.apple (cpe-172-117-161-177.socal.res.rr.com. [172.117.161.177]) by smtp.gmail.com with ESMTPSA id y15-20020aa79aef000000b00565cbad9616sm10258994pfp.6.2022.11.22.02.08.16 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 22 Nov 2022 02:08:17 -0800 (PST) X-Mailer: Apple Mail (2.3696.120.41.1.1) X-campus_gsuite: gsuite_33445511 X-Proofpoint-ORIG-GUID: ivJP5gEKVeU6Tcj6L8SfihPSqdqKwC8h X-Proofpoint-GUID: ivJP5gEKVeU6Tcj6L8SfihPSqdqKwC8h pp_allow_relay: proofpoint_allowed X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.219,Aquarius:18.0.895,Hydra:6.0.545,FMLib:17.11.122.1 definitions=2022-11-22_04,2022-11-18_01,2022-06-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 mlxlogscore=738 priorityscore=1501 spamscore=0 suspectscore=0 bulkscore=0 lowpriorityscore=0 malwarescore=0 adultscore=0 impostorscore=0 clxscore=1011 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2210170000 definitions=main-2211220074 X-Mailman-Approved-At: Tue, 22 Nov 2022 06:37:29 -0500 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:248623 Archived-At: Randy Taylor writes: > On Monday, November 21st, 2022 at 07:13, Theodor Thornhill via "Bug > reports for GNU Emacs, the Swiss army knife of text editors" > wrote: > >>=20 >> Hi Yuan! >>=20 >> I tweaked Java and TypeScript a little. >>=20 >> Feel free to apply when you have the time :) >>=20 >> Theo Thanks, I just applied this patch. > > Looks good. > > For java-ts-mode.el can you show examples of what bracket and > delimiter highlight with your changes? I couldn't get them to > highlight anything when I tested and I had the exact same queries as > you, hence why I left them out of my patch. Similar thing occurred > with sh-script.el. Have you tried using treesit-query-capture to "manually" capture these nodes? I always use (treesit-query-capture (treesit-buffer-root-node) = (region-beginning) (region-end)) Yuan