From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Newsgroups: gmane.emacs.bugs Subject: bug#54263: 29.0.50; color-values-from-color-spec accepts whitespace in rgbi: specifications Date: Sun, 6 Mar 2022 10:56:26 +0100 Message-ID: References: <87v8wswcsf.fsf@posteo.net> Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.13\)) Content-Type: multipart/mixed; boundary="Apple-Mail=_BDB30E55-DDE5-4420-BF27-1BBBAC88435D" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="5632"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 54263@debbugs.gnu.org, Lars Ingebrigtsen To: Philip Kaludercic Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Mar 06 10:57:25 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nQndk-0001H1-NS for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 06 Mar 2022 10:57:24 +0100 Original-Received: from localhost ([::1]:57480 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nQndj-0006eG-99 for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 06 Mar 2022 04:57:23 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:43708) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nQndO-0006e7-Ng for bug-gnu-emacs@gnu.org; Sun, 06 Mar 2022 04:57:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:55966) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nQndO-0003CI-Dv for bug-gnu-emacs@gnu.org; Sun, 06 Mar 2022 04:57:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nQndO-0008F1-6o for bug-gnu-emacs@gnu.org; Sun, 06 Mar 2022 04:57:02 -0500 X-Loop: help-debbugs@gnu.org In-Reply-To: <87v8wswcsf.fsf@posteo.net> Resent-From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 06 Mar 2022 09:57:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 54263 X-GNU-PR-Package: emacs Original-Received: via spool by 54263-submit@debbugs.gnu.org id=B54263.164656059931652 (code B ref 54263); Sun, 06 Mar 2022 09:57:02 +0000 Original-Received: (at 54263) by debbugs.gnu.org; 6 Mar 2022 09:56:39 +0000 Original-Received: from localhost ([127.0.0.1]:49863 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nQnd1-0008ES-7B for submit@debbugs.gnu.org; Sun, 06 Mar 2022 04:56:39 -0500 Original-Received: from mail1465c50.megamailservers.eu ([91.136.14.65]:40432 helo=mail268c50.megamailservers.eu) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nQncy-0008EA-DC for 54263@debbugs.gnu.org; Sun, 06 Mar 2022 04:56:37 -0500 X-Authenticated-User: mattiase@bredband.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megamailservers.eu; s=maildub; t=1646560589; bh=7XZRqvzqUz1IDIOS3mn6fpg+b8k019t0YXVhkPVTra4=; h=From:Subject:Date:Cc:To:From; b=eHu2CfNY7PyHibMoULgP4tI+xt7fd0WqjiSVGAb4OC/h2HLOQKuovh66Z/QmfR230 ofd0yHYrNQ8q5b9h/eYr+eqYtWCyFW3jyGkqLtYyY5Ed8t54ifLJFLDXuKpXfNrJtv 3f+Gfqb63wIMnP4S1Sx5SPBMrCLimB3sEwHfTkDU= Feedback-ID: mattiase@acm.or Original-Received: from smtpclient.apple (c-b952e353.032-75-73746f71.bbcust.telenor.se [83.227.82.185]) (authenticated bits=0) by mail268c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id 2269uQB4016368; Sun, 6 Mar 2022 09:56:28 +0000 X-Mailer: Apple Mail (2.3654.120.0.1.13) X-CTCH-RefID: str=0001.0A742F18.6224854D.000F, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown X-CTCH-Score: 0.000 X-CTCH-Flags: 0 X-CTCH-ScoreCust: 0.000 X-Origin-Country: SE X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:228055 Archived-At: --Apple-Mail=_BDB30E55-DDE5-4420-BF27-1BBBAC88435D Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii > I haven't seen the function being used anywhere up until now (which = doesn't have to mean anything), but considering that this is a = relatively niche edge-case I would say that the bug should either be = solved now or never.=20 Let's solve it now then. I'm to blame, patch attached. --Apple-Mail=_BDB30E55-DDE5-4420-BF27-1BBBAC88435D Content-Disposition: attachment; filename=0001-Don-t-accept-leading-whitespace-in-rgbi-colour-specs.patch Content-Type: application/octet-stream; x-unix-mode=0644; name="0001-Don-t-accept-leading-whitespace-in-rgbi-colour-specs.patch" Content-Transfer-Encoding: quoted-printable =46rom=200433c23ce12ea24bcb4de93b92b92070cf257310=20Mon=20Sep=2017=20= 00:00:00=202001=0AFrom:=20=3D?UTF-8?q?Mattias=3D20Engdeg=3DC3=3DA5rd?=3D=20= =0ADate:=20Sun,=206=20Mar=202022=2010:50:27=20+0100=0A= Subject:=20[PATCH]=20Don't=20accept=20leading=20whitespace=20in=20rgbi:=20= colour=20specs=0A=0A`color-values-from-color-spec`=20(new=20in=20Emacs=20= 28)=20erroneously=20accepted=0Aleading=20whitespace=20in=20rgbi:=20= components.=0A=0AReported=20by=20Philip=20Kaludercic.=0A=0A*=20= src/xfaces.c=20(parse_float_color_comp):=20Disallow=20leading=20= whitespace.=0A*=20test/src/xfaces-tests.el=0A= (xfaces-internal-color-values-from-color-spec):=20Add=20test=20case.=0A= ---=0A=20src/xfaces.c=20=20=20=20=20=20=20=20=20=20=20=20=20|=204=20++++=0A= =20test/src/xfaces-tests.el=20|=203=20++-=0A=202=20files=20changed,=206=20= insertions(+),=201=20deletion(-)=0A=0Adiff=20--git=20a/src/xfaces.c=20= b/src/xfaces.c=0Aindex=208100bdb157..7fbc667dfd=20100644=0A---=20= a/src/xfaces.c=0A+++=20b/src/xfaces.c=0A@@=20-888,6=20+888,10=20@@=20= parse_hex_color_comp=20(const=20char=20*s,=20const=20char=20*e,=20= unsigned=20short=20*dst)=0A=20static=20double=0A=20= parse_float_color_comp=20(const=20char=20*s,=20const=20char=20*e)=0A=20{=0A= +=20=20if=20(s=20>=3D=20e=20||=0A+=20=20=20=20=20=20!(*s=20=3D=3D=20'0'=20= ||=20*s=20=3D=3D=20'1'=20||=20*s=20=3D=3D=20'.'=20||=20*s=20=3D=3D=20'+'=20= ||=20*s=20=3D=3D=20'-'))=0A+=20=20=20=20/*=20No=20leading=20whitespace=20= permitted.=20=20*/=0A+=20=20=20=20return=20-1;=0A=20=20=20char=20*end;=0A= =20=20=20double=20x=20=3D=20strtod=20(s,=20&end);=0A=20=20=20return=20= (end=20=3D=3D=20e=20&&=20x=20>=3D=200=20&&=20x=20<=3D=201)=20?=20x=20:=20= -1;=0Adiff=20--git=20a/test/src/xfaces-tests.el=20= b/test/src/xfaces-tests.el=0Aindex=2031c0f021b2..1175874144=20100644=0A= ---=20a/test/src/xfaces-tests.el=0A+++=20b/test/src/xfaces-tests.el=0A@@=20= -47,7=20+47,8=20@@=20xfaces-internal-color-values-from-color-spec=0A=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20'(0=2032768=206554)))=0A=20= =20=20(should=20(equal=20(color-values-from-color-spec=20= "rgbi:1e-3/1.0e-2/1e0")=0A=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20'(66=20655=2065535)))=0A-=20=20(should=20(equal=20= (color-values-from-color-spec=20"rgbi:0/0.5/10")=20nil)))=0A+=20=20= (should=20(equal=20(color-values-from-color-spec=20"rgbi:0/0.5/10")=20= nil))=0A+=20=20(should=20(equal=20(color-values-from-color-spec=20= "rgbi:0/0/=200")=20nil)))=0A=20=0A=20(provide=20'xfaces-tests)=0A=20=0A= --=20=0A2.32.0=20(Apple=20Git-132)=0A=0A= --Apple-Mail=_BDB30E55-DDE5-4420-BF27-1BBBAC88435D--