bug#3792: #3792 - 23.1.50; other-window misbehaving with C-tab keybinding - Emacs bug report logs

[Ivan Andrus <IAndrus@omniture.com>]

[-- Attachment #1.1: Type: text/plain, Size: 56 bytes --]

Resending patch (properly formatted this time I hope).

[-- Attachment #1.2: Type: text/html, Size: 304 bytes --]

[-- Attachment #2: emacs.patch --]
[-- Type: application/octet-stream, Size: 1544 bytes --]

--- nsterm.m	06 Jul 2009 21:46:57 -0600	1.76
+++ nsterm.m	10 Jul 2009 09:11:20 -0600
@@ -218,6 +218,15 @@
    Mode 0 is normal anti-aliasing, mode 1 is no anti-aliasing, and mode 2 is
    4-bit pixel-aligned anti-aliasing (the old QuickDraw standard). */
 extern void CGContextSetFontRenderingMode (CGContextRef cg, int v);
+
+/* This will tell us whether this particular version of OS X sends
+   keyDown events for control-tab.  Apparently some versions do and
+   some don't.  If they don't, then we have to emulate it by using
+   keyUp events instead, but if they do then we don't want to send
+   both.
+*/
+static BOOL ns_sends_control_tab_keydown = NO;
+
 #endif


@@ -4456,6 +4456,16 @@
   static NSMutableArray *nsEvArray;
   static BOOL firstTime = YES;

+#ifdef NS_IMPL_COCOA
+  /* I think these will get set again later, but we need them now
+     before ns_fake_keydown is changed. */
+  flags = [theEvent modifierFlags];
+  code = [theEvent keyCode];
+  if (!ns_fake_keydown && code == 0x30 && (flags & NSControlKeyMask) && !(flags & NSCommandKeyMask)) {
+    ns_sends_control_tab_keydown = YES;
+  }
+#endif
+
   NSTRACE (keyDown);

   /* Rhapsody and OS X give up and down events for the arrow keys */
@@ -4628,6 +4628,8 @@
    If it matches one of these, send it on to keyDown. */
 -(void)keyUp: (NSEvent *)theEvent
 {
+  if ( ns_sends_control_tab_keydown )  return;
+
   int flags = [theEvent modifierFlags];
   int code = [theEvent keyCode];
   if (code == 0x30 && (flags & NSControlKeyMask) && !(flags & NSCommandKeyMask))