From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Yuan Fu Newsgroups: gmane.emacs.bugs Subject: bug#62333: 30.0.50; Issue with tree-sitter syntax tree during certain changes Date: Sun, 26 Mar 2023 15:57:55 -0700 Message-ID: References: <87fs9yur7r.fsf@gmail.com> <2fd8f2b8-d9c4-c825-a789-f2d42324859f@yandex.ru> <09539C5E-23DA-4B00-A3F6-873A41D6A2CE@gmail.com> <83h6uc549z.fsf@gnu.org> <665745A2-FDC8-45DE-BFF5-2F688FC85431@gmail.com> <491b788f-c3c3-4877-daa0-f515be9f3a17@yandex.ru> <83sfduelab.fsf@gnu.org> <8FC25A01-6934-43BB-899C-CA5926BEA3CF@gmail.com> <83jzz5c8ml.fsf@gnu.org> <83edpdc6sn.fsf@gnu.org> <1ca302bf-99dc-7f9e-8544-063064a1cb21@yandex.ru> <831qlcdisi.fsf@gnu.org> <398721ad-79b0-3f6d-97b3-4902d9bfbe39@yandex.ru> <83wn34c2qa.fsf@gnu.org> <3b3d82d1-f0f6-a768-a5db-8dc9386a5a34@yandex.ru> <83r0tcbz8g.fsf@gnu.org> <1967361679760225@umbzx4hqxrw5qxo7.sas.yp-c.yandex.net> <83mt40bxzd.fsf@gnu.org> <83jzz4bugh.fsf@gnu.org> <35322CB1-DF75-47C1-9B66-21260C437006@gmail.com> <83a600b0gk.fsf@gnu.org> Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.400.51.1.1\)) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="34313"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Wilhelm Kirschbaum , 62333@debbugs.gnu.org, Dmitry Gutov To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Mar 27 00:59:24 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pgZKd-0008jA-KL for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 27 Mar 2023 00:59:23 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pgZKJ-00014h-Ms; Sun, 26 Mar 2023 18:59:03 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pgZKI-00014X-IA for bug-gnu-emacs@gnu.org; Sun, 26 Mar 2023 18:59:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pgZKI-0000Cc-A5 for bug-gnu-emacs@gnu.org; Sun, 26 Mar 2023 18:59:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pgZKI-0004H0-5y for bug-gnu-emacs@gnu.org; Sun, 26 Mar 2023 18:59:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Yuan Fu Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 26 Mar 2023 22:59:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62333 X-GNU-PR-Package: emacs Original-Received: via spool by 62333-submit@debbugs.gnu.org id=B62333.167987149416358 (code B ref 62333); Sun, 26 Mar 2023 22:59:02 +0000 Original-Received: (at 62333) by debbugs.gnu.org; 26 Mar 2023 22:58:14 +0000 Original-Received: from localhost ([127.0.0.1]:46094 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pgZJW-0004Fl-Ci for submit@debbugs.gnu.org; Sun, 26 Mar 2023 18:58:14 -0400 Original-Received: from mail-pj1-f53.google.com ([209.85.216.53]:50755) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pgZJU-0004FU-L5 for 62333@debbugs.gnu.org; Sun, 26 Mar 2023 18:58:13 -0400 Original-Received: by mail-pj1-f53.google.com with SMTP id d13so6093068pjh.0 for <62333@debbugs.gnu.org>; Sun, 26 Mar 2023 15:58:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1679871487; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=nAcyI1uSIK8SRWuGpKa6az8mCgyQ0XkaYbjAm+cyncA=; b=PuOpj+J9B+8/0YuBUDLRLYNCawm5kyIZfCvTJSn470eX4VfMY5vAag1aiU6ibzDgMS z/w5OrignTMT/1PiB0Wn8lM0O/zuJMwBzgyX3flqwEUC8BuIO8+ETbbEUcGA4GIkLatj O+RZFNjKzJ1gyT9FPIhaY1/TlDapYpeg0MiRcWqyRhSqlHCSRPSlfJPU7PfA2U59cwUb wNPCWa6UKWvKwn1RLsOYbhlq4lD/xmNE3l1MkE5w4MaZ8MCTlW3UzRzdBYt3x0D3fDKa i0ilj7kI5gd7J/HHFHJPSTcBhlCLVyOJZ5BMo9KSBP/6/icZXH1Kzn7HaDJdfHX5Ao7G HoSg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679871487; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=nAcyI1uSIK8SRWuGpKa6az8mCgyQ0XkaYbjAm+cyncA=; b=BUjKtvvY1Gnr9iwGPqp0XiCdymV3OtmAqlOnpvnt8I2vGFXCQegtBnQPkhTOXVSkld sTe1HjQLARFIi+AxCVQrPjtxgKDAQxrL0CN6SLrYQaRsxUtq8v541iW/RceEADA0NjSm I+TVWk15ygK0gp9kbyLbKjpQ2GJiz5SG9dBV4QIdK0nw0T0R6i3fYhJM2+I5o31OuJgO UlFUaOBZYACnzsLup2JB2/KjHnw7//cdkZOcxvlzxohHwtTaHwgUV/7wDy4g1Y0Jv4e4 h2BAkBAgeL0R70i0Mo0vdj8zHhnaTcfU7ryrNJf6a06Oysxe1338sMhOLF/ZzbhEXZoZ ZOyQ== X-Gm-Message-State: AAQBX9e+5nQq/kOF/0nPPpJI2CAZHnGmDtcoxlzdqQXoZxPwF/GYfmJR znj3K4wAU4cqirgK7RBVf+0= X-Google-Smtp-Source: AKy350ZBve5mvcU1ybfqXDfP0JfcliZBEDaPq7Wstu0HkhgFYDv5AmR0TZe4FNvGC2WBiU9Of1I+YQ== X-Received: by 2002:a17:903:110e:b0:1a1:bfd6:f890 with SMTP id n14-20020a170903110e00b001a1bfd6f890mr12281579plh.9.1679871486671; Sun, 26 Mar 2023 15:58:06 -0700 (PDT) Original-Received: from smtpclient.apple (cpe-172-117-161-177.socal.res.rr.com. [172.117.161.177]) by smtp.gmail.com with ESMTPSA id 13-20020a170902c24d00b0017a032d7ae4sm17739614plg.104.2023.03.26.15.58.05 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sun, 26 Mar 2023 15:58:06 -0700 (PDT) In-Reply-To: <83a600b0gk.fsf@gnu.org> X-Mailer: Apple Mail (2.3731.400.51.1.1) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:258705 Archived-At: > On Mar 25, 2023, at 9:28 PM, Eli Zaretskii wrote: >=20 >> From: Yuan Fu >> Date: Sat, 25 Mar 2023 12:31:58 -0700 >> Cc: Dmitry Gutov , >> Wilhelm Kirschbaum , >> 62333@debbugs.gnu.org >>=20 >>=20 >> I don=E2=80=99t think we should blindly widen in tree-sitter sexp = functions, but not because of mmm-mode=E2=80=94tree-sitter ranges should = have that mostly covered. My primary concern is that what if narrowing = is intended by the caller? >=20 > What could be the reason for the caller to narrow when calling a > sexp-movement function? Keep in mind that the only narrowing that > matters is one that prevents the sexp-movement function to find the > target of the movement. Maybe the user narrowed to a defun when writing code. There is a bug = report on narrow-to-defun not working right in c-ts-mode, so there are = definitely people who work like that. >> But I don=E2=80=99t have any good idea for blink-matching right now. >=20 > We could leave this alone for now, but in that case let's at least add > some FIXME comment in the relevant place(s), so that we could later > revisit this. Dmitry=E2=80=99s idea sounds good, we can add a tree-sitter backend for = show-paren-data-function, and make the backend for blink-matching-paren = configurable, then add a backend for it that uses = show-paren-data-function, which in turn uses tree-sitter (or we add a = backend that uses tree-sitter directly). In either case, the tree-sitter = backend don=E2=80=99t need to use narrowing and we are good. Yuan