unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Yuan Fu <casouri@gmail.com>
To: Randy Taylor <dev@rjt.dev>
Cc: 59268@debbugs.gnu.org
Subject: bug#59268: [PATCH] Utilize new font-lock faces for C/C++ and Python tree-sitter use
Date: Thu, 17 Nov 2022 12:07:43 -0800	[thread overview]
Message-ID: <C4E2BDB7-D8D2-412C-971E-A5F22107F7E6@gmail.com> (raw)
In-Reply-To: <jzL3bCP0bCpbmU_his3z_7on1hMfpw8aXozopPwQJCSpbT_5LDrUvivLb5tIvCXUc6p3RE1awGLkUoOOO_rK2VOAO7QMolxvvLfmvh_IT-A=@rjt.dev>



> On Nov 17, 2022, at 12:02 PM, Randy Taylor <dev@rjt.dev> wrote:
> 
> On Thursday, November 17th, 2022 at 13:39, Yuan Fu <casouri@gmail.com> wrote:
> 
>> 
>> Ah, the purpose of that rule is to highlight field names in the LHS of assignments only. So if I disable property and enable assignment, I should see normal field names not highlighted, but field names in LHS of assignments highlighted.
>> 
> 
> I see - you're trying to truly cover everything in assignment on its own.
> 
>>> Also, I've attached an updated patch: it seems that the escape-sequence feature needs an override to work (probably because it's inside a string that's highlighted?).<0001-Utilize-new-font-lock-faces-for-C-C-and-Python-tree-.patch>
>> 
>> 
>> Thanks. I will add back the assignment field rule and apply, is that ok with you?
>> 
> 
> Sure! I attached a patch which keeps it.<0001-Utilize-new-font-lock-faces-for-C-C-and-Python-tree-.patch>

Thanks, applied :-)

Yuan




  reply	other threads:[~2022-11-17 20:07 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-14  3:27 bug#59268: [PATCH] Utilize new font-lock faces for C/C++ and Python tree-sitter use Randy Taylor
2022-11-15  1:26 ` Randy Taylor
2022-11-16  2:04   ` Randy Taylor
2022-11-17  3:26     ` Randy Taylor
2022-11-17  3:39       ` Yuan Fu
2022-11-17 13:50         ` Randy Taylor
2022-11-17 18:39           ` Yuan Fu
2022-11-17 20:02             ` Randy Taylor
2022-11-17 20:07               ` Yuan Fu [this message]
2022-11-17 20:19                 ` Randy Taylor

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=C4E2BDB7-D8D2-412C-971E-A5F22107F7E6@gmail.com \
    --to=casouri@gmail.com \
    --cc=59268@debbugs.gnu.org \
    --cc=dev@rjt.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).