From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Newsgroups: gmane.emacs.bugs Subject: bug#64391: buffer narrowing slowdown regression in emacs 29 Date: Sun, 2 Jul 2023 11:37:53 +0200 Message-ID: References: <87r0psb51z.fsf@ust.hk> <0AD15A09-F669-48C0-AF5C-971D52F5BF8E@gmail.com> <83v8f3q1ff.fsf@gnu.org> <50A46AAC-2089-45CB-A355-CCB2B4EA8D76@gmail.com> Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.15\)) Content-Type: multipart/mixed; boundary="Apple-Mail=_D60DCAFD-2DC7-4E30-AC14-9B372DA18783" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="24087"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Andrew Cohen , 64391@debbugs.gnu.org, Gregory Heytings , Stefan Monnier To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Jul 02 11:39:19 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qFtY6-000622-IY for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 02 Jul 2023 11:39:18 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qFtXw-0002QW-84; Sun, 02 Jul 2023 05:39:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qFtXq-0002OI-Gu for bug-gnu-emacs@gnu.org; Sun, 02 Jul 2023 05:39:07 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qFtXq-00063t-4H for bug-gnu-emacs@gnu.org; Sun, 02 Jul 2023 05:39:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qFtXp-00036u-L1; Sun, 02 Jul 2023 05:39:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org, bugs@gnus.org Resent-Date: Sun, 02 Jul 2023 09:39:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64391 X-GNU-PR-Package: emacs,gnus Original-Received: via spool by 64391-submit@debbugs.gnu.org id=B64391.168829068611889 (code B ref 64391); Sun, 02 Jul 2023 09:39:01 +0000 Original-Received: (at 64391) by debbugs.gnu.org; 2 Jul 2023 09:38:06 +0000 Original-Received: from localhost ([127.0.0.1]:59327 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qFtWw-00035h-Bh for submit@debbugs.gnu.org; Sun, 02 Jul 2023 05:38:06 -0400 Original-Received: from mail-lj1-f180.google.com ([209.85.208.180]:50650) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qFtWr-000357-1I for 64391@debbugs.gnu.org; Sun, 02 Jul 2023 05:38:05 -0400 Original-Received: by mail-lj1-f180.google.com with SMTP id 38308e7fff4ca-2b5e7dba43cso54509561fa.1 for <64391@debbugs.gnu.org>; Sun, 02 Jul 2023 02:38:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1688290675; x=1690882675; h=references:to:cc:in-reply-to:date:subject:mime-version:message-id :from:sender:from:to:cc:subject:date:message-id:reply-to; bh=GTQ6lRsWDG2ycsSf9hQOeCIzB+XY6DrOl2Zc3uE53fE=; b=ExTtvjFekEmWJO7PUXtUpDW03BStvrSF8uqfSs8lZymbitnHGZCRbmI/PHAQNN073D u4aLYvuHgnFWi9f7rLvQhmTlRm1OjtAovpQrNVSCPNQGIFGxK3emwvF8AR3GlcRJVfOu OaEcC6FhGOt9t/Oh26TJEEfIMPtEzfF2G0GwEjuWLaiXqTgMO4LzkPR1VcEXlJILFS4m YA2p3PU16Ks/zt8+oxdSQYsh7zJr2jLKAdWvnxoRQ2EATooO8AlFddnj4U8ODyKwYqkh p++rzLJ+qlPqQUhoCN9CCI9LiCVJkug2qJIOHglYCVUMfZ6FkHEtYl6t32P8ho4ue7n4 eL7w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688290675; x=1690882675; h=references:to:cc:in-reply-to:date:subject:mime-version:message-id :from:sender:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=GTQ6lRsWDG2ycsSf9hQOeCIzB+XY6DrOl2Zc3uE53fE=; b=DOtym9KQwMn50TfNunXByIgAeZh7H4OJ+EZ6mh6diG2HqIT2SgQccT81JqeRXF8uTH BbbIYYsHPQTtfc+lEzs5OWuyuHquG0yCY4+kVzcyytqVeh/MFSTWAf7oSJWO9WgAIKCg jW5wxelTREZc3Oliqmsz4qErsseL9xLbnopMdWH2LAejauIJKVSp8/23y3mWPFHLUZLU +FDa5sipjT+KfvAeg4r2wa3Oomidf0p9LS1T5I9/AE+jpzKSU2MeuyTGzfauvtdthheq 7pIvdsbTbftRdSLO7OBLI+JCGfF/ywaNwkSdYykR9EgafuFbKITLppHERSTRognCidZQ jamg== X-Gm-Message-State: ABy/qLberDi9eqsSzcf1bePyfcC2muvXF6gnqnaesQyJYMJHxzzB9QGy G0j46OdLqGt6wwT6i9xYbvM= X-Google-Smtp-Source: APBJJlG7M9vUmb8Wxp0IglVy7KHRN0tQ4KgtAeL0xMZT/WtpBDxObYc6ca131diPQKEqWQScXlwjYw== X-Received: by 2002:a05:6512:3a8e:b0:4fb:8a90:396c with SMTP id q14-20020a0565123a8e00b004fb8a90396cmr5741806lfu.38.1688290674529; Sun, 02 Jul 2023 02:37:54 -0700 (PDT) Original-Received: from smtpclient.apple (c188-150-165-235.bredband.tele2.se. [188.150.165.235]) by smtp.gmail.com with ESMTPSA id b8-20020ac25628000000b004fa5bfddabesm3698563lff.296.2023.07.02.02.37.54 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sun, 02 Jul 2023 02:37:54 -0700 (PDT) In-Reply-To: <50A46AAC-2089-45CB-A355-CCB2B4EA8D76@gmail.com> X-Mailer: Apple Mail (2.3654.120.0.1.15) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:264465 Archived-At: --Apple-Mail=_D60DCAFD-2DC7-4E30-AC14-9B372DA18783 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii How expensive markers can be when a buffer is modified is often = unappreciated. Here are the results of a benchmark to illustrate the = cost (code attached). A buffer contains "abababab...", we optionally add a marker to every = other position, and then time the deletion of all the "a"s. Results: | size | without markers | with markers | |--------+-----------------+--------------| | 500 | 0.000 | 0.001 | | 1000 | 0.001 | 0.004 | | 5000 | 0.002 | 0.089 | | 10000 | 0.005 | 0.363 | | 50000 | 0.024 | 9.527 | | 100000 | 0.049 | 58.048 | Now there's something for the curve-fitters among you. --Apple-Mail=_D60DCAFD-2DC7-4E30-AC14-9B372DA18783 Content-Disposition: attachment; filename=abench4.el Content-Type: application/octet-stream; x-unix-mode=0644; name="abench4.el" Content-Transfer-Encoding: 7bit ;;; -*- lexical-binding: t -*- (require 'cl-lib) (defun abench-run () (let ((buffer-undo-list t)) (goto-char (point-min)) (while (not (eobp)) (delete-char 1) (forward-char)))) (defun abench (size use-markers) (with-temp-buffer ;; Populate buffer (insert (mapconcat #'identity (make-list size "ab") nil)) ;; Insert markers (let ((markers nil)) (when use-markers (dotimes (i size) (push (set-marker (make-marker) (* i 2)) markers))) ;; Run operation (garbage-collect) (let ((gcs0 gcs-done) (gc-e0 gc-elapsed) (t0 (float-time))) (abench-run) (let ((dt (- (float-time) t0)) (gcs (- gcs-done gcs0)) (gc-time (- gc-elapsed gc-e0))) (cl-assert (equal (buffer-string) (mapconcat #'identity (make-list size "b") nil))) (list dt gcs gc-time)))))) (defun abench-main () (princ (format "Emacs %s\n" emacs-version)) (princ (format "| size | without markers | with markers |\n")) (princ (format "|------+-----------------+--------------|\n")) (dolist (size '(500 1000 5000 10000 50000 100000)) (let ((res-without (abench size nil)) (res-with (abench size t))) (princ (format "| %d | %.3f | %.3f |\n" size (nth 0 res-without) (nth 0 res-with))))) (princ (format "|------+-----------------+--------------|\n")) ) (abench-main) --Apple-Mail=_D60DCAFD-2DC7-4E30-AC14-9B372DA18783--