unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: "Mattias Engdegård" <mattias.engdegard@gmail.com>
To: Alan Mackenzie <acm@muc.de>
Cc: 67116-done@debbugs.gnu.org, Stefan Monnier <monnier@iro.umontreal.ca>
Subject: bug#67116: byte-compile-let: reversing the order of evaluation of the clauses CAN make a difference
Date: Mon, 13 Nov 2023 12:19:27 +0100	[thread overview]
Message-ID: <C48106DC-0EF3-41F5-AD69-84BA30A0C19D@gmail.com> (raw)
In-Reply-To: <90BD98E4-1026-4290-9D9F-7A413E670DCC@gmail.com>

> There's a bug here, will fix.

Now fixed on master. I'm very pleased that you reported this bug.
(Of course it didn't have anything to do with order of evaluation at all but you already understood that.)

I didn't do a deep analysis of what code was affected by the bug but measuring changes in the bytecode size, which is usually quite good, only two places turned up: jit-lock--debug-fontify, which you already noticed, and
c-forward-sws in cc-engine.el, where the code

	      (c-put-in-sws rung-pos
			    (setq rung-pos (point)
				  last-put-in-sws-pos rung-pos)))

was probably affected here. (Obviously the bug was out to get you personally, Alan.)






  reply	other threads:[~2023-11-13 11:19 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-11 22:48 bug#67116: byte-compile-let: reversing the order of evaluation of the clauses CAN make a difference Alan Mackenzie
2023-11-12  4:52 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-11-12  6:13   ` Eli Zaretskii
2023-11-12 14:22     ` Alan Mackenzie
2023-11-12 19:32       ` Drew Adams
2023-11-14  2:56         ` Richard Stallman
2023-11-12 16:49     ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-11-12 14:54   ` Alan Mackenzie
2023-11-12 17:06     ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-11-12 14:21 ` Mattias Engdegård
2023-11-12 14:41   ` Mattias Engdegård
2023-11-13 11:19     ` Mattias Engdegård [this message]
2023-11-13 13:14       ` Alan Mackenzie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=C48106DC-0EF3-41F5-AD69-84BA30A0C19D@gmail.com \
    --to=mattias.engdegard@gmail.com \
    --cc=67116-done@debbugs.gnu.org \
    --cc=acm@muc.de \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).