unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Yuan Fu <casouri@gmail.com>
To: mattias.engdegard@gmail.com
Cc: 59477@debbugs.gnu.org
Subject: bug#59477: python-tests fail without tree-sitter
Date: Wed, 23 Nov 2022 14:00:51 -0800	[thread overview]
Message-ID: <C405FC6C-550A-4D6F-B41D-1889C67489EC@gmail.com> (raw)
In-Reply-To: <8B252ACC-C2A1-444A-A2B2-FF8459214731@gmail.com>


Yuan Fu <casouri@gmail.com> writes:

> Mattias Engdegård <mattias.engdegard@gmail.com> writes:
>
>> The python-tests fail when Emacs is built without tree-sitter:
>
> Thanks. Seems to be some problem with expanding the font-lock region.
> I’m working on it.
>
> Yuan

The python-font-lock-assignment-statement-multiline-xxx tests failing
are due to me accidentally dropping code when copying around:

(setq-local font-lock-defaults
              `(,python-font-lock-keywords
                nil nil nil nil
                (font-lock-syntactic-face-function
                 . python-font-lock-syntactic-face-function)
                (font-lock-extend-after-change-region-function
                 . python-font-lock-extend-region)))

became

(setq-local font-lock-defaults
              `(,python-font-lock-keywords
                nil nil nil nil
                (font-lock-syntactic-face-function
                 . python-font-lock-syntactic-face-function)))

The python-tests--fill-long-first-line test fails because the retunred
buffer-string doesn’t have the newline at the end.

Specifically, the return of this form

(with-temp-buffer
      (insert "def asdf():
    \"\"\"123 123 123 123 123 123 123 123 123 123 123 123 123 SHOULDBEWRAPPED 123 123 123 123

    \"\"\"
    a = 1
")
      (python-mode)
      (goto-char (point-min))
      (forward-line 1)
      (end-of-line)
      (fill-paragraph)
      (buffer-substring-no-properties (point-min) (point-max)))

Doesn’t have the newline at the end.

But if I run this in a buffer manually I get the ending newline. I’m not
sure what’s the cause of that.  Bisecting give
7c5d4348330b206aff1f8e5bc4fd241d6a6dc0b5, but that commit doesn’t change
anything filling-related.

Yuan





  parent reply	other threads:[~2022-11-23 22:00 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-22 10:13 bug#59477: python-tests fail without tree-sitter Mattias Engdegård
2022-11-23  2:40 ` Yuan Fu
2022-11-23 22:00 ` Yuan Fu [this message]
2022-11-24  6:45   ` Eli Zaretskii
2022-11-25 16:50 ` Mattias Engdegård
2022-11-26 22:18   ` Yuan Fu
2022-11-27 13:07     ` Mattias Engdegård
2022-11-30 13:41       ` Mattias Engdegård
2022-12-04  7:51         ` Yuan Fu
2022-11-27 13:16     ` Mattias Engdegård
2022-11-27 14:48       ` kobarity
2022-11-28 10:01         ` Mattias Engdegård
2022-11-28 15:18           ` kobarity
2022-11-28 19:22             ` Mattias Engdegård
2022-11-28 10:18         ` Mattias Engdegård

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=C405FC6C-550A-4D6F-B41D-1889C67489EC@gmail.com \
    --to=casouri@gmail.com \
    --cc=59477@debbugs.gnu.org \
    --cc=mattias.engdegard@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).