unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Yuan Fu <casouri@gmail.com>
To: Randy Taylor <dev@rjt.dev>
Cc: Stefan Kangas <stefankangas@gmail.com>, 60105-done@debbugs.gnu.org
Subject: bug#60105: [PATCH] Add yaml-ts-mode
Date: Fri, 16 Dec 2022 14:55:34 -0800	[thread overview]
Message-ID: <C38AB5EC-0595-4BC6-994F-E88DAA8BD0D7@gmail.com> (raw)
In-Reply-To: <GRGdue7WG79pSYxHsUAbhTqQEUogQs5ellMAM7ccpaRJeSBC0Y53ceOeBRsaRsBmDy0AHfiajrk2eLvzm4uX6ICyZfgCJFaGMiFCT9viQks=@rjt.dev>


Randy Taylor <dev@rjt.dev> writes:

> On Thursday, December 15th, 2022 at 19:20, Stefan Kangas <stefankangas@gmail.com> wrote:
>> 
>> Randy Taylor dev@rjt.dev writes:
>> 
>> > diff --git a/lisp/progmodes/eglot.el b/lisp/progmodes/eglot.el
>> > index 9c5a361df7..4319623e64 100644
>> > --- a/lisp/progmodes/eglot.el
>> > +++ b/lisp/progmodes/eglot.el
>> > @@ -224,7 +224,7 @@ eglot-server-programs
>> > ((tex-mode context-mode texinfo-mode bibtex-mode)
>> > . ,(eglot-alternatives '("digestif" "texlab")))
>> > (erlang-mode . ("erlang_ls" "--transport" "stdio"))
>> > - (yaml-mode . ("yaml-language-server" "--stdio"))
>> > + ((yaml-mode yaml-ts-mode) . ("yaml-language-server" "--stdio"))
>> 
>> 
>> This is a nit, but I think it might make more sense to users if we put
>> the built-in mode first in the list. After all, the one we ship with
>> Emacs is, or will be, the standard mode.
>
> Sounds good to me. I'll submit another patch tomorrow making that change for the rest of the modes we've added (unless someone beats me to it).
>
> Attached is a new patch that applies cleanly against emacs-29 and has yaml-ts-mode come first for eglot.
>

LGTM, I applied the patch, thanks!

Yuan





  parent reply	other threads:[~2022-12-16 22:55 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-15 22:19 bug#60105: [PATCH] Add yaml-ts-mode Randy Taylor
2022-12-16  0:20 ` Stefan Kangas
2022-12-16  2:01   ` Randy Taylor
2022-12-16 22:55 ` Yuan Fu [this message]
2023-01-02 18:52 ` Juri Linkov
2023-01-02 21:58   ` Randy Taylor
2023-01-03 18:21     ` Juri Linkov
2023-01-04 23:30       ` Dmitry Gutov
2023-01-05 18:09         ` Juri Linkov
2023-01-06  1:55           ` Dmitry Gutov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=C38AB5EC-0595-4BC6-994F-E88DAA8BD0D7@gmail.com \
    --to=casouri@gmail.com \
    --cc=60105-done@debbugs.gnu.org \
    --cc=dev@rjt.dev \
    --cc=stefankangas@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).