From: "Jan Djärv" <jan.h.d@swipnet.se>
To: Paul Eggert <eggert@cs.ucla.edu>
Cc: "Alex Bennée" <alex.bennee@linaro.org>, 17172@debbugs.gnu.org
Subject: bug#17172: 24.3.50; Timeouts when pasting from mouse
Date: Tue, 15 Apr 2014 19:29:20 +0200 [thread overview]
Message-ID: <C161F8EE-E8F5-46DD-A285-1E5466677CE9@swipnet.se> (raw)
In-Reply-To: <534D57EA.1000503@cs.ucla.edu>
Hello.
15 apr 2014 kl. 18:01 skrev Paul Eggert <eggert@cs.ucla.edu>:
> Jan D. wrote:
>> I don't think xgselect has anything to do with this. Either a response
>> comes on the X connection, or it doesn't. It can't come anywhere else.
>
> Although there's every chance you are right, the existing code is definitely buggy: if one of glib's fds is greater than xgselect's initial fds_lim, xgselect can inspect garbage in its masks, which can't be good.
That can't happen, all masks are initialized with FD_ZERO.
If we passed masks with garbage in them to pselect we would get EINVAL back.
And we don't.
> There are some other glitches there too, e.g., mask bits might not be properly cleared if pselect times out and returns zero.
In that case, process.c does not inspect the masks, so this change fixes nothing.
>
> Since the patch fixes bugs (even if not *this* bug) I installed it as emacs-24 bzr 116966.
Well, it does not fix any user visible bug, not any theoretical bug.
If this was a general select emulation you could argue that it did not conform to the select specification, but it is not that. It is something for Emacs to use, and in that context you did not fix any bugs. Nor does these changes have anything to do with this bug, you just used it as a means to get untested code into the emacs-24 branch.
Jan D.
next prev parent reply other threads:[~2014-04-15 17:29 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-02 13:39 bug#17172: 24.3.50; Timeouts when pasting from mouse Alex Bennée
2014-04-15 8:02 ` Paul Eggert
2014-04-15 10:17 ` Jan D.
2014-04-15 11:10 ` Nicolas Richard
2014-04-15 14:01 ` Alex Bennée
2014-04-15 16:01 ` Paul Eggert
2014-04-15 17:29 ` Jan Djärv [this message]
2014-04-15 20:19 ` Paul Eggert
2014-04-15 20:41 ` Jan Djärv
2014-04-17 7:53 ` Jan Djärv
2014-04-17 8:33 ` Nicolas Richard
2014-04-17 9:20 ` Jan Djärv
2014-04-17 10:19 ` Nicolas Richard
2014-04-17 12:10 ` Jan Djärv
2014-04-29 9:22 ` Nicolas Richard
2014-04-17 16:31 ` Jan Djärv
2014-04-15 16:00 ` Eli Zaretskii
2014-04-29 9:22 ` Nicolas Richard
2014-12-24 16:58 ` bug#17172: Timeouts when pasting David A. Thompson
2014-12-27 10:39 ` Torsten Bronger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=C161F8EE-E8F5-46DD-A285-1E5466677CE9@swipnet.se \
--to=jan.h.d@swipnet.se \
--cc=17172@debbugs.gnu.org \
--cc=alex.bennee@linaro.org \
--cc=eggert@cs.ucla.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).