From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Nicolas =?UTF-8?Q?L=C3=A9veill=C3=A9?= Newsgroups: gmane.emacs.bugs Subject: bug#17519: [PATCH] take into account QuantumScale when reading imagemagick images Date: Tue, 20 May 2014 09:37:17 +0200 Message-ID: References: <537A63BC.5090408@cs.ucla.edu> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 (Mac OS X Mail 7.2 \(1874\)) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1400573931 4093 80.91.229.3 (20 May 2014 08:18:51 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 20 May 2014 08:18:51 +0000 (UTC) Cc: 17519@debbugs.gnu.org To: Paul Eggert Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue May 20 10:18:43 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Wmecs-0003Va-Rx for geb-bug-gnu-emacs@m.gmane.org; Tue, 20 May 2014 09:38:18 +0200 Original-Received: from localhost ([::1]:51716 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wmecs-0005T1-Gy for geb-bug-gnu-emacs@m.gmane.org; Tue, 20 May 2014 03:38:18 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:55268) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wmecj-0005Sg-JJ for bug-gnu-emacs@gnu.org; Tue, 20 May 2014 03:38:15 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Wmecd-0004A4-M5 for bug-gnu-emacs@gnu.org; Tue, 20 May 2014 03:38:09 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:54927) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wmecd-0004A0-IN for bug-gnu-emacs@gnu.org; Tue, 20 May 2014 03:38:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1Wmecc-0007c5-H0 for bug-gnu-emacs@gnu.org; Tue, 20 May 2014 03:38:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Nicolas =?UTF-8?Q?L=C3=A9veill=C3=A9?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 20 May 2014 07:38:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 17519 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 17519-submit@debbugs.gnu.org id=B17519.140057146729239 (code B ref 17519); Tue, 20 May 2014 07:38:02 +0000 Original-Received: (at 17519) by debbugs.gnu.org; 20 May 2014 07:37:47 +0000 Original-Received: from localhost ([127.0.0.1]:53804 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WmecN-0007bW-BW for submit@debbugs.gnu.org; Tue, 20 May 2014 03:37:47 -0400 Original-Received: from smtp4-g21.free.fr ([212.27.42.4]:44520) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WmecK-0007bK-7j for 17519@debbugs.gnu.org; Tue, 20 May 2014 03:37:45 -0400 Original-Received: from [192.168.1.105] (unknown [2.174.32.213]) (Authenticated sender: knos@free.fr) by smtp4-g21.free.fr (Postfix) with ESMTPSA id 907F44C80FC; Tue, 20 May 2014 09:36:05 +0200 (CEST) In-Reply-To: <537A63BC.5090408@cs.ucla.edu> X-Mailer: Apple Mail (2.1874) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:89265 Archived-At: I'll come back to you once I'll have tested your patch. Do you object with the other cleanups or is it poor form in this project = to clean up code while fixing a bug? (Not sure what the philosophy in = this project is, I tend to alway opportunistically do a little clean up = (in separate commits/patches) when I fix bugs as a form of low intensity = maintenance work) Cheers, Nicolas On 2014-05-19, at 22:04 , Paul Eggert wrote: > Thanks for reporting this. Does the attached simpler patch fix the = problem for you? Dividing by QuantumRange instead of multiplying by = QuantumScale avoids potential double-rounding problems in future = versions of ImageMagick. >