From: "Mattias Engdegård" <mattias.engdegard@gmail.com>
To: 65464@debbugs.gnu.org
Cc: Reto Zimmermann <reto@gnu.org>, Eli Zaretskii <eliz@gnu.org>,
justafrogg@gmail.com, Stefan Kangas <stefankangas@gmail.com>,
Stefan Monnier <monnier@iro.umontreal.ca>
Subject: bug#65464: Emacs 29.1 - VHDL mode missing updates…
Date: Sat, 2 Sep 2023 11:20:49 +0200 [thread overview]
Message-ID: <C0A5F50F-F749-40FF-915C-C18A0AE6CB43@gmail.com> (raw)
In-Reply-To: <D9BCDB16-6ED6-4F25-9EBC-93B7645CBFE2@gmail.com>
Reto, while you're at it you may also want to take a look at vhdl-last-word:
(defun vhdl-last-word (point)
"If keyword at POINT is at eoi, then return (current-column) at that point.
Otherwise, return nil."
(save-excursion
(and (goto-char point)
(save-excursion (or (eq (progn (forward-sexp) (point))
(vhdl-point 'eoi))
(looking-at "\\s-*\\(--\\)?")))
(current-column))))
Since the calls to goto-char and looking-at never return nil, this function will always return the column of its argument. (The regexp matches the empty string so looking-at will succeed anywhere.)
And because vhdl-last-word is only used for its boolean value and never returns nil, calls to this function could effectively be replaced by t, but that was probably not the intention.
next prev parent reply other threads:[~2023-09-02 9:20 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-22 16:15 bug#65464: Emacs 29.1 - VHDL mode missing updates… Tracy’s Gmail
2023-08-23 10:47 ` Stefan Kangas
2023-08-29 13:23 ` Reto Zimmermann
2023-08-29 16:46 ` Stefan Kangas
2023-08-29 16:56 ` Tracy’s Gmail
2023-08-29 18:25 ` Stefan Kangas
2023-08-30 12:23 ` Reto Zimmermann
2023-08-30 13:38 ` Eli Zaretskii
2023-08-31 11:32 ` Reto Zimmermann
2023-08-31 13:00 ` Eli Zaretskii
2023-08-31 14:59 ` Stefan Kangas
2023-08-31 18:46 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-09-10 7:47 ` Eli Zaretskii
2023-09-11 2:40 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-09-11 11:40 ` Eli Zaretskii
2023-09-02 9:20 ` Mattias Engdegård [this message]
2023-09-11 16:21 ` Mattias Engdegård
2023-09-11 22:17 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-09-12 6:59 ` Mattias Engdegård
2023-09-12 11:31 ` Eli Zaretskii
2023-09-12 14:08 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=C0A5F50F-F749-40FF-915C-C18A0AE6CB43@gmail.com \
--to=mattias.engdegard@gmail.com \
--cc=65464@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=justafrogg@gmail.com \
--cc=monnier@iro.umontreal.ca \
--cc=reto@gnu.org \
--cc=stefankangas@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).