bug#52878: [PATCH] Fix display-comint-buffer-action default behavior

bug#52878: [PATCH] Fix display-comint-buffer-action default behavior

[Morgan.J.Smith]

From: Morgan Smith <Morgan.J.Smith@outlook.com>

* lisp/window.el (display-comint-buffer-action): Make it an alist.
---

This is my first real contribution to Emacs :)

My copyright papers are all good (not that it matters for this).

The recent change that added display-comint-buffer-action does not do what it was supposed to.  Since it is not a list, when it gets passed to display-buffer, display-buffer ignores the value.

I'm not 100% I did everything right, but I looked at gdb-display-buffer-other-frame-action for reference and verified the behavior of the change myself.


 lisp/window.el | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/lisp/window.el b/lisp/window.el
index d75dd9931b..34b2d0c78a 100644
--- a/lisp/window.el
+++ b/lisp/window.el
@@ -7474,9 +7474,9 @@ display-buffer-base-action
   :version "24.1"
   :group 'windows)
 
-(defcustom display-comint-buffer-action 'display-buffer-same-window
-  "The action to display a comint buffer."
-  :type 'display-buffer--action-function-custom-type
+(defcustom display-comint-buffer-action '((display-buffer-same-window))
+  "`display-buffer' action for displaying comint buffers."
+  :type display-buffer--action-custom-type
   :risky t
   :version "29.1"
   :group 'windows
-- 
2.34.0

bug#52878: [PATCH] Fix display-comint-buffer-action default behavior

[Stefan Kangas]

Morgan.J.Smith@outlook.com writes:

> This is my first real contribution to Emacs :)

Congratulations, and welcome here!

> The recent change that added display-comint-buffer-action does not do
> what it was supposed to.  Since it is not a list, when it gets passed
> to display-buffer, display-buffer ignores the value.

I think we will see what will happen to that recent change.  There is
even talk about reverting it on emacs-devel, but nothing conclusive as
of yet.  So be aware that your patch might have to wait until that
discussion is concluded.

bug#52878: [PATCH] Fix display-comint-buffer-action default behavior

[martin rudalics]

A minor issue: The "right" initial value should probably be

'(display-buffer-same-window . ((inhibit-same-window . nil)))

since otherwise

(setq display-buffer-base-action
       '(nil . ((inhibit-same-window . t))))

would inhibit using the same window.

martin