From: Randy Taylor <dev@rjt.dev>
To: Graham Marlow <graham@mgmarlow.com>
Cc: Rudolf Schlatte <rudi@constantly.at>, 68781@debbugs.gnu.org
Subject: bug#68781: [PATCH] Don't fill yaml except comments and block scalars.
Date: Tue, 30 Jan 2024 19:25:07 +0000 [thread overview]
Message-ID: <BQTRcJ7piMRlUPUr-QYMZmFt0UQx2WyrSWQGsvoduOKYk7mZum2iVWavkzSOSX3Yv8f782kuS_sg0kPBplRsFVPuJ9dlqlOiwykxeOTxftM=@rjt.dev> (raw)
In-Reply-To: <216ddb7b-e02d-4e68-9dbb-68fa1202d198@mgmarlow.com>
On Monday, January 29th, 2024 at 20:20, Graham Marlow <graham@mgmarlow.com> wrote:
>
>
> > Hello Randy, thanks for having a look! Could you tell me which
>
> > tree-sitter grammar you are using? I'm asking because with the grammar
> > from https://github.com/ikatyang/tree-sitter-yaml I don't see what you
> > describe.
>
>
> For the record I'm also using this grammar.
>
> Looking at the patch, what do you think about retaining the existing
> behavior (so block_scalars still fill correctly) while inhibiting
> fill_paragraph for everything else as suggested? Originally I retained
> the existing behavior of fill-paragraph just to limit the number of
> things changed by the patch, not because it was working properly. I
> think blocking the call to fill-paragraph for non-block/comment nodes
> makes sense.
>
> I attached a patch w/ my edits, but it just swaps the when to and if,
> accepts the comment node type for filling, and returns t to avoid
> calling fill-paragraph for other nodes.
Thanks Graham, the patch looks good to me.
Would someone please install it on master? Thanks in advance.
next prev parent reply other threads:[~2024-01-30 19:25 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-28 13:15 bug#68781: [PATCH] Don't fill yaml except comments and block scalars Rudolf Schlatte
2024-01-28 14:52 ` Rudolf Schlatte
2024-01-29 3:47 ` Randy Taylor
2024-01-29 8:20 ` Rudolf Schlatte
2024-01-29 14:08 ` Randy Taylor
2024-01-30 1:20 ` Graham Marlow
2024-01-30 10:15 ` Rudolf Schlatte
2024-01-30 19:25 ` Randy Taylor [this message]
2024-02-01 10:31 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='BQTRcJ7piMRlUPUr-QYMZmFt0UQx2WyrSWQGsvoduOKYk7mZum2iVWavkzSOSX3Yv8f782kuS_sg0kPBplRsFVPuJ9dlqlOiwykxeOTxftM=@rjt.dev' \
--to=dev@rjt.dev \
--cc=68781@debbugs.gnu.org \
--cc=graham@mgmarlow.com \
--cc=rudi@constantly.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).