* bug#3234: fill-column+1 problem
@ 2009-05-07 11:00 Toru TSUNEYOSHI
2012-11-30 7:11 ` Chong Yidong
0 siblings, 1 reply; 3+ messages in thread
From: Toru TSUNEYOSHI @ 2009-05-07 11:00 UTC (permalink / raw)
To: bug-gnu-emacs
Hi. I met a problem about `fill-region-as-paragraph' on Emacs
22.3.1. (This problem happens on Emacs 23.0.93.1, because there is no
change of the function's code.) Please read the following.
condition:
fill-column => 10
>>> example 1 (no problems) >>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>
12345678901234567890
あいうえおかきくけこ <- fill-region (this function is a caller of
`fill-region-as-paragraph')
=>
あいうえお
かきくけこ
<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<
>>> example 2 (no good) >>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>
123456789012345678901
あいxうえおかきくけこ <- fill-region
=>
あいxうえお <- fill-column+1 problem
かきくけこ
<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<
>>> patch for the problem >>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>
--- fill.el.original 2008-08-27 00:45:42.000000000 +0900
+++ fill.el 2009-05-07 18:29:16.931120600 +0900
@@ -713,7 +713,8 @@
(move-to-column (current-fill-column))
(if (when (< (point) to)
;; Find the position where we'll break the line.
- (forward-char 1) ;Use an immediately following space, if any.
+ (unless (> (current-column) (current-fill-column))
+ (forward-char 1)) ;Use an immediately following space, if any.
(fill-move-to-break-point linebeg)
;; Check again to see if we got to the end of
;; the paragraph.
<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<
>>> example 3 (after patching, good) >>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>
123456789012345678901
あいxうえおかきくけこ <- fill-region
=>
あいxうえ <- no problem
おかきくけ
こ
<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<
Anyone can check the validity of the patch?
If invalid, I wish that someone solves the problem.
^ permalink raw reply [flat|nested] 3+ messages in thread
* bug#3234: fill-column+1 problem
2009-05-07 11:00 bug#3234: fill-column+1 problem Toru TSUNEYOSHI
@ 2012-11-30 7:11 ` Chong Yidong
2012-12-07 15:13 ` Toru TSUNEYOSHI
0 siblings, 1 reply; 3+ messages in thread
From: Chong Yidong @ 2012-11-30 7:11 UTC (permalink / raw)
To: Toru TSUNEYOSHI; +Cc: 3234-done
Toru TSUNEYOSHI <t_tuneyosi@hotmail.com> writes:
> Hi. I met a problem about `fill-region-as-paragraph' on Emacs 22.3.1.
> (This problem happens on Emacs 23.0.93.1, because there is no change
> of the function's code.)
>
> Anyone can check the validity of the patch?
> If invalid, I wish that someone solves the problem.
Sorry for the very late response. Your patch looks good, and I've just
committed it to trunk. Thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
* bug#3234: fill-column+1 problem
2012-11-30 7:11 ` Chong Yidong
@ 2012-12-07 15:13 ` Toru TSUNEYOSHI
0 siblings, 0 replies; 3+ messages in thread
From: Toru TSUNEYOSHI @ 2012-12-07 15:13 UTC (permalink / raw)
To: cyd; +Cc: 3234-done
Ah, I'd forgotten all about that!
Thank you, ありがとう (pronounce as "Arigatou")、
Chong Yidong さん (pronounce as "San").
From: Chong Yidong <cyd@gnu.org>
Subject: Re: bug#3234: fill-column+1 problem
Date: Fri, 30 Nov 2012 15:11:36 +0800
Message-ID: <87624nimzb.fsf@gnu.org>
> Toru TSUNEYOSHI <t_tuneyosi@hotmail.com> writes:
>
>> Hi. I met a problem about `fill-region-as-paragraph' on Emacs 22.3.1.
>> (This problem happens on Emacs 23.0.93.1, because there is no change
>> of the function's code.)
>>
>> Anyone can check the validity of the patch?
>> If invalid, I wish that someone solves the problem.
>
> Sorry for the very late response. Your patch looks good, and I've just
> committed it to trunk. Thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-12-07 15:13 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-05-07 11:00 bug#3234: fill-column+1 problem Toru TSUNEYOSHI
2012-11-30 7:11 ` Chong Yidong
2012-12-07 15:13 ` Toru TSUNEYOSHI
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).