From: Richard Sharman <rsharman@pobox.com>
To: 30059@debbugs.gnu.org
Subject: bug#30059: 25.3; Wrong value for comint-process-echoes will cause comint-send-input to hang
Date: Sat, 6 Feb 2021 17:04:31 -0800 [thread overview]
Message-ID: <BF56047E-F0EA-4727-B81A-5BA235A48525@pobox.com> (raw)
In-Reply-To: <CAJr1M6dsVr8d0q8CEic7+=3e9XGjG+mAPca=Vidc5n_yVbAODA@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 296 bytes --]
A simple fix is to add a timeout value to the call to accept-process-output. For example, adding a 1 second timeout not only allows it to recover but also allows Control-g to be honoured. Because control-g now is not ignored, the value could be increased substantially, say to 10 [seconds].
[-- Attachment #2: Patch-comint-send-input.txt --]
[-- Type: text/plain, Size: 530 bytes --]
--- comint.el.orig 2021-02-06 16:55:28.000000000 -0800
+++ comint.el 2021-02-06 16:57:24.000000000 -0800
@@ -1922,7 +1922,7 @@
;; Wait for all input to be echoed:
(while (and (> (+ comint-last-input-end echo-len)
(point-max))
- (accept-process-output proc)
+ (accept-process-output proc 1)
(zerop
(compare-buffer-substrings
nil comint-last-input-start
prev parent reply other threads:[~2021-02-07 1:04 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-10 6:16 bug#30059: 25.3; Wrong value for comint-process-echoes will cause comint-send-input to hang Allen Li
2020-12-09 18:36 ` Lars Ingebrigtsen
2020-12-10 3:36 ` Allen Li
2020-12-11 14:42 ` Lars Ingebrigtsen
2021-02-07 0:35 ` Richard Sharman
2021-08-13 12:55 ` Lars Ingebrigtsen
2021-02-07 1:04 ` Richard Sharman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BF56047E-F0EA-4727-B81A-5BA235A48525@pobox.com \
--to=rsharman@pobox.com \
--cc=30059@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).