From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Newsgroups: gmane.emacs.bugs Subject: bug#45502: [PATCH] Prettier key bindings in NS menu entries Date: Tue, 29 Dec 2020 15:41:03 +0100 Message-ID: References: <02937096-EAF5-4B74-A1C7-CCE6E64C67E3@acm.org> Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.17\)) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="10378"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 45502@debbugs.gnu.org, Daniel =?UTF-8?Q?Mart=C3=ADn?= To: Alan Third Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Dec 29 15:42:33 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kuGCl-0002aD-TV for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 29 Dec 2020 15:42:31 +0100 Original-Received: from localhost ([::1]:46160 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kuGCk-0000AN-I1 for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 29 Dec 2020 09:42:30 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:49690) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kuGCI-00009S-D7 for bug-gnu-emacs@gnu.org; Tue, 29 Dec 2020 09:42:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:54781) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kuGCI-0002Uu-5y for bug-gnu-emacs@gnu.org; Tue, 29 Dec 2020 09:42:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kuGCI-0005Z9-30 for bug-gnu-emacs@gnu.org; Tue, 29 Dec 2020 09:42:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 29 Dec 2020 14:42:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 45502 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 45502-submit@debbugs.gnu.org id=B45502.160925287621315 (code B ref 45502); Tue, 29 Dec 2020 14:42:02 +0000 Original-Received: (at 45502) by debbugs.gnu.org; 29 Dec 2020 14:41:16 +0000 Original-Received: from localhost ([127.0.0.1]:38086 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kuGBX-0005Xj-TI for submit@debbugs.gnu.org; Tue, 29 Dec 2020 09:41:16 -0500 Original-Received: from mail1480c50.megamailservers.eu ([91.136.14.80]:52526 helo=mail118c50.megamailservers.eu) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kuGBV-0005XS-1x for 45502@debbugs.gnu.org; Tue, 29 Dec 2020 09:41:14 -0500 X-Authenticated-User: mattiase@bredband.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megamailservers.eu; s=maildub; t=1609252866; bh=I7xMwTxRSlCIjPNXzBBrHwpEXGI2yqJx/5qLTC1K0qM=; h=Subject:From:In-Reply-To:Date:Cc:References:To:From; b=iHbAwwqXVmyBWakHLYz6xKwP50xOjsL/lf4fE1qPemDxzaWSJo71UEtMfscN8yqTT 2/DIN7DK3DlxcVne2vofBHteoEtvRqAdHhQx9pogtELS2TZOu6d9Z1B2P7BY0KVrg8 CPS4Maa8siRpI50ICU21mOu7pEydzoMvjwNOikt4= Feedback-ID: mattiase@acm.or Original-Received: from [192.168.0.4] (c188-150-171-71.bredband.comhem.se [188.150.171.71]) (authenticated bits=0) by mail118c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id 0BTEf4Eo011665; Tue, 29 Dec 2020 14:41:05 +0000 In-Reply-To: X-Mailer: Apple Mail (2.3445.104.17) X-CTCH-RefID: str=0001.0A742F1C.5FEB4002.0037, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown X-CTCH-Score: 0.000 X-CTCH-Flags: 0 X-CTCH-ScoreCust: 0.000 X-CSC: 0 X-CHA: v=2.3 cv=HYRqsRM8 c=1 sm=1 tr=0 a=SF+I6pRkHZhrawxbOkkvaA==:117 a=SF+I6pRkHZhrawxbOkkvaA==:17 a=IkcTkHD0fZMA:10 a=M51BFTxLslgA:10 a=hIj89exaAAAA:8 a=USceeXRHY8LJDdpJiVQA:9 a=QEXdDO2ut3YA:10 a=lS9wXHQM5UdnNJ4u63Ry:22 X-Origin-Country: SE X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:196933 Archived-At: 29 dec. 2020 kl. 14.53 skrev Alan Third : > Looks good. As I understand it GNUstep doesn't need this fix, so > please make it Cocoa only. Will do, but what do you mean by not needing it -- does it do any harm, = given that GNUstep menus do not appear to be working anyway? I have no = GNUstep system to try it on so I don't know if it will even build. > There was a work-around for some problem related to waiting_for_input > in the old menu code that was lost when I copied the code from > xmenu.c, so I've put it back in and pushed to master. It looks like it > fixes the crash here. Thank you, that did it. > There's also the problem that we allow setting the left and right > modifiers separately, so option or command may not match both keys. That's true. Maybe a hybrid like M-=E2=86=93 or C-=E2=8C=AB is still = fine though since the symbols are very recognisable -- I'll give it a = go.