* bug#65069: ispell-region does not preserve the region
@ 2023-08-04 11:21 Sean O'Rourke
2023-08-05 9:41 ` Eli Zaretskii
0 siblings, 1 reply; 5+ messages in thread
From: Sean O'Rourke @ 2023-08-04 11:21 UTC (permalink / raw)
To: 65069
Before Emacs 29.1, selecting a region and running ispell-region would leave point and mark unchanged. Now it leaves one end of the region at the last place ispell stopped. I don’t know if this is intended behavior, but it is less convenient than the way it worked before.
Thanks,
Sean
^ permalink raw reply [flat|nested] 5+ messages in thread
* bug#65069: ispell-region does not preserve the region
2023-08-04 11:21 bug#65069: ispell-region does not preserve the region Sean O'Rourke
@ 2023-08-05 9:41 ` Eli Zaretskii
2023-08-09 2:21 ` Sean O'Rourke
0 siblings, 1 reply; 5+ messages in thread
From: Eli Zaretskii @ 2023-08-05 9:41 UTC (permalink / raw)
To: Sean O'Rourke; +Cc: 65069
> From: Sean O'Rourke <sean@drdirtbag.com>
> Date: Fri, 4 Aug 2023 05:21:13 -0600
>
> Before Emacs 29.1, selecting a region and running ispell-region would leave point and mark unchanged. Now it leaves one end of the region at the last place ispell stopped. I don’t know if this is intended behavior, but it is less convenient than the way it worked before.
It was deliberate, see bug#14816 (and the corresponding change to the
doc string of ispell-region). With Emacs 29.1, the region is left
around the portion of text that was not yet spell-checked, so it is
more useful for continuing spell-checking. I guess we could add a
user option to avoid doing that, for those who prefer the old
behavior, but is this really needed?
^ permalink raw reply [flat|nested] 5+ messages in thread
* bug#65069: ispell-region does not preserve the region
2023-08-05 9:41 ` Eli Zaretskii
@ 2023-08-09 2:21 ` Sean O'Rourke
2023-08-09 11:29 ` Eli Zaretskii
0 siblings, 1 reply; 5+ messages in thread
From: Sean O'Rourke @ 2023-08-09 2:21 UTC (permalink / raw)
To: Eli Zaretskii; +Cc: 65069
Thanks for the prompt and thorough response, Eli. My use case is that I store multiple blog posts in a single file. When I compose one, I select it, run ispell-region, then copy-paste the corrected text into a webpage. Ispell changing the region is therefore unhelpful to me, but if that’s an uncommon usage pattern, I can just defadvice it myself to get the old behavior back — no need for another user option.
Sean
> On Aug 5, 2023, at 3:41 AM, Eli Zaretskii <eliz@gnu.org> wrote:
>
>> From: Sean O'Rourke <sean@drdirtbag.com>
>> Date: Fri, 4 Aug 2023 05:21:13 -0600
>>
>> Before Emacs 29.1, selecting a region and running ispell-region would leave point and mark unchanged. Now it leaves one end of the region at the last place ispell stopped. I don’t know if this is intended behavior, but it is less convenient than the way it worked before.
>
> It was deliberate, see bug#14816 (and the corresponding change to the
> doc string of ispell-region). With Emacs 29.1, the region is left
> around the portion of text that was not yet spell-checked, so it is
> more useful for continuing spell-checking. I guess we could add a
> user option to avoid doing that, for those who prefer the old
> behavior, but is this really needed?
^ permalink raw reply [flat|nested] 5+ messages in thread
* bug#65069: ispell-region does not preserve the region
2023-08-09 2:21 ` Sean O'Rourke
@ 2023-08-09 11:29 ` Eli Zaretskii
2023-08-20 17:04 ` Juri Linkov
0 siblings, 1 reply; 5+ messages in thread
From: Eli Zaretskii @ 2023-08-09 11:29 UTC (permalink / raw)
To: Sean O'Rourke; +Cc: 65069
> From: Sean O'Rourke <sean@drdirtbag.com>
> Date: Tue, 8 Aug 2023 20:21:14 -0600
> Cc: 65069@debbugs.gnu.org
>
> Thanks for the prompt and thorough response, Eli. My use case is that I store multiple blog posts in a single file. When I compose one, I select it, run ispell-region, then copy-paste the corrected text into a webpage. Ispell changing the region is therefore unhelpful to me, but if that’s an uncommon usage pattern, I can just defadvice it myself to get the old behavior back — no need for another user option.
OK, thanks. I'll leave the bug open so that others who'd like to have
such an option could chime in. If there's enough demand, I think we
should add it.
^ permalink raw reply [flat|nested] 5+ messages in thread
* bug#65069: ispell-region does not preserve the region
2023-08-09 11:29 ` Eli Zaretskii
@ 2023-08-20 17:04 ` Juri Linkov
0 siblings, 0 replies; 5+ messages in thread
From: Juri Linkov @ 2023-08-20 17:04 UTC (permalink / raw)
To: Eli Zaretskii; +Cc: Sean O'Rourke, 65069
>> Thanks for the prompt and thorough response, Eli. My use case is that
>> I store multiple blog posts in a single file. When I compose one,
>> I select it, run ispell-region, then copy-paste the corrected text into
>> a webpage. Ispell changing the region is therefore unhelpful to me, but
>> if that’s an uncommon usage pattern, I can just defadvice it myself to
>> get the old behavior back — no need for another user option.
>
> OK, thanks. I'll leave the bug open so that others who'd like to have
> such an option could chime in. If there's enough demand, I think we
> should add it.
It would be useful to have two possible values: to leave the
original region selected, or to deactivate the region afterwards
(for example, like 'indent-rigidly' does).
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2023-08-20 17:04 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-08-04 11:21 bug#65069: ispell-region does not preserve the region Sean O'Rourke
2023-08-05 9:41 ` Eli Zaretskii
2023-08-09 2:21 ` Sean O'Rourke
2023-08-09 11:29 ` Eli Zaretskii
2023-08-20 17:04 ` Juri Linkov
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).