From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Yuan Fu Newsgroups: gmane.emacs.bugs Subject: bug#71070: 30.0.50; c++-ts-mode namespace wrong fontification. Date: Tue, 21 May 2024 23:23:31 -0700 Message-ID: References: <87h6et6550.fsf.ref@aol.com> <87h6et6550.fsf@aol.com> <86wmnpabu0.fsf@gnu.org> <86v839aa3a.fsf@gnu.org> <86seycagbq.fsf@gnu.org> <05106743-c354-4684-b57f-e6c07f1a6e2a@gutov.dev> Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.700.6.1.1\)) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="37912"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Eli Zaretskii , Ergus , 71070@debbugs.gnu.org To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed May 22 08:25:29 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1s9fPk-0009fE-UI for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 22 May 2024 08:25:28 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1s9fPL-0003zs-4V; Wed, 22 May 2024 02:25:03 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s9fPE-0003zC-V0 for bug-gnu-emacs@gnu.org; Wed, 22 May 2024 02:24:56 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1s9fPE-0006B5-L4 for bug-gnu-emacs@gnu.org; Wed, 22 May 2024 02:24:56 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1s9fPK-0006hX-6D for bug-gnu-emacs@gnu.org; Wed, 22 May 2024 02:25:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Yuan Fu Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 22 May 2024 06:25:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 71070 X-GNU-PR-Package: emacs Original-Received: via spool by 71070-submit@debbugs.gnu.org id=B71070.171635909625725 (code B ref 71070); Wed, 22 May 2024 06:25:02 +0000 Original-Received: (at 71070) by debbugs.gnu.org; 22 May 2024 06:24:56 +0000 Original-Received: from localhost ([127.0.0.1]:53733 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s9fPE-0006gr-GF for submit@debbugs.gnu.org; Wed, 22 May 2024 02:24:56 -0400 Original-Received: from mail-oi1-f178.google.com ([209.85.167.178]:58819) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s9fPC-0006gf-FA for 71070@debbugs.gnu.org; Wed, 22 May 2024 02:24:55 -0400 Original-Received: by mail-oi1-f178.google.com with SMTP id 5614622812f47-3c99e6b8b1fso3116959b6e.1 for <71070@debbugs.gnu.org>; Tue, 21 May 2024 23:24:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1716359023; x=1716963823; darn=debbugs.gnu.org; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=1aN91pm/NzrBEdLjTUigkWFc/H/xiC0tbvu/HMrS3sM=; b=JUfWUrjD9CGjW/6GbMagySX4XF7yosgY0g2X6jz0ownKPKNT0a+t0pYYQoA/b5s09X WzRC4Wp0LdJP0AJBKbcK46NFUn99qOGEw56LDQiccqgT1ZF/EcW7fw3g4Qd05rT1+DXg E8y87WNfrXjlhl4S0u2B7+6CZAMutabrxaWEjO/awXcxskfu/JXLkemxEB86Psk2Y3qm XQ/RapcfaZTv/JFNv+Qkn38byaLQ49eACole0OvYkNAZq/W6nmyBB2BHmTqeTfQGWOXc ctg7Ri0bP4QKEOttr7jamc90xtcfGWWoGne903INMO7Ky3V4EH16J9m8UJr6TVAufmkY tudA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1716359023; x=1716963823; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=1aN91pm/NzrBEdLjTUigkWFc/H/xiC0tbvu/HMrS3sM=; b=wmG1/LBxnn0H3sVcLCSTYoG7xzrd/U3mAHqBjnZGdjERQj0XP7bPLAvYSLs8RbX8mG BHp8CumSgerewZVqWzk0DDFX7JqwmXAlKi1oi7Rr6tYVf1fSwVxQZ40cwl2w31aSbWBO D+m2phmU0zHabR7RAdYV1Adnw8uCDkLaZCqQ/sS0ExXAjIuv0be7rr8ngrBWxCwlUiGs eUk+mYb7XRO8lAJTx1mCP9efwum5fFStTxPXQDWmPQlWsrS3PkULJnONdMz2pwb6iV3a dpXTSX2CbcQdxMdh7N4yf/LHJ92F7SMDSeK6+Kxzu/rCt6XhKPfFsggOQpXyTs2Eln3J S3ww== X-Forwarded-Encrypted: i=1; AJvYcCX9xmdNAl3QZYaQNL3nY2r2AUtfvJiswUQIs4HiAR7ZbkhThc+CKS6Sarl1/FxPzf097KBVYaoGln0payBOlC9NclCG/eY= X-Gm-Message-State: AOJu0Yyt65Ka3IHr4lvFegv6PT1WznRhsxzkHYrJBaKpt1RK9Suqmkh2 BgANMKrhdHLZPULWEiWoON8d2rZLFo8UyQ10LR8FpdRd+seXHvfC X-Google-Smtp-Source: AGHT+IHAfYgNiG2XWHWR5cUbHOTN++v2ze89ppzUpKYFAUuvfPJYaGtlNX0c9EQoXZa81De679VyCw== X-Received: by 2002:aca:1105:0:b0:3c9:95a2:47f1 with SMTP id 5614622812f47-3cdb3d6e559mr1674613b6e.3.1716359023221; Tue, 21 May 2024 23:23:43 -0700 (PDT) Original-Received: from smtpclient.apple ([2601:641:300:4910:d47e:183a:1bb4:b282]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-6f4d2af2bc1sm21734971b3a.164.2024.05.21.23.23.42 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 21 May 2024 23:23:42 -0700 (PDT) In-Reply-To: <05106743-c354-4684-b57f-e6c07f1a6e2a@gutov.dev> X-Mailer: Apple Mail (2.3731.700.6.1.1) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:285580 Archived-At: > On May 21, 2024, at 4:27 PM, Dmitry Gutov wrote: >=20 > Hi Eli, >=20 > On 20/05/2024 14:11, Eli Zaretskii wrote: >>> Every editor-ide has its own approach for this. But emacs has it own >>> flavor and the ts-* intention was to keep it as close as possible to = the >>> status-quo; that's why I am reporting it here. >>>=20 >>> There are many details missing in the c/c++-ts-mode compared to >>> c-mode... but I understand that some of them are WIP while others = are >>> just too complex to port. >> I understand all that, but still: can you (or someone else) answer my >> question about the accepted practices of IDEs in this matter: do they >> highlight the namespace identifiers differently than other >> identifiers, or do they use the same highlighting? >=20 > Does the attached screenshot answer the question? It's from VS = Code. I went ahead and made c++-ts-mode fontify namespaces in constant face. = But feel free to revert or change my commit. (It=E2=80=99d be better if someone can add a new builtin face for = namespace and make it inherit from constant face, like what we did for = property face, etc.) Yuan=