unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Yuan Fu <casouri@gmail.com>
To: Dmitry Gutov <dmitry@gutov.dev>
Cc: Eli Zaretskii <eliz@gnu.org>, Ergus <spacibba@aol.com>,
	71070@debbugs.gnu.org
Subject: bug#71070: 30.0.50; c++-ts-mode namespace wrong fontification.
Date: Tue, 21 May 2024 23:23:31 -0700	[thread overview]
Message-ID: <BD2A4E2D-D920-4D36-A7B5-D27D56FC7ADF@gmail.com> (raw)
In-Reply-To: <05106743-c354-4684-b57f-e6c07f1a6e2a@gutov.dev>



> On May 21, 2024, at 4:27 PM, Dmitry Gutov <dmitry@gutov.dev> wrote:
> 
> Hi Eli,
> 
> On 20/05/2024 14:11, Eli Zaretskii wrote:
>>> Every editor-ide has its own approach for this. But emacs has it own
>>> flavor and the ts-* intention was to keep it as close as possible to the
>>> status-quo; that's why I am reporting it here.
>>> 
>>> There are many details missing in the c/c++-ts-mode compared to
>>> c-mode... but I understand that some of them are WIP while others are
>>> just too complex to port.
>> I understand all that, but still: can you (or someone else) answer my
>> question about the accepted practices of IDEs in this matter: do they
>> highlight the namespace identifiers differently than other
>> identifiers, or do they use the same highlighting?
> 
> Does the attached screenshot answer the question? It's from VS Code.<Screenshot from 2024-05-22 02-24-26.png>

I went ahead and made c++-ts-mode fontify namespaces in constant face. But feel free to revert or change my commit.

(It’d be better if someone can add a new builtin face for namespace and make it inherit from constant face, like what we did for property face, etc.)

Yuan




  reply	other threads:[~2024-05-22  6:23 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <87h6et6550.fsf.ref@aol.com>
2024-05-19 18:14 ` bug#71070: 30.0.50; c++-ts-mode namespace wrong fontification Ergus via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-05-19 18:36   ` Eli Zaretskii
2024-05-19 19:00     ` Ergus via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-05-19 19:13       ` Eli Zaretskii
2024-05-19 21:36         ` Ergus via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-05-20 11:11           ` Eli Zaretskii
2024-05-21 23:27             ` Dmitry Gutov
2024-05-22  6:23               ` Yuan Fu [this message]
2024-05-22 12:17               ` Eli Zaretskii
2024-05-22 13:33                 ` Dmitry Gutov
2024-06-06  5:28                   ` Yuan Fu
2024-06-06 20:16                     ` Dmitry Gutov
2024-06-15  8:34                       ` Eli Zaretskii
2024-06-19  6:27                         ` Yuan Fu
2024-06-19 11:52                           ` Eli Zaretskii
2024-06-21  1:53                             ` Yuan Fu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=BD2A4E2D-D920-4D36-A7B5-D27D56FC7ADF@gmail.com \
    --to=casouri@gmail.com \
    --cc=71070@debbugs.gnu.org \
    --cc=dmitry@gutov.dev \
    --cc=eliz@gnu.org \
    --cc=spacibba@aol.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).