From: "Matz, Daniel A. (JSC-EG511)" <daniel.a.matz@nasa.gov>
To: Michael Albinus <michael.albinus@gmx.de>
Cc: "28959@debbugs.gnu.org" <28959@debbugs.gnu.org>
Subject: bug#28959: 25.3; Tramp not honoring `tramp-backup-directory-alist'
Date: Thu, 26 Oct 2017 16:38:17 +0000 [thread overview]
Message-ID: <BD14D241-B359-4241-A265-F458F7239A6E@nasa.gov> (raw)
In-Reply-To: <87she5riv6.fsf@gmx.de>
Michael,
I double checked my checkout, and it is recent and includes your commit.
For the tests, 43/58 does indeed pass. Here’s the summary that prints at the end:
--8<---------------cut here---------------start------------->8---
Ran 58 tests, 54 results as expected, 1 unexpected, 3 skipped (2017-10-26 11:33:34-0500)
1 expected failures
1 unexpected results:
FAILED tramp-test30-environment-variables-and-port-numbers
3 skipped results:
SKIPPED tramp-test36-special-characters-with-stat
SKIPPED tramp-test37-utf8-with-stat
SKIPPED tramp-test38-file-system-info
--8<---------------cut here---------------end--------------->8---
The only other failure was 11/58 tramp-test05-expand-file-name-relative, which I suppose must be the expected failure that is mentioned.
Daniel
> On Oct 26, 2017, at 11:09 AM, Michael Albinus <michael.albinus@gmx.de> wrote:
>
> "Matz, Daniel A. (JSC-EG511)" <daniel.a.matz@nasa.gov> writes:
>
>> Hi, Michael.
>
> Hi Daniel,
>
> [Pls keep 28959@debbugs.gnu.org in Cc, for the archives]
>
>> I built the emacs-26 branch and started emacs with -Q, and
>> unfortunately the backup files are still being created on the remote
>> system, in the same directory as the file I am visiting.
>>
>> Is there anything else I can do to help you debug this?
>
> Could you pls check that your checkout is recent? It must contain
>
> --8<---------------cut here---------------start------------->8---
> ~/src/emacs-26> git log
> commit 646e56e150ca08978d6ce736b12867b4958a0cd8 (HEAD -> emacs-26, origin/emacs-26)
> Author: Michael Albinus <michael.albinus@gmx.de>
> Date: Thu Oct 26 16:24:28 2017 +0200
>
> Fix Bug#28959
>
> * lisp/net/tramp.el (tramp-handle-find-backup-file-name):
> Use `tramp-tramp-file-p' rather than `tramp-file-name-p'. Add
> hop to backup file name. (Bug#28959)
> --8<---------------cut here---------------end--------------->8---
>
> Furthermore, you might run
>
> --8<---------------cut here---------------start------------->8---
> ~/src/emacs-26> make -C test tramp-tests
> --8<---------------cut here---------------end--------------->8---
>
> There are several Tramp tests; the most interesting is
>
> --8<---------------cut here---------------start------------->8---
> passed 43/58 tramp-test34-find-backup-file-name
> --8<---------------cut here---------------end--------------->8---
>
> Do you see this?
>
>> Thanks!
>>
>> Daniel
>
> Best regards, Michael.
next prev parent reply other threads:[~2017-10-26 16:38 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-23 19:46 bug#28959: 25.3; Tramp not honoring `tramp-backup-directory-alist' Matz, Daniel A. (JSC-EG511)
2017-10-24 13:41 ` Michael Albinus
2017-10-26 14:28 ` Michael Albinus
[not found] ` <AB7D8E8C-D1B9-432B-B711-0425DE940795@nasa.gov>
2017-10-26 16:09 ` Michael Albinus
2017-10-26 16:38 ` Matz, Daniel A. (JSC-EG511) [this message]
2017-10-26 17:39 ` Michael Albinus
[not found] ` <378F4BC2-D081-4922-BCDB-1C3D1355FE92@nasa.gov>
[not found] ` <873760zhvr.fsf@gmx.de>
[not found] ` <3BA2EAB9-DDF2-4581-B679-E1BA70812EFB@nasa.gov>
2017-10-30 17:34 ` Michael Albinus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BD14D241-B359-4241-A265-F458F7239A6E@nasa.gov \
--to=daniel.a.matz@nasa.gov \
--cc=28959@debbugs.gnu.org \
--cc=michael.albinus@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).