From: Mou Tong <mou.tong@outlook.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: "65359@debbugs.gnu.org" <65359@debbugs.gnu.org>
Subject: bug#65359: [PATCH] eglot: add "lexical" LSP server
Date: Fri, 18 Aug 2023 07:08:42 +0000 [thread overview]
Message-ID: <BC475E89-CAD0-431B-B4EB-1D4A749DDA01@outlook.com> (raw)
In-Reply-To: <83fs4g4zwv.fsf@gnu.org>
[-- Attachment #1: Type: text/plain, Size: 575 bytes --]
Eli Zaretskii <eliz@gnu.org> writes:
> Then we should make this entry be in effect only on systems that
> aren't Windows.
>
> I don't mind installing this now, but only if it doesn't break Elixir
> support on Windows, which would mean this new entry should be hidden
> when Emacs runs on Windows.
Oh, I see, here is the new patch, I'm using the `eglot-alternatives`
in the else so we don't see lexical on Windows.
> I also don't mind waiting...
Actually I'd like it got merged so I needn't to keep the hack in my
configuration. (Forgive me laziness...)
[-- Attachment #2: 0001-Add-lexical-LSP-server-to-Eglot.patch --]
[-- Type: application/octet-stream, Size: 1185 bytes --]
From 18161aea6287ffd177834fdac156f6037c410856 Mon Sep 17 00:00:00 2001
From: dalu <mou.tong@outlook.com>
Date: Thu, 17 Aug 2023 18:34:42 +0800
Subject: [PATCH] Add "lexical" LSP server to Eglot
lexical does not support Windows currently
---
lisp/progmodes/eglot.el | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/lisp/progmodes/eglot.el b/lisp/progmodes/eglot.el
index 113ff08e94e..65daa0941d5 100644
--- a/lisp/progmodes/eglot.el
+++ b/lisp/progmodes/eglot.el
@@ -222,7 +222,8 @@ eglot-server-programs
. ,(if (and (fboundp 'w32-shell-dos-semantics)
(w32-shell-dos-semantics))
'("language_server.bat")
- '("language_server.sh")))
+ (eglot-alternatives
+ '("language_server.sh" "start_lexical.sh"))))
(ada-mode . ("ada_language_server"))
(scala-mode . ,(eglot-alternatives
'("metals" "metals-emacs")))
--
2.41.0
next prev parent reply other threads:[~2023-08-18 7:08 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-18 1:38 bug#65359: [PATCH] eglot: add "lexical" LSP server Mou Tong
2023-08-18 6:00 ` Eli Zaretskii
2023-08-18 6:19 ` Mou Tong
2023-08-18 6:39 ` Eli Zaretskii
2023-08-18 7:08 ` Mou Tong [this message]
2023-08-19 8:38 ` Eli Zaretskii
2023-08-19 10:51 ` João Távora
2023-08-19 14:11 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BC475E89-CAD0-431B-B4EB-1D4A749DDA01@outlook.com \
--to=mou.tong@outlook.com \
--cc=65359@debbugs.gnu.org \
--cc=eliz@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).