* bug#13085: 24.3.50; (invalid-function internal--called-interactively-p--get-frame)
@ 2012-12-05 0:44 Drew Adams
2012-12-05 4:13 ` Stefan Monnier
0 siblings, 1 reply; 14+ messages in thread
From: Drew Adams @ 2012-12-05 0:44 UTC (permalink / raw
To: 13085
(defadvice narrow-to-region (before foo activate)
"..."
(interactive-p))
M-x ad-activate foo ; Why is this necessary?
M-x set-variable debug-on-error t
C-x n n ; Then you get the backtrace:
Debugger entered--Lisp error: (invalid-function
internal--called-interactively-p--get-frame)
internal--called-interactively-p--get-frame(5)
#[771 "..." [internal--called-interactively-p--get-frame] 6 "\n\n(fn FRAME1
FRAME2 I)"](((t apply ad-Advice-narrow-to-region #<subr narrow-to-region> (192
262))) ((t apply ad-Advice-narrow-to-region #<subr narrow-to-region> (192 262)))
(5))
advice--called-interactively-skip(5 (t ad-Advice-narrow-to-region #<subr
narrow-to-region> 192 262) (t apply ad-Advice-narrow-to-region #<subr
narrow-to-region> (192 262)))
run-hook-with-args-until-success(advice--called-interactively-skip 5 (t
ad-Advice-narrow-to-region #<subr narrow-to-region> 192 262) (t apply
ad-Advice-narrow-to-region #<subr narrow-to-region> (192 262)))
called-interactively-p(interactive)
interactive-p()
(let (ad-return-value) (interactive-p) (setq ad-return-value (with-no-warnings
(funcall ad--addoit-function start end))) ad-return-value)
ad-Advice-narrow-to-region(#<subr narrow-to-region> 192 262)
apply(ad-Advice-narrow-to-region #<subr narrow-to-region> (192 262))
narrow-to-region(192 262)
call-interactively(narrow-to-region nil nil)
In GNU Emacs 24.3.50.1 (i386-mingw-nt5.1.2600)
of 2012-12-03 on MS-W7-DANI
Bzr revision: 111077
agustin.martin@hispalinux.es-20121203172342-ifsebjmhksk28qa9
Windowing system distributor `Microsoft Corp.', version 5.1.2600
Configured using:
`configure --with-gcc (4.7) --no-opt --enable-checking --cflags
-Ic:/emacs/libs/libXpm-3.5.10/include -Ic:/emacs/libs/libXpm-3.5.10/src
-Ic:/emacs/libs/libpng-1.2.37-lib/include -Ic:/emacs/libs/zlib-1.2.5
-Ic:/emacs/libs/giflib-4.1.4-1-lib/include
-Ic:/emacs/libs/jpeg-6b-4-lib/include
-Ic:/emacs/libs/tiff-3.8.2-1-lib/include
-Ic:/emacs/libs/libxml2-2.7.8-w32-bin/include/libxml2
-Ic:/emacs/libs/gnutls-3.0.9-w32-bin/include
-Ic:/emacs/libs/libiconv-1.9.2-1-lib/include'
^ permalink raw reply [flat|nested] 14+ messages in thread
* bug#13085: 24.3.50; (invalid-function internal--called-interactively-p--get-frame)
2012-12-05 0:44 bug#13085: 24.3.50; (invalid-function internal--called-interactively-p--get-frame) Drew Adams
@ 2012-12-05 4:13 ` Stefan Monnier
2012-12-05 4:19 ` Drew Adams
0 siblings, 1 reply; 14+ messages in thread
From: Stefan Monnier @ 2012-12-05 4:13 UTC (permalink / raw
To: Drew Adams; +Cc: 13085
> Debugger entered--Lisp error: (invalid-function
> internal--called-interactively-p--get-frame)
> internal--called-interactively-p--get-frame(5)
> #[771 "..." [internal--called-interactively-p--get-frame] 6 "\n\n(fn FRAME1
> FRAME2 I)"](((t apply ad-Advice-narrow-to-region #<subr narrow-to-region> (192
> 262))) ((t apply ad-Advice-narrow-to-region #<subr narrow-to-region> (192 262)))
> (5))
> advice--called-interactively-skip(5 (t ad-Advice-narrow-to-region #<subr narrow-to-region> 192 262) (t apply ad-Advice-narrow-to-region #<subr narrow-to-region> (192 262)))
It looks like your nadvice.el was miscompiled, or compiled with an Emacs
that had an old subr.el (one without the
internal--called-interactively-p--get-frame macro).
My own bootstrapped `emacs' does not suffer from this problem, so I'm
not sure what caused this problem.
Stefan
^ permalink raw reply [flat|nested] 14+ messages in thread* bug#13085: 24.3.50; (invalid-function internal--called-interactively-p--get-frame)
2012-12-05 4:13 ` Stefan Monnier
@ 2012-12-05 4:19 ` Drew Adams
2012-12-05 4:59 ` Stefan Monnier
0 siblings, 1 reply; 14+ messages in thread
From: Drew Adams @ 2012-12-05 4:19 UTC (permalink / raw
To: 'Stefan Monnier'; +Cc: 13085
> It looks like your nadvice.el was miscompiled, or compiled
> with an Emacs that had an old subr.el (one without the
> internal--called-interactively-p--get-frame macro).
>
> My own bootstrapped `emacs' does not suffer from this problem, so I'm
> not sure what caused this problem.
OK, but my nadvice.elc is the one delivered with the Emacs binary I downloaded.
I did not compile nadvice.el myself. See the build info in the original report.
HTH.
^ permalink raw reply [flat|nested] 14+ messages in thread
* bug#13085: 24.3.50; (invalid-function internal--called-interactively-p--get-frame)
2012-12-05 4:19 ` Drew Adams
@ 2012-12-05 4:59 ` Stefan Monnier
2012-12-07 17:27 ` Drew Adams
2012-12-07 20:31 ` nyc4bos
0 siblings, 2 replies; 14+ messages in thread
From: Stefan Monnier @ 2012-12-05 4:59 UTC (permalink / raw
To: Drew Adams; +Cc: 13085
> OK, but my nadvice.elc is the one delivered with the Emacs binary
> I downloaded. I did not compile nadvice.el myself.
I kind of guessed it, but that just pushes the question elsewhere.
IOW, we need to hear from those who built this binary.
Stefan
^ permalink raw reply [flat|nested] 14+ messages in thread* bug#13085: 24.3.50; (invalid-function internal--called-interactively-p--get-frame)
2012-12-05 4:59 ` Stefan Monnier
@ 2012-12-07 17:27 ` Drew Adams
2012-12-07 18:40 ` Dani Moncayo
2012-12-07 20:31 ` nyc4bos
1 sibling, 1 reply; 14+ messages in thread
From: Drew Adams @ 2012-12-07 17:27 UTC (permalink / raw
To: 'Stefan Monnier', 'Dani Moncayo'; +Cc: 13085
> > OK, but my nadvice.elc is the one delivered with the Emacs binary
> > I downloaded. I did not compile nadvice.el myself.
>
> I kind of guessed it, but that just pushes the question elsewhere.
> IOW, we need to hear from those who built this binary.
Any chance we could get a new Windows binary without this problem soon? This
one is unusable.
^ permalink raw reply [flat|nested] 14+ messages in thread
* bug#13085: 24.3.50; (invalid-function internal--called-interactively-p--get-frame)
2012-12-07 17:27 ` Drew Adams
@ 2012-12-07 18:40 ` Dani Moncayo
2012-12-07 18:55 ` Drew Adams
2012-12-07 21:36 ` Stefan Monnier
0 siblings, 2 replies; 14+ messages in thread
From: Dani Moncayo @ 2012-12-07 18:40 UTC (permalink / raw
To: Drew Adams; +Cc: 13085
>> > OK, but my nadvice.elc is the one delivered with the Emacs binary
>> > I downloaded. I did not compile nadvice.el myself.
>>
>> I kind of guessed it, but that just pushes the question elsewhere.
>> IOW, we need to hear from those who built this binary.
>
> Any chance we could get a new Windows binary without this problem soon? This
> one is unusable.
Probably, I'll upload a new build on Monday.
FWIW:
* I've not bootstrapped Emacs for a while. So my last binaries are
compiled without bootstrapping.
* I've tried to reproduce your recipe in the OP, but I can't. I
evaluate the defadvice and then do `M-x ad-activate <RET> foo <RET>'
but `foo' is not a valid argument there. If you give me a precise
recipe, I'll try to reproduce the steps and see if the Lisp debugger
fires up.
--
Dani Moncayo
^ permalink raw reply [flat|nested] 14+ messages in thread
* bug#13085: 24.3.50; (invalid-function internal--called-interactively-p--get-frame)
2012-12-07 18:40 ` Dani Moncayo
@ 2012-12-07 18:55 ` Drew Adams
2012-12-07 20:51 ` Drew Adams
2012-12-07 21:36 ` Stefan Monnier
1 sibling, 1 reply; 14+ messages in thread
From: Drew Adams @ 2012-12-07 18:55 UTC (permalink / raw
To: 'Dani Moncayo'; +Cc: 13085
> Probably, I'll upload a new build on Monday.
Thanks.
> FWIW:
> * I've not bootstrapped Emacs for a while. So my last binaries are
> compiled without bootstrapping.
> * I've tried to reproduce your recipe in the OP, but I can't. I
> evaluate the defadvice and then do `M-x ad-activate <RET> foo <RET>'
> but `foo' is not a valid argument there. If you give me a precise
> recipe, I'll try to reproduce the steps and see if the Lisp debugger
> fires up.
Sorry, I don't have a recipe. I have no idea what's going on. Perhaps Stefan
has an idea. Note that someone else reported the same bug (as #13097).
FWIW, I've also had other problems with that last build - e.g., bugs #13113,
#13114, and #13116. I've gone back to using the build from 11/19, which is the
last one that doesn't seem to have many problems.
Thx - Drew
^ permalink raw reply [flat|nested] 14+ messages in thread
* bug#13085: 24.3.50; (invalid-function internal--called-interactively-p--get-frame)
2012-12-07 18:55 ` Drew Adams
@ 2012-12-07 20:51 ` Drew Adams
0 siblings, 0 replies; 14+ messages in thread
From: Drew Adams @ 2012-12-07 20:51 UTC (permalink / raw
To: 'Dani Moncayo'; +Cc: 13085, nyc4bos
> Sorry, I don't have a recipe. I have no idea what's going
> on. Perhaps Stefan has an idea. Note that someone else
> reported the same bug (as #13097).
I can consistently get it to happen by, after loading my setup (which uses
byte-compiled files), loading one of the source files *.el whose .elc was
loaded.
But attempts to bifurcate that file to see what might be going on have failed.
It seems unpredictable which portions of the file can trigger the problem.
Without finding some specific bit of code that would also repro the pb outside
my setup, I'm afraid we'll just have to wait for the next build and see if
perhaps that fixes the problem.
^ permalink raw reply [flat|nested] 14+ messages in thread
* bug#13085: 24.3.50; (invalid-function internal--called-interactively-p--get-frame)
2012-12-07 18:40 ` Dani Moncayo
2012-12-07 18:55 ` Drew Adams
@ 2012-12-07 21:36 ` Stefan Monnier
2012-12-07 21:42 ` Eli Zaretskii
1 sibling, 1 reply; 14+ messages in thread
From: Stefan Monnier @ 2012-12-07 21:36 UTC (permalink / raw
To: Dani Moncayo; +Cc: 13085
> Probably, I'll upload a new build on Monday.
Then just "rm lisp/emacs-lisp/nadvice.elc" before rebuilding (that will
save you the trouble of a whole bootstrap).
Maybe "rm lisp/emacs-lisp/edebug.elc" is also needed. Basically check
find -name '*.elc' | xargs grep internal--called-interactively-p--get-frame"
and make sure this only appears in subr.elc.
Stefan
^ permalink raw reply [flat|nested] 14+ messages in thread* bug#13085: 24.3.50; (invalid-function internal--called-interactively-p--get-frame)
2012-12-07 21:36 ` Stefan Monnier
@ 2012-12-07 21:42 ` Eli Zaretskii
0 siblings, 0 replies; 14+ messages in thread
From: Eli Zaretskii @ 2012-12-07 21:42 UTC (permalink / raw
To: Stefan Monnier; +Cc: 13085
> From: Stefan Monnier <monnier@iro.umontreal.ca>
> Date: Fri, 07 Dec 2012 16:36:00 -0500
> Cc: 13085@debbugs.gnu.org
>
> find -name '*.elc' | xargs grep internal--called-interactively-p--get-frame"
On Windows, it is easier to do
fgrep -R internal--called-interactively-p--get-frame . --include="*.elc"
^ permalink raw reply [flat|nested] 14+ messages in thread
* bug#13085: 24.3.50; (invalid-function internal--called-interactively-p--get-frame)
2012-12-05 4:59 ` Stefan Monnier
2012-12-07 17:27 ` Drew Adams
@ 2012-12-07 20:31 ` nyc4bos
2012-12-07 21:29 ` Dani Moncayo
1 sibling, 1 reply; 14+ messages in thread
From: nyc4bos @ 2012-12-07 20:31 UTC (permalink / raw
To: 13085
Stefan Monnier <monnier@iro.umontreal.ca> writes:
>> OK, but my nadvice.elc is the one delivered with the Emacs binary
>> I downloaded. I did not compile nadvice.el myself.
>
> I kind of guessed it, but that just pushes the question elsewhere.
> IOW, we need to hear from those who built this binary.
FWIW, I got a similiar error message but I wasn't using "advice",
just ^X^W (`write-file') -- bug#13097.
Thanks.
^ permalink raw reply [flat|nested] 14+ messages in thread
* bug#13085: 24.3.50; (invalid-function internal--called-interactively-p--get-frame)
2012-12-07 20:31 ` nyc4bos
@ 2012-12-07 21:29 ` Dani Moncayo
2012-12-07 22:19 ` Drew Adams
0 siblings, 1 reply; 14+ messages in thread
From: Dani Moncayo @ 2012-12-07 21:29 UTC (permalink / raw
To: nyc4bos; +Cc: 13085
>>> OK, but my nadvice.elc is the one delivered with the Emacs binary
>>> I downloaded. I did not compile nadvice.el myself.
>>
>> I kind of guessed it, but that just pushes the question elsewhere.
>> IOW, we need to hear from those who built this binary.
>
> FWIW, I got a similiar error message but I wasn't using "advice",
> just ^X^W (`write-file') -- bug#13097.
I've made and uploaded a new build of the trunk, this time with a full
bootstrap.
I hope this one works well.
--
Dani Moncayo
^ permalink raw reply [flat|nested] 14+ messages in thread
* bug#13085: 24.3.50; (invalid-function internal--called-interactively-p--get-frame)
2012-12-07 21:29 ` Dani Moncayo
@ 2012-12-07 22:19 ` Drew Adams
2012-12-10 22:53 ` nyc4bos
0 siblings, 1 reply; 14+ messages in thread
From: Drew Adams @ 2012-12-07 22:19 UTC (permalink / raw
To: 'Dani Moncayo', nyc4bos; +Cc: 13085
> I've made and uploaded a new build of the trunk, this time with a full
> bootstrap.
>
> I hope this one works well.
Thx. I tried it and so far so good. At least when I run the recipe that
faithfully raises the problem in the previous build there is no problem with the
latest one. Thx for the quick update.
^ permalink raw reply [flat|nested] 14+ messages in thread
* bug#13085: 24.3.50; (invalid-function internal--called-interactively-p--get-frame)
2012-12-07 22:19 ` Drew Adams
@ 2012-12-10 22:53 ` nyc4bos
0 siblings, 0 replies; 14+ messages in thread
From: nyc4bos @ 2012-12-10 22:53 UTC (permalink / raw
To: Drew Adams; +Cc: 13085
"Drew Adams" <drew.adams@oracle.com> writes:
>> I've made and uploaded a new build of the trunk, this time with a full
>> bootstrap.
>>
>> I hope this one works well.
>
> Thx. I tried it and so far so good. At least when I run the recipe that
> faithfully raises the problem in the previous build there is no problem with the
> latest one. Thx for the quick update.
It is working so far for me as well.
Thanks for you efforts and quick update Dani.
^ permalink raw reply [flat|nested] 14+ messages in thread
end of thread, other threads:[~2012-12-10 22:53 UTC | newest]
Thread overview: 14+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-12-05 0:44 bug#13085: 24.3.50; (invalid-function internal--called-interactively-p--get-frame) Drew Adams
2012-12-05 4:13 ` Stefan Monnier
2012-12-05 4:19 ` Drew Adams
2012-12-05 4:59 ` Stefan Monnier
2012-12-07 17:27 ` Drew Adams
2012-12-07 18:40 ` Dani Moncayo
2012-12-07 18:55 ` Drew Adams
2012-12-07 20:51 ` Drew Adams
2012-12-07 21:36 ` Stefan Monnier
2012-12-07 21:42 ` Eli Zaretskii
2012-12-07 20:31 ` nyc4bos
2012-12-07 21:29 ` Dani Moncayo
2012-12-07 22:19 ` Drew Adams
2012-12-10 22:53 ` nyc4bos
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).