From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#35179: [PATCH] Plug memory leak in GTK x-display-monitor-attributes-list Date: Sun, 07 Apr 2019 09:37:29 +0300 Message-ID: References: <87a7h2z96i.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="79716"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: K-9 Mail for Android To: 35179@debbugs.gnu.org, agrambot@gmail.com Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Apr 07 08:38:16 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hD1RU-000KYp-Os for geb-bug-gnu-emacs@m.gmane.org; Sun, 07 Apr 2019 08:38:12 +0200 Original-Received: from localhost ([127.0.0.1]:35185 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hD1RT-00007j-KV for geb-bug-gnu-emacs@m.gmane.org; Sun, 07 Apr 2019 02:38:11 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:48860) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hD1RL-00007M-Ni for bug-gnu-emacs@gnu.org; Sun, 07 Apr 2019 02:38:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hD1RK-0008Jd-TY for bug-gnu-emacs@gnu.org; Sun, 07 Apr 2019 02:38:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:34174) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hD1RK-0008JY-Nq for bug-gnu-emacs@gnu.org; Sun, 07 Apr 2019 02:38:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hD1RK-00084L-Jp for bug-gnu-emacs@gnu.org; Sun, 07 Apr 2019 02:38:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 07 Apr 2019 06:38:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35179 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch X-Debbugs-Original-To: bug-gnu-emacs@gnu.org, Alex , 35179@debbugs.gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.155461906230988 (code B ref -1); Sun, 07 Apr 2019 06:38:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 7 Apr 2019 06:37:42 +0000 Original-Received: from localhost ([127.0.0.1]:47718 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hD1R0-00083k-JZ for submit@debbugs.gnu.org; Sun, 07 Apr 2019 02:37:42 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:34428) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hD1Qx-00083J-HY for submit@debbugs.gnu.org; Sun, 07 Apr 2019 02:37:39 -0400 Original-Received: from lists.gnu.org ([209.51.188.17]:39521) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hD1Qs-00088x-Bb for submit@debbugs.gnu.org; Sun, 07 Apr 2019 02:37:34 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:48807) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hD1Qr-0008WJ-Di for bug-gnu-emacs@gnu.org; Sun, 07 Apr 2019 02:37:34 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:50959) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hD1Qr-00088X-5F; Sun, 07 Apr 2019 02:37:33 -0400 Original-Received: from [176.12.198.195] (port=38085 helo=[10.208.135.60]) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1hD1Qq-0002zA-Bu; Sun, 07 Apr 2019 02:37:32 -0400 In-Reply-To: <87a7h2z96i.fsf@gmail.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:157303 Archived-At: On April 7, 2019 8:16:53 AM GMT+03:00, Alex wrote: > Also declare `name' in MonitorInfo const to satisfy the compiler=2E >=20 > Is it too late to push a memory leak fix like this to emacs-26? Yes, it's too late for such non-trivial changes in Emacs 26=2E2=2E But I have a more fundamental problem with your proposed patch: it looks l= ike you are relying on implementation details of gdk_monitor_get_model that= its documentation never advertises? Otherwise, how did you know that just= removing the g_strdup call will plug a memory leak here, and will not crea= te any new problems? I'd prefer to leave g_strdup intact, and instead explicitly release the st= orage of previous value=2E IOW, plug the leak in our own code, not rely on= undocumented features which can easily go away some day=2E Thanks=2E